fabi/EventSnap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(export): give the keepsake viewer the two-phase preflight it was meant to get

Browse Source 
The two-phase preflight from eb0e405 landed in ONE place and was spliced inside
the other. `run_zip_export` ended up containing both blocks nested, so the
Gallery path pruned "Memories" archives that were not its to reclaim, while
`run_html_export` silently kept the single-phase form.

That left the exact deadlock the two-phase preflight exists to break, still
open on half the product. At a gallery size where a rebuild needs the previous
generation's bytes: the ZIP prunes its own superseded archive and rebuilds, and
the HTML preflight fails against a Memories archive still on disk. The prune
that would free it runs only after a success that can never happen, and any
epoch bump — a guest deleting one photo — retires the current viewer
immediately. Permanently stuck, unreachable from any handler, discovered at the
end of the night with nobody there.

Both halves now call one `ensure_export_space_reclaiming`, keyed on the
caller's OWN prefix, so they cannot drift again.

Three smaller things found in the same pass:

- The boot-failure panel hardcoded light-mode colours, and its heading set none
  at all — the UA default black on the `#100f0f` dark background. On the one
  screen whose entire job is to be readable, and in the failure mode where the
  app's own stylesheet may be what did not load. Moved to classes in the inline
  <style> so the `html.dark` variants apply.

- `.env.example` assigned RUST_LOG twice, 120 lines apart. Compose takes the
  last one, so an operator raising the level mid-event to chase a problem would
  have changed nothing, silently.

- The comment justifying `detail = ?message` in error.rs still claimed
  `validate_display_name` allows newlines. It rejects control characters now —
  but that is one input against every 4xx message in the app, so the escaping
  is what makes the guarantee general. Said so.

151/151 backend, 58/58 vitest, clippy clean, svelte-check 0 errors, both
builds, caddy validate.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-08-08 22:48:22 +02:00
parent 5b705317ef
commit 253878e027
4 changed files with 108 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
backend/src/error.rs
View File

@@ -99,12 +99,15 @@ impl IntoResponse for AppError {
//
// * `message` is tracing's own reserved field for an event's format literal, so `%message`
// printed unlabelled and would collide under a JSON layer.
// * Debug formatting QUOTES AND ESCAPES the string. `validate_display_name` allows
// newlines (it rejects only NUL and length), and several 4xx messages interpolate the
// guest's chosen name — `Der Name "X" ist bereits vergeben.` So with Display
// formatting, two unauthenticated `/join` requests could forge arbitrary lines in the
// only forensic record an unattended event has: pick a name containing a newline and a
// plausible log prefix, then trigger the 409. Escaping closes that.
// * Debug formatting QUOTES AND ESCAPES the string, and several 4xx messages interpolate
// attacker-chosen text — the guest's name in `Der Name "X" ist bereits vergeben.`, and
// multipart/parse errors that echo their input. With Display formatting, a value
// carrying a newline plus a plausible log prefix lets two unauthenticated requests
// forge lines in the only forensic record an unattended event has.
// `validate_display_name` now rejects control characters, so the name route is closed
// at the source as well — but that is ONE input, and this line formats every 4xx
// message in the app. Escaping here is what makes the guarantee general; do not
// "simplify" it to `%message` on the grounds that names are already validated.
//
// 401 and 404 are logged at DEBUG rather than WARN. They carry no operator signal (an
// expired session, a mistyped URL) and they are the cheapest lines for a scanner to

87
backend/src/services/export.rs
View File

@@ -483,6 +483,45 @@ pub fn spawn_export_jobs(
});
}
/// Preflight that will sacrifice the previous generation rather than deadlock, and the order is
/// the whole point.
///
/// Deferring the prune (so a failed rebuild can never leave the event with no archive at all) has
/// a cost the first version of this did not follow through on: at rebuild time the previous
/// generation is still on disk and still counted against free space, so the preflight demands room
/// for BOTH. That halves the gallery size a rebuild can survive relative to the size the upload
/// gate allows — and every path that bumps the epoch (a guest deleting their own photo, a caption
/// edit, a ban, "Neu erzeugen") retires the current keepsake IMMEDIATELY on commit. So above that
/// threshold the download 404s, the rebuild is refused, and the only thing that could free the
/// space is the prune that now only runs on success. Permanently stuck, unreachable from any
/// handler.
///
/// So: try to build while preserving the old generation. If that genuinely does not fit, the old
/// generation is the one thing we can reclaim — sacrifice it and try once more. A keepsake that
/// exists beats one we preserved but can never replace.
///
/// SHARED by both halves deliberately. This started as two copies and one of them (HTML) silently
/// kept the single-phase form, so the ZIP archive rebuilt and the viewer stayed permanently stuck
/// — the exact deadlock above, on half the product. `prefix` is the only thing that differs, and
/// it must be the caller's OWN prefix: pruning the other half's archives from here would reclaim
/// space a sibling worker is about to need, on its behalf, without its knowledge.
async fn ensure_export_space_reclaiming(
pool: &PgPool,
event_id: Uuid,
export_path: &Path,
prefix: &str,
epoch: i64,
) -> Result<()> {
if ensure_export_space(pool, event_id, export_path).await.is_ok() {
return Ok(());
}
tracing::warn!(
"not enough room to rebuild {prefix} alongside the previous keepsake; reclaiming it first"
);
prune_superseded_archives(pool, export_path, prefix, event_id, epoch).await;
ensure_export_space(pool, event_id, export_path).await
}
// ── ZIP export ───────────────────────────────────────────────────────────────
async fn run_zip_export(
@@ -503,49 +542,7 @@ async fn run_zip_export(
// `pending` with no worker and no error — the spinner-forever state `mark_failed`'s status
// guard was widened to prevent. Failing here goes through the caller's `mark_failed`, so the
// host gets the reason.
// Two-phase, and the order is the whole point.
//
// Deferring the prune (so a failed rebuild can never leave the event with no archive at
// all) has a cost the first version of this did not follow through on: at rebuild time the
// previous generation is still on disk and still counted against free space, so the
// preflight demands room for BOTH. That halves the gallery size a rebuild can survive
// relative to the size the upload gate allows — and every path that bumps the epoch (a
// guest deleting their own photo, a caption edit, a ban, "Neu erzeugen") retires the
// current keepsake IMMEDIATELY on commit. So above that threshold the download 404s, the
// rebuild is refused, and the only thing that could free the space is the prune that now
// only runs on success. Permanently stuck, unreachable from any handler.
//
// So: try to build while preserving the old generation. If that genuinely does not fit,
// the old generation is the one thing we can reclaim — sacrifice it and try once more. A
// keepsake that exists beats one we preserved but can never replace.
if ensure_export_space(pool, event_id, export_path).await.is_err() {
tracing::warn!(
"not enough room to rebuild alongside the previous keepsake; reclaiming it first"
);
prune_superseded_archives(pool, export_path, "Gallery", event_id, epoch).await;
// Two-phase, and the order is the whole point.
//
// Deferring the prune (so a failed rebuild can never leave the event with no archive at
// all) has a cost the first version of this did not follow through on: at rebuild time the
// previous generation is still on disk and still counted against free space, so the
// preflight demands room for BOTH. That halves the gallery size a rebuild can survive
// relative to the size the upload gate allows — and every path that bumps the epoch (a
// guest deleting their own photo, a caption edit, a ban, "Neu erzeugen") retires the
// current keepsake IMMEDIATELY on commit. So above that threshold the download 404s, the
// rebuild is refused, and the only thing that could free the space is the prune that now
// only runs on success. Permanently stuck, unreachable from any handler.
//
// So: try to build while preserving the old generation. If that genuinely does not fit,
// the old generation is the one thing we can reclaim — sacrifice it and try once more. A
// keepsake that exists beats one we preserved but can never replace.
if ensure_export_space(pool, event_id, export_path).await.is_err() {
tracing::warn!(
"not enough room to rebuild alongside the previous keepsake; reclaiming it first"
);
prune_superseded_archives(pool, export_path, "Memories", event_id, epoch).await;
ensure_export_space(pool, event_id, export_path).await?;
}
}
ensure_export_space_reclaiming(pool, event_id, export_path, "Gallery", epoch).await?;
// On error, mark THIS generation failed — a no-op if we've since been superseded (the
// caller in `spawn_export_jobs` does it, epoch-guarded). Temp artifacts are cleaned up
@@ -755,8 +752,8 @@ async fn run_html_export(
}
// See run_zip_export: refuse at the door rather than ENOSPC mid-write, and reclaim the
// superseded generation only AFTER this one lands.
ensure_export_space(pool, event_id, export_path).await?;
// superseded generation only AFTER this one lands — unless it is the only way to land at all.
ensure_export_space_reclaiming(pool, event_id, export_path, "Memories", epoch).await?;
let res = run_html_export_inner(
epoch,