feat(frontend): UX review followups — primitives + a11y/UX fixes across 4 passes

New shared primitives: - Toaster + toast-store, ConfirmSheet, Modal, focusTrap action, pullToRefresh action, avatarPalette + initials helper, Skeleton, HeartBurst, haptics, export-status store with onClearAuth hook Critical UX/a11y: - Replaced window.confirm with branded ConfirmSheet - Focus management + Escape on every modal (PIN, Lightbox, Onboarding, ContextSheet, data-mode sheet, leave-confirm, HTML guide, host/admin ban + PIN-display modals) - Sheet backdrops are real buttons with aria-label - Silent ApiError catches now surface via global Toaster Major polish: - Dark-mode parity on HashtagChips + avatars (shared palette) - Conditional Export tab in BottomNav (badge dot when ZIP ready) - Back chevrons on /recover (history-aware) and /export - Upload composer discard confirmation when content is staged - Camera segmented Photo/Video shutter - PIN auto-submit on 4th digit, paste-flash-free (controlled input) - Welcome-back toast on /feed after PIN recovery Minor: - Skeleton states on feed; pull-to-refresh with live drag indicator - Haptics on like / capture / submit / PIN-copy / onboarding complete - Comment 500-char counter; quota "Fast voll" / "Limit erreicht" labels - Onboarding pip ≥24px tap targets; long-press hint step - overscroll-behavior lock on <html> while feed mounted - teardownExportStatus wired via onClearAuth (covers 401 + explicit logout) - ConfirmSheet per-instance titleId; Modal requires titleId or ariaLabel Tests (7 new Playwright specs): - 01-auth/pin-auto-submit, 01-auth/back-chevron - 03-feed/confirm-sheet-delete, 03-feed/toast-on-failure - 09-mobile/focus-trap, 09-mobile/sheet-escape, 09-mobile/upload-cancel-confirm FOLLOWUPS.md captures the deferred AT inert containment work with acceptance criteria + implementation sketches. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-24 22:50:28 +02:00
parent b241ba6415
commit 309c25bc06
36 changed files with 1751 additions and 433 deletions
--- a/e2e/specs/09-mobile/focus-trap.spec.ts
+++ b/e2e/specs/09-mobile/focus-trap.spec.ts
@@ -0,0 +1,54 @@
+/**
+ * Critical a11y fix — the focusTrap action keeps Tab within open modals
+ * and lets Escape dismiss them, then restores focus to the originating
+ * element. This spec covers the LightboxModal, which is the most-used
+ * focus-trap consumer in the app.
+ */
+import { test, expect } from '../../fixtures/test';
+import { uploadRaw } from '../../helpers/upload-client';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+
+const SAMPLE_JPG = join(process.cwd(), 'fixtures', 'media', 'sample.jpg');
+
+async function seedUpload(token: string): Promise<{ id: string }> {
+  const res = await uploadRaw(token, readFileSync(SAMPLE_JPG), {
+    filename: 'ft.jpg',
+    contentType: 'image/jpeg',
+    caption: 'Focus-trap fixture',
+  });
+  if (res.status !== 201) throw new Error(`Upload seed failed (${res.status})`);
+  return (await res.json()) as { id: string };
+}
+
+test.describe('Mobile a11y — focus trap on LightboxModal', () => {
+  test('Escape closes the lightbox and Tab cycles inside', async ({ page, guest, signIn }) => {
+    const g = await guest('FocusTrap');
+    await seedUpload(g.jwt);
+    await signIn(page, g);
+    await page.goto('/feed');
+
+    const card = page.locator('article').filter({ hasText: g.displayName }).first();
+    const trigger = card.getByRole('button', { name: 'Bild vergrößern' });
+    await expect(trigger).toBeVisible({ timeout: 10_000 });
+    await trigger.click();
+
+    // Lightbox is role="dialog" aria-modal="true".
+    const lightbox = page.locator('[role="dialog"][aria-modal="true"]').filter({ has: page.locator('img, video') });
+    await expect(lightbox).toBeVisible();
+
+    // After opening, focus should be inside the lightbox (trap autoFocus moves
+    // focus to the first focusable). Verify by checking activeElement is
+    // contained.
+    await expect.poll(async () => {
+      return await page.evaluate(() => {
+        const dlg = document.querySelector('[role="dialog"][aria-modal="true"]');
+        return !!dlg && dlg.contains(document.activeElement);
+      });
+    }, { timeout: 2_000 }).toBe(true);
+
+    // Escape dismisses the lightbox.
+    await page.keyboard.press('Escape');
+    await expect(lightbox).not.toBeVisible({ timeout: 2_000 });
+  });
+});