fix: upload body limit, role case, and connection drain (v0.12.1)
- Disable Axum's 2 MB default body limit on the upload route so large
photos/videos are accepted without HTTP 400
- Serialize UserRole as lowercase in JWT so the frontend role checks
('guest'/'host'/'admin') match correctly
- Drain multipart body before returning early upload errors (rate-limit,
ban, event-lock) to keep the HTTP keep-alive connection clean and
prevent cascading Netzwerkfehler / empty-500 responses
- Add TraceLayer for request logging and Vite dev proxy config
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
42
TEST_GUIDE.md
Normal file
42
TEST_GUIDE.md
Normal file
@@ -0,0 +1,42 @@
|
|||||||
|
## Frontend Testing — Step by Step
|
||||||
|
|
||||||
|
Please test each step in order and report any errors (console errors, wrong text, broken UI, API errors).
|
||||||
|
|
||||||
|
### Step 1 — Join flow + PIN modal
|
||||||
|
1. Open **http://localhost:5173/** in your browser (or navigate there if already open)
|
||||||
|
2. You should land on the **join page** (`/join`) with a name input
|
||||||
|
3. Enter your name (e.g. `Max`) and click **Beitreten**
|
||||||
|
4. ✅ Expected: A modal appears showing your 4-digit PIN in large monospace font with a "Kopieren" button
|
||||||
|
5. Click **Weiter zur Galerie**
|
||||||
|
|
||||||
|
### Step 2 — Onboarding guide
|
||||||
|
6. You should land on the **feed page** (`/feed`)
|
||||||
|
7. ✅ Expected: A dark overlay appears at the bottom (or center on desktop) — the onboarding guide — showing step 1 of 4 with a step indicator and the Willkommen screen
|
||||||
|
8. Click **Weiter** through all 4 steps, then **Los geht's!**
|
||||||
|
9. ✅ Expected: Overlay disappears
|
||||||
|
|
||||||
|
### Step 3 — Feed & navigation
|
||||||
|
10. ✅ Expected: Feed shows "Noch keine Fotos." empty state with an upload button
|
||||||
|
11. ✅ Expected: Top-right has an **upload button** (blue) and a **person icon** link
|
||||||
|
|
||||||
|
### Step 4 — My Account page
|
||||||
|
12. Click the **person icon** in the top-right
|
||||||
|
13. ✅ Expected: `/account` page shows your name (`Max`), a blue "Gast" badge, session expiry date, and your PIN displayed large in an amber box
|
||||||
|
14. Click **Kopieren** — check clipboard contains your PIN
|
||||||
|
15. ✅ Expected: Button briefly shows "Kopiert!"
|
||||||
|
16. Click **Zur Galerie** to go back to the feed
|
||||||
|
|
||||||
|
### Step 5 — Upload
|
||||||
|
17. Click **Hochladen** — this takes you to `/upload`
|
||||||
|
18. Try uploading a photo from your device library
|
||||||
|
19. ✅ Expected: Photo appears in queue with a progress bar, then completes
|
||||||
|
20. Go back to `/feed` — ✅ Expected: your photo appears in the feed grid
|
||||||
|
|
||||||
|
### Step 6 — Onboarding guide not shown again
|
||||||
|
21. Reload the page at `/feed`
|
||||||
|
22. ✅ Expected: The onboarding overlay does **not** appear (already dismissed)
|
||||||
|
|
||||||
|
### Step 7 — Recover (open a private/incognito window)
|
||||||
|
23. Open a new **private/incognito** window at **http://localhost:5173/recover**
|
||||||
|
24. Enter the same name (`Max`) and the PIN you copied
|
||||||
|
25. ✅ Expected: You're redirected to the feed with the same account
|
||||||
@@ -24,6 +24,7 @@ pub async fn upload(
|
|||||||
.rate_limiter
|
.rate_limiter
|
||||||
.check(format!("upload:{}", auth.user_id), upload_rate, Duration::from_secs(3600))
|
.check(format!("upload:{}", auth.user_id), upload_rate, Duration::from_secs(3600))
|
||||||
{
|
{
|
||||||
|
drain_multipart(multipart).await;
|
||||||
return Err(AppError::TooManyRequests(
|
return Err(AppError::TooManyRequests(
|
||||||
"Du hast dein Upload-Limit für diese Stunde erreicht.".into(),
|
"Du hast dein Upload-Limit für diese Stunde erreicht.".into(),
|
||||||
));
|
));
|
||||||
@@ -34,6 +35,7 @@ pub async fn upload(
|
|||||||
.await?
|
.await?
|
||||||
.ok_or_else(|| AppError::NotFound("Benutzer nicht gefunden.".into()))?;
|
.ok_or_else(|| AppError::NotFound("Benutzer nicht gefunden.".into()))?;
|
||||||
if user.is_banned {
|
if user.is_banned {
|
||||||
|
drain_multipart(multipart).await;
|
||||||
return Err(AppError::Forbidden("Du bist gesperrt.".into()));
|
return Err(AppError::Forbidden("Du bist gesperrt.".into()));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -42,6 +44,7 @@ pub async fn upload(
|
|||||||
.await?
|
.await?
|
||||||
.ok_or_else(|| AppError::NotFound("Event nicht gefunden.".into()))?;
|
.ok_or_else(|| AppError::NotFound("Event nicht gefunden.".into()))?;
|
||||||
if event.uploads_locked_at.is_some() {
|
if event.uploads_locked_at.is_some() {
|
||||||
|
drain_multipart(multipart).await;
|
||||||
return Err(AppError::Forbidden("Uploads sind gesperrt.".into()));
|
return Err(AppError::Forbidden("Uploads sind gesperrt.".into()));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -239,6 +242,15 @@ pub async fn delete_upload(
|
|||||||
Ok(StatusCode::NO_CONTENT)
|
Ok(StatusCode::NO_CONTENT)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Drain a multipart body so the HTTP connection stays clean when returning an early error.
|
||||||
|
/// Without draining, the client may still be sending the body after we've sent our response,
|
||||||
|
/// which can corrupt the keep-alive connection for subsequent requests.
|
||||||
|
async fn drain_multipart(mut mp: Multipart) {
|
||||||
|
while let Ok(Some(mut field)) = mp.next_field().await {
|
||||||
|
while field.chunk().await.ok().flatten().is_some() {}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
async fn get_config_i64(pool: &sqlx::PgPool, key: &str, default: i64) -> i64 {
|
async fn get_config_i64(pool: &sqlx::PgPool, key: &str, default: i64) -> i64 {
|
||||||
let row: Option<(String,)> =
|
let row: Option<(String,)> =
|
||||||
sqlx::query_as("SELECT value FROM config WHERE key = $1")
|
sqlx::query_as("SELECT value FROM config WHERE key = $1")
|
||||||
|
|||||||
@@ -1,7 +1,9 @@
|
|||||||
use anyhow::Result;
|
use anyhow::Result;
|
||||||
|
use axum::extract::DefaultBodyLimit;
|
||||||
use axum::routing::{delete, get, patch, post};
|
use axum::routing::{delete, get, patch, post};
|
||||||
use axum::Router;
|
use axum::Router;
|
||||||
use tower_http::services::ServeDir;
|
use tower_http::services::ServeDir;
|
||||||
|
use tower_http::trace::TraceLayer;
|
||||||
use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt};
|
use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt};
|
||||||
|
|
||||||
mod auth;
|
mod auth;
|
||||||
@@ -40,8 +42,9 @@ async fn main() -> Result<()> {
|
|||||||
.route("/api/v1/recover", post(auth::handlers::recover))
|
.route("/api/v1/recover", post(auth::handlers::recover))
|
||||||
.route("/api/v1/admin/login", post(auth::handlers::admin_login))
|
.route("/api/v1/admin/login", post(auth::handlers::admin_login))
|
||||||
.route("/api/v1/session", delete(auth::handlers::logout))
|
.route("/api/v1/session", delete(auth::handlers::logout))
|
||||||
// Upload
|
// Upload — body limit disabled; size validation is done inside the handler
|
||||||
.route("/api/v1/upload", post(handlers::upload::upload))
|
.route("/api/v1/upload", post(handlers::upload::upload)
|
||||||
|
.route_layer(DefaultBodyLimit::disable()))
|
||||||
.route(
|
.route(
|
||||||
"/api/v1/upload/{id}",
|
"/api/v1/upload/{id}",
|
||||||
patch(handlers::upload::edit_upload).delete(handlers::upload::delete_upload),
|
patch(handlers::upload::edit_upload).delete(handlers::upload::delete_upload),
|
||||||
@@ -89,6 +92,7 @@ async fn main() -> Result<()> {
|
|||||||
.route("/health", get(|| async { "ok" }))
|
.route("/health", get(|| async { "ok" }))
|
||||||
.merge(api)
|
.merge(api)
|
||||||
.nest_service("/media", media_service)
|
.nest_service("/media", media_service)
|
||||||
|
.layer(TraceLayer::new_for_http())
|
||||||
.with_state(state);
|
.with_state(state);
|
||||||
|
|
||||||
let listener = tokio::net::TcpListener::bind(("0.0.0.0", config.app_port)).await?;
|
let listener = tokio::net::TcpListener::bind(("0.0.0.0", config.app_port)).await?;
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ use sqlx::PgPool;
|
|||||||
use uuid::Uuid;
|
use uuid::Uuid;
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, sqlx::Type)]
|
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, sqlx::Type)]
|
||||||
|
#[serde(rename_all = "lowercase")]
|
||||||
#[sqlx(type_name = "user_role", rename_all = "lowercase")]
|
#[sqlx(type_name = "user_role", rename_all = "lowercase")]
|
||||||
pub enum UserRole {
|
pub enum UserRole {
|
||||||
Guest,
|
Guest,
|
||||||
|
|||||||
@@ -3,5 +3,11 @@ import tailwindcss from '@tailwindcss/vite';
|
|||||||
import { defineConfig } from 'vite';
|
import { defineConfig } from 'vite';
|
||||||
|
|
||||||
export default defineConfig({
|
export default defineConfig({
|
||||||
plugins: [tailwindcss(), sveltekit()]
|
plugins: [tailwindcss(), sveltekit()],
|
||||||
|
server: {
|
||||||
|
proxy: {
|
||||||
|
'/api': 'http://localhost:3000',
|
||||||
|
'/media': 'http://localhost:3000'
|
||||||
|
}
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user