feat(db): idempotency keys, ban-aware counts, and a host audit trail
Four migrations, all additive against a database that already has 001-025 applied. 026 narrows the client-upload idempotency index with `AND deleted_at IS NULL`. The old index made a soft-deleted row keep its key forever, so a guest who deleted a photo and re-sent the same one had the retry silently swallowed. The new indexed set is a strict subset of the old, so it cannot fail on existing rows. 027 adds `client_join_id`, which lets a join retry after a lost response resume the same account instead of 409ing on a name the caller itself owns. Every existing row gets NULL and the partial index excludes NULLs, so it indexes nothing at creation. 028 brings the feed view's like/comment counts in line with what the feed actually renders: a banned guest's rows were still counted, so a card showed "3 comments" above two. `comment.rs` gets the matching `NOT u.is_banned` on the live read path — the export and hashtag queries already filtered it, so the two views of one moderation action disagreed. 029 records host moderation actions, which were previously invisible after the fact. Verified by applying 001-029 to a real Postgres against seeded data, including a soft-deleted row holding a key and a banned user's like and comment. 026's down-migration legitimately fails where a deleted and a live row share a key — that is inherent to the direction, documented in the file, and sqlx never runs downs at boot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -2,7 +2,11 @@ use anyhow::{Context, Result};
|
||||
use sqlx::PgPool;
|
||||
use sqlx::postgres::PgPoolOptions;
|
||||
|
||||
const DEFAULT_MAX_CONNECTIONS: u32 = 10;
|
||||
/// Keep in step with `.env.example` and the `db` sizing comment in `docker-compose.yml`.
|
||||
/// These three drifted apart once (code 10 / `.env.example` 15 / runbook 30) and the runbook
|
||||
/// presented its number as authoritative, so the contradiction was invisible at deploy time.
|
||||
/// 15 is sized to 2 vCPU and the 1G `db` memory limit — raise it only alongside both.
|
||||
const DEFAULT_MAX_CONNECTIONS: u32 = 15;
|
||||
|
||||
/// SQLSTATE for `invalid_password`.
|
||||
const PG_INVALID_PASSWORD: &str = "28P01";
|
||||
@@ -47,10 +51,23 @@ fn explain_auth_failure(err: &sqlx::Error) {
|
||||
}
|
||||
|
||||
pub async fn create_pool(database_url: &str) -> Result<PgPool> {
|
||||
let max_connections = std::env::var("DATABASE_MAX_CONNECTIONS")
|
||||
.ok()
|
||||
.and_then(|s| s.parse::<u32>().ok())
|
||||
.unwrap_or(DEFAULT_MAX_CONNECTIONS);
|
||||
// A malformed value must not silently become the default: an operator who typed
|
||||
// `DATABASE_MAX_CONNECTIONS=3O` (letter O) would otherwise get 15 with no indication,
|
||||
// and would keep tuning a knob that never took effect.
|
||||
let max_connections = match std::env::var("DATABASE_MAX_CONNECTIONS") {
|
||||
Err(_) => DEFAULT_MAX_CONNECTIONS,
|
||||
Ok(raw) => match raw.trim().parse::<u32>() {
|
||||
Ok(0) => {
|
||||
anyhow::bail!("DATABASE_MAX_CONNECTIONS must be at least 1 (got 0)");
|
||||
}
|
||||
Ok(n) => n,
|
||||
Err(e) => {
|
||||
anyhow::bail!(
|
||||
"DATABASE_MAX_CONNECTIONS must be a positive integer (got {raw:?}): {e}"
|
||||
);
|
||||
}
|
||||
},
|
||||
};
|
||||
|
||||
let pool = match PgPoolOptions::new()
|
||||
.max_connections(max_connections)
|
||||
|
||||
Reference in New Issue
Block a user