fix(export-viewer): make the self-contained guard, and its spec, actually load-bearing
The font-inlining guard only caught a RENAME. It asked "did /fonts/<listed family>.woff2 disappear?", so an ADDITION walked straight past it — and an addition is the likelier accident: someone doing ordinary app work adds a display font or a decorative background to the shared theme, has no reason to open a viewer build config, and ships a keepsake that reaches for /fonts/Playfair.woff2 on the guest's own disk. font-display: swap hides it, so the artifact looks right to everyone who happens to have the file locally and renders in Times New Roman for the couple. It now asserts the invariant instead of a list: nothing in the emitted keepsake may reference an external URL. Self-maintaining, and it covers fonts, images and stylesheets alike. In writeBundle rather than generateBundle — generateBundle runs more than once and the stylesheet is not inlined on the earlier pass, so asserting there fails a perfectly good build. viewer-no-broken-tiles gets a positive anchor. Its "nothing is broken" check filters img elements, so a viewer that rendered NOTHING yields [] and passes: the one spec whose whole subject is that the images resolve was the one that would have stayed green through a total viewer regression. Everything else it checks comes from the backend and the classic head script, neither of which needs the viewer bundle to have run. And a CI job, because neither of the above fires on its own: no workflow, Dockerfile or script built this viewer, so the guard could sit disarmed indefinitely, and the committed artifact — compiled into the binary with include_dir! — could drift from its source with nothing to say so.
This commit is contained in:
@@ -98,8 +98,18 @@ test.describe('Export — the keepsake has no broken tiles', () => {
|
||||
).toBe(true);
|
||||
}
|
||||
|
||||
// THE assertion: nothing rendered broken. Give the images a moment to settle first.
|
||||
await page.waitForLoadState('networkidle');
|
||||
|
||||
// POSITIVE anchor FIRST, and it is load-bearing. The "nothing is broken" assertion below
|
||||
// filters `img` elements, so a viewer that rendered NOTHING AT ALL yields `[]` and passes —
|
||||
// this file, whose whole subject is that the images resolve, was the one spec that would
|
||||
// have stayed green through a total viewer regression. Everything else it checks
|
||||
// (`__EXPORT_DATA__`, the archive entries) comes from the backend and the classic head
|
||||
// script, neither of which needs the viewer bundle to have run at all.
|
||||
const rendered = await page.locator('img').count();
|
||||
expect(rendered, 'the keepsake viewer rendered no images at all').toBeGreaterThan(0);
|
||||
|
||||
// THE assertion: nothing rendered broken.
|
||||
const broken = await page.evaluate(() =>
|
||||
Array.from(document.querySelectorAll('img'))
|
||||
.filter((i) => i.complete && i.naturalWidth === 0)
|
||||
|
||||
Reference in New Issue
Block a user