fabi/EventSnap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(feed,host): two mis-tap bugs where a live re-render destroys the click target

Browse Source 
Both are the same class as the autocomplete bug fixed in bf68bc0: a handler must never
destroy the DOM node that is being clicked.

feed grid tiles: VirtualFeed keys tiles by upload.id but slices the uploads array
POSITIONALLY (`uploads.slice(i*COLS, …)`). A `new-upload` SSE prepends to the array, so
every tile shifts one slot and each row's keyed {#each} sees a new set of ids — Svelte
destroys and recreates the tile nodes. At a party, where photos stream in continuously, a
guest mid-tap can have the node torn out (tap swallowed) or, worse, like/open a DIFFERENT
photo that slid under their finger. Grid now buffers live arrivals behind the existing
"neue Beiträge" pill; list view is keyed at the top level and stays live.

host rebuild button: it lived inside an SSE-driven {#if exportGenerating}{:else if
exportReady}{:else} block, and rebuildExport() makes the backend broadcast export-progress
immediately — so pressing it flipped the branch and unmounted the button mid-click, on the
one screen whose purpose is recovering a broken keepsake. One button now stays mounted
across all three states; only its label and disabled vary.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
fabi
2026-07-15 07:25:19 +02:00
parent af997a84dd
commit c229b560d8
3 changed files with 61 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/src/routes/feed/+page.svelte
View File

@@ -214,6 +214,21 @@
onSseEvent('new-upload', (data) => {
try {
const upload: FeedUpload = JSON.parse(data);
// GRID view must NOT prepend live. Its rows are POSITIONAL windows
// (`uploads.slice(i * COLS, …)` in VirtualFeed), so inserting at the head shifts
// every tile by one slot: each row's keyed `{#each}` then sees a different set of
// ids and Svelte DESTROYS AND RECREATES the tile nodes. Two consequences at a
// party, where photos arrive continuously — a tap in flight is swallowed when its
// node is torn out, and the photo under the user's finger silently becomes a
// DIFFERENT photo, so they like or open one they never chose.
//
// The "neue Beiträge" pill already exists for exactly this: buffer, and let the
// user pull the new photos in when they are not mid-tap. List view is keyed by id
// at the top level and anchored, so its nodes survive a prepend — it stays live.
if (viewMode === 'grid') {
feedStale = true;
return;
}
uploads = [upload, ...uploads];
} catch { /* ignore */ }
}),