fabi/EventSnap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(e2e): fix load-induced mobile flakes (gesture timing + hydration)

Browse Source 
Three distinct load-induced flakes in the mobile suite, all root-caused from real traces:

1. gestures-longpress "quick tap": longPress() drove page.mouse.down + Node-side
   waitForTimeout(200) + page.mouse.up — three CDP round-trips. Under load the browser saw
   the pointerup >500ms after pointerdown, firing the app's real long-press so the
   ContextSheet opened on a quick tap. New quickTap() helper dispatches pointerdown/up
   entirely in-browser on one clock, so the earlier-due pointerup always cancels the 500ms
   timer first — immune to CDP latency.

2/3. upload-cancel-confirm and sheet-escape interacted with server-rendered controls before
   Svelte hydrated them (caption fill lost -> cancel() navigates to /feed; custom role=radio
   / leave-button click no-ops). Wait for a post-hydration readiness signal (composer
   auto-focus / real profile name) before the first interaction — the same barrier the
   passing feed-based specs already have. (These are now belt-and-suspenders given ssr=false,
   but keep the specs robust regardless of render mode.)

Verified: mobile 22/22, and 0/50 full-mobile runs under load (was ~3/95 pre-fix).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
fabi
2026-07-16 21:15:26 +02:00
parent 15d338eeb8
commit e2b7e54af9
4 changed files with 69 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/specs/09-mobile/gestures-longpress.spec.ts
View File

@@ -12,7 +12,7 @@
*/
import { test, expect } from '../../fixtures/test';
import { uploadRaw } from '../../helpers/upload-client';
import { longPress } from '../../helpers/touch';
import { longPress, quickTap } from '../../helpers/touch';
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
@@ -67,8 +67,12 @@ test.describe('Mobile — long-press gesture', () => {
const card = page.locator('article').filter({ hasText: g.displayName }).first();
await expect(card).toBeVisible({ timeout: 10_000 });
// Simulate a short press (200 ms — well under the 500 ms threshold).
await longPress(page, card, 200);
// A short press (200 ms — well under the 500 ms threshold), dispatched in-browser so
// its duration is measured on the browser's own clock. `longPress` (page.mouse +
// Node-side waitForTimeout) can't guarantee that under load: the pointerup can reach
// the browser >500 ms after the pointerdown even when Node waited only 200 ms, firing
// the long-press and opening the sheet on a "quick tap". See `quickTap`.
await quickTap(card, 200);
// Within 1 s, the ContextSheet must not be open (aria-modal is set only when
// open). A quick tap opens the lightbox instead, which is a different element.