fabi/EventSnap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(e2e): fix load-induced mobile flakes (gesture timing + hydration)

Browse Source 
Three distinct load-induced flakes in the mobile suite, all root-caused from real traces:

1. gestures-longpress "quick tap": longPress() drove page.mouse.down + Node-side
   waitForTimeout(200) + page.mouse.up — three CDP round-trips. Under load the browser saw
   the pointerup >500ms after pointerdown, firing the app's real long-press so the
   ContextSheet opened on a quick tap. New quickTap() helper dispatches pointerdown/up
   entirely in-browser on one clock, so the earlier-due pointerup always cancels the 500ms
   timer first — immune to CDP latency.

2/3. upload-cancel-confirm and sheet-escape interacted with server-rendered controls before
   Svelte hydrated them (caption fill lost -> cancel() navigates to /feed; custom role=radio
   / leave-button click no-ops). Wait for a post-hydration readiness signal (composer
   auto-focus / real profile name) before the first interaction — the same barrier the
   passing feed-based specs already have. (These are now belt-and-suspenders given ssr=false,
   but keep the specs robust regardless of render mode.)

Verified: mobile 22/22, and 0/50 full-mobile runs under load (was ~3/95 pre-fix).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
fabi
2026-07-16 21:15:26 +02:00
parent 15d338eeb8
commit e2b7e54af9
4 changed files with 69 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
e2e/specs/09-mobile/upload-cancel-confirm.spec.ts
View File

@@ -19,7 +19,13 @@ test.describe('Mobile — upload composer cancel confirmation', () => {
await page.goto('/upload');
const caption = page.getByTestId('upload-caption');
await expect(caption).toBeVisible();
// The composer is server-rendered, so the textarea is visible (and fillable) BEFORE Svelte
// hydrates its `bind:value`. A fill that lands pre-hydration sets the DOM value but never
// reaches the reactive `caption` state — so `cancel()` sees an empty caption and navigates
// straight to /feed instead of opening the discard sheet (a reproduced ~1% flake). The
// composer auto-focuses the textarea in onMount (which only runs post-hydration), so waiting
// for focus is a reliable "the bindings are live now" barrier before we type.
await expect(caption).toBeFocused();
await caption.fill('a meaningful caption that I do not want to lose');
// Tap the close (X) button in the composer header.
@@ -44,6 +50,9 @@ test.describe('Mobile — upload composer cancel confirmation', () => {
await signIn(page, g);
await page.goto('/upload');
// Wait for the composer to hydrate (onMount auto-focuses the textarea) before tapping
// Abbrechen, so the click reaches a hydrated button. See the test above.
await expect(page.getByTestId('upload-caption')).toBeFocused();
await page.getByRole('button', { name: 'Abbrechen' }).click();
await page.waitForURL('**/feed', { timeout: 3_000 });
});