chore(frontend): add ESLint + Prettier; fix real findings; format the tree
The frontend had no JS/TS linter — only svelte-check. Add flat-config ESLint (typescript-eslint
+ eslint-plugin-svelte) and Prettier (tabs/single-quote, matching the existing style).
Rules encode "catch bugs, not enforce taste":
- svelte/require-each-key KEPT — it is the exact bug class as the feed mis-tap fix. Fixed every
flagged block: keyed activeFilters, filteredUsers, stagedFiles (by previewUrl), captionTags,
admin tabs/jobs/users, the export-viewer suggestions/filters/comments, and the static skeleton
loops.
- svelte/prefer-svelte-reactivity KEPT — inline-disabled only the verified-safe sites (a local
freq Map in a $derived.by, throwaway URLSearchParams query builders), with a reason each.
- svelte/no-navigation-without-resolve OFF — wants resolve() around every goto()/href; taste, not
a bug, and pure churn.
- svelte/no-unused-svelte-ignore OFF — those comments are consumed by svelte-check, which ESLint
can't see, so it wrongly calls them unused; removing them would reintroduce a11y warnings.
- no-explicit-any OFF for *.test.ts only (partial fixtures legitimately use any).
Real code fixes beyond keys: removed a dead jobLabel(), an unused ViewerComment import and unused
catch binding, an unused scroll-lock arg, and replaced an empty interface with a type alias.
Then `prettier --write` (54 files). Formatting only. Verified: eslint clean, svelte-check 0 errors,
vitest 46 passed, vite build succeeds.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -20,14 +20,20 @@ export function toast(message: string, tone: ToastTone = 'info', ttl = 4000): nu
|
||||
const entry: Toast = { id, message, tone, ttl };
|
||||
toasts.update((list) => [...list, entry]);
|
||||
if (ttl > 0 && typeof window !== 'undefined') {
|
||||
timers.set(id, setTimeout(() => dismissToast(id), ttl));
|
||||
timers.set(
|
||||
id,
|
||||
setTimeout(() => dismissToast(id), ttl)
|
||||
);
|
||||
}
|
||||
return id;
|
||||
}
|
||||
|
||||
export function dismissToast(id: number): void {
|
||||
const t = timers.get(id);
|
||||
if (t) { clearTimeout(t); timers.delete(id); }
|
||||
if (t) {
|
||||
clearTimeout(t);
|
||||
timers.delete(id);
|
||||
}
|
||||
toasts.update((list) => list.filter((x) => x.id !== id));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user