bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.7 KiB
TypeScript
40 lines
1.7 KiB
TypeScript
/**
|
|
* Phase 2 adversarial — SSE ticket capability abuse.
|
|
*
|
|
* The stream endpoint authenticates via short-lived, single-use tickets minted at
|
|
* POST /api/v1/stream/ticket (never the raw JWT in the URL). These tests pin the
|
|
* security properties of that flow: minting requires auth, and a ticket is consumed
|
|
* on first use so it cannot be replayed.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { mintSseTicket, openStream } from '../../helpers/sse';
|
|
import { BASE } from '../../helpers/env';
|
|
|
|
test.describe('Adversarial — SSE ticket abuse', () => {
|
|
test('minting a ticket requires authentication', async () => {
|
|
const res = await fetch(`${BASE}/api/v1/stream/ticket`, { method: 'POST' });
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
test('a ticket is single-use: replay after first open is rejected', async ({ guest }) => {
|
|
const g = await guest('SseReplay');
|
|
const ticket = await mintSseTicket(g.jwt);
|
|
|
|
// First open consumes the ticket.
|
|
expect(await openStream(ticket)).toBe(200);
|
|
|
|
// Replaying the exact same ticket must fail — it was consumed, so `consume` returns
|
|
// None → 401. A 200 here would mean tickets are reusable (capability replay).
|
|
expect(await openStream(ticket)).toBe(401);
|
|
});
|
|
|
|
test('an unminted / garbage ticket is rejected', async () => {
|
|
// 24-byte-shaped hex string that was never issued.
|
|
const bogus = 'deadbeef'.repeat(6);
|
|
expect(await openStream(bogus)).toBe(401);
|
|
});
|
|
// Note: the replay test's first open (→ 200) already proves a freshly-minted ticket
|
|
// works, so there is no separate "fresh ticket" sanity test — a second successful open
|
|
// would just add ~30s (SSE headers flush on the keep-alive tick through Caddy).
|
|
});
|