bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
58 lines
2.3 KiB
TypeScript
58 lines
2.3 KiB
TypeScript
/**
|
|
* The toast store + <Toaster> primitive surfaces ApiError messages on
|
|
* user-initiated actions that previously failed silently (catch { ignore }).
|
|
* This spec intercepts the like POST and forces a 429 to assert the German
|
|
* error message reaches the user via the global toast region.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { uploadRaw } from '../../helpers/upload-client';
|
|
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
|
|
const SAMPLE_JPG = join(process.cwd(), 'fixtures', 'media', 'sample.jpg');
|
|
|
|
async function seedUpload(token: string): Promise<{ id: string }> {
|
|
const res = await uploadRaw(token, readFileSync(SAMPLE_JPG), {
|
|
filename: 'tf.jpg',
|
|
contentType: 'image/jpeg',
|
|
caption: 'Toast fixture',
|
|
});
|
|
if (res.status !== 201) throw new Error(`Upload seed failed (${res.status})`);
|
|
return (await res.json()) as { id: string };
|
|
}
|
|
|
|
test.describe('Feed — error toast on user action failures', () => {
|
|
test('like POST 429 surfaces a German error toast', async ({ page, guest, signIn }) => {
|
|
const author = await guest('ToastAuthor');
|
|
const liker = await guest('ToastLiker');
|
|
await seedUpload(author.jwt);
|
|
await signIn(page, liker);
|
|
|
|
// Intercept the like endpoint with a forced rate-limit response.
|
|
await page.route('**/api/v1/upload/*/like', (route) =>
|
|
route.fulfill({
|
|
status: 429,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
error: 'rate_limited',
|
|
message: 'Zu viele Anfragen — bitte kurz warten.',
|
|
}),
|
|
})
|
|
);
|
|
|
|
await page.goto('/feed');
|
|
const card = page.locator('article').filter({ hasText: author.displayName }).first();
|
|
await expect(card).toBeVisible({ timeout: 10_000 });
|
|
|
|
// Click the like button by its stable aria-label (the liker hasn't liked yet).
|
|
// Avoids matching a different digit-bearing button (e.g. the comment count).
|
|
await card.getByRole('button', { name: 'Gefällt mir' }).click();
|
|
|
|
// The toast is rendered inside the global Toaster region with aria-live="polite".
|
|
const toast = page.getByTestId('toast').first();
|
|
await expect(toast).toBeVisible({ timeout: 3_000 });
|
|
await expect(toast).toContainText(/Zu viele Anfragen/i);
|
|
await expect(toast).toHaveAttribute('data-toast-tone', 'error');
|
|
});
|
|
});
|