bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §11 — admin reads/writes config via the API. Asserts
|
|
* the validation rules baked into [backend/src/handlers/admin.rs:patch_config].
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
|
|
test.describe('Admin — config API', () => {
|
|
test('PATCH /admin/config persists numeric values', async ({ api, adminToken }) => {
|
|
await api.patchConfig(adminToken, { max_image_size_mb: '25' });
|
|
const cfg = await api.getConfig(adminToken);
|
|
expect(cfg.max_image_size_mb).toBe('25');
|
|
// Restore the default so other specs see the seeded value.
|
|
await api.patchConfig(adminToken, { max_image_size_mb: '20' });
|
|
});
|
|
|
|
test('non-numeric value for a numeric key is rejected', async ({ adminToken }) => {
|
|
const res = await fetch(
|
|
(process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101') + '/api/v1/admin/config',
|
|
{
|
|
method: 'PATCH',
|
|
headers: { Authorization: `Bearer ${adminToken}`, 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ max_image_size_mb: 'not-a-number' }),
|
|
}
|
|
);
|
|
expect(res.status).toBe(400);
|
|
});
|
|
|
|
test('unknown config key is rejected (whitelist enforced)', async ({ adminToken }) => {
|
|
const res = await fetch(
|
|
(process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101') + '/api/v1/admin/config',
|
|
{
|
|
method: 'PATCH',
|
|
headers: { Authorization: `Bearer ${adminToken}`, 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ totally_fake_key: '1' }),
|
|
}
|
|
);
|
|
expect(res.status).toBe(400);
|
|
});
|
|
|
|
test('toggle keys accept true/false but not arbitrary strings', async ({ api, adminToken }) => {
|
|
await api.patchConfig(adminToken, { upload_rate_enabled: 'true' });
|
|
let cfg = await api.getConfig(adminToken);
|
|
expect(cfg.upload_rate_enabled).toBe('true');
|
|
|
|
await api.patchConfig(adminToken, { upload_rate_enabled: 'false' });
|
|
cfg = await api.getConfig(adminToken);
|
|
expect(cfg.upload_rate_enabled).toBe('false');
|
|
|
|
const res = await fetch(
|
|
(process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101') + '/api/v1/admin/config',
|
|
{
|
|
method: 'PATCH',
|
|
headers: { Authorization: `Bearer ${adminToken}`, 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ upload_rate_enabled: 'maybe' }),
|
|
}
|
|
);
|
|
expect(res.status).toBe(400);
|
|
});
|
|
|
|
test('privacy_note round-trips verbatim, preserving whitespace + newlines', async ({
|
|
api,
|
|
adminToken,
|
|
}) => {
|
|
const note =
|
|
' Datenschutz\n • Wir verwenden keine Cookies.\n • Alles bleibt im Browser.\n\n— Dein Host';
|
|
await api.patchConfig(adminToken, { privacy_note: note });
|
|
const cfg = await api.getConfig(adminToken);
|
|
expect(cfg.privacy_note).toBe(note);
|
|
await api.patchConfig(adminToken, { privacy_note: '' });
|
|
});
|
|
});
|
|
|
|
test.describe('Admin — stats', () => {
|
|
test('GET /admin/stats returns matching counts after seeding users', async ({
|
|
api,
|
|
adminToken,
|
|
guest,
|
|
}) => {
|
|
await guest('Stat1');
|
|
await guest('Stat2');
|
|
await guest('Stat3');
|
|
const stats = await api.getStats(adminToken);
|
|
// Deterministic after the per-test truncate: 3 seeded guests + the Admin account
|
|
// (recreated by the adminToken fixture's login) = exactly 4. An exact assertion
|
|
// catches undercount/overcount regressions a `>= 3` lower bound would miss.
|
|
expect(stats.user_count).toBe(4);
|
|
expect(typeof stats.disk_total_bytes).toBe('number');
|
|
});
|
|
});
|