b1e2e66305
Follow-ups from the code review of the test-quality batches: - Consolidate duplicated helpers into e2e/helpers/: seed.ts (seedUpload, seedComment, listComments, findFeedRow) and sse.ts (mintSseTicket, openStream, trackStreamOpens). Refactor authorization-deep, xss-injection, like-comment, sse-ticket-abuse, ddos, sse-realtime, multi-tab, and SseListener to use them — the upload/comment/ticket-flow contracts now live in one place each instead of being re-inlined across 3–7 specs. - xss-injection display-name loop: it navigated to /feed (which renders uploader names, not the viewer's) so "nothing fired" passed vacuously — the payload was never rendered. Now navigate to /account (the actual sink) and add a render guard asserting the payload reached the DOM as escaped text before checking __xssFired. - sse-realtime reconnect: snapshot the stream-open count AFTER backgrounding, so the "new connection" assertion is attributable to the foreground event and can't be satisfied by a spurious native/error reconnect before the toggle. - recover-page: correct the comment (auto-submit is the onPinInput handler, not an $effect). 44 affected specs verified green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
81 lines
3.2 KiB
TypeScript
81 lines
3.2 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §7 — liking and commenting.
|
|
*
|
|
* Like behavior is asserted deterministically via the feed snapshot; the comment
|
|
* SSE round-trip is asserted by subscribing to the stream as a second user and
|
|
* waiting for the `new-comment` event to arrive.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { SseListener } from '../../helpers/sse-listener';
|
|
import { seedUpload, seedComment, findFeedRow } from '../../helpers/seed';
|
|
|
|
const BASE = process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101';
|
|
|
|
async function like(jwt: string, uploadId: string): Promise<number> {
|
|
const res = await fetch(`${BASE}/api/v1/upload/${uploadId}/like`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${jwt}` },
|
|
});
|
|
return res.status;
|
|
}
|
|
|
|
test.describe('Feed — like + comment', () => {
|
|
test('a like counts once per user and toggles off on repeat (no double-count)', async ({ api, guest }) => {
|
|
const author = await guest('Author');
|
|
const liker = await guest('Liker');
|
|
const uploadId = await seedUpload(author.jwt);
|
|
|
|
// Baseline: nobody has liked yet.
|
|
let row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// First like → counted exactly once.
|
|
expect(await like(liker.jwt, uploadId)).toBe(204);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(1);
|
|
expect(row.liked_by_me).toBe(true);
|
|
|
|
// Liking again is a toggle → back to zero (guards against a regression that
|
|
// double-counts a repeated like instead of removing it).
|
|
expect(await like(liker.jwt, uploadId)).toBe(204);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// A second distinct user's like is counted independently (per-user semantics).
|
|
expect(await like(liker.jwt, uploadId)).toBe(204); // liker likes again → 1
|
|
expect(await like(author.jwt, uploadId)).toBe(204); // author likes too → 2
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(2);
|
|
});
|
|
|
|
test('comment by user A → SSE new-comment delivered to user B', async ({ guest }) => {
|
|
// SSE frames can take a keep-alive tick to flush through the reverse proxy, so
|
|
// both the stream connect and the delivery may cost up to ~30s each.
|
|
test.setTimeout(120_000);
|
|
const a = await guest('CommenterA');
|
|
const b = await guest('ListenerB');
|
|
|
|
// B subscribes to the stream BEFORE A comments, so the broadcast is captured.
|
|
const sse = new SseListener();
|
|
await sse.start(b.jwt);
|
|
|
|
try {
|
|
const uploadId = await seedUpload(a.jwt, { caption: 'pic' });
|
|
await seedComment(a.jwt, uploadId, 'hello from A');
|
|
|
|
// B must receive the new-comment event for this upload. Generous timeout: SSE
|
|
// frames flush on the keep-alive tick through the compressing reverse proxy.
|
|
const evt = await sse.waitForEvent(
|
|
'new-comment',
|
|
(e) => e.data?.upload_id === uploadId,
|
|
45_000
|
|
);
|
|
expect(evt.data.comment_count).toBe(1);
|
|
} finally {
|
|
sse.stop();
|
|
}
|
|
});
|
|
});
|