bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
85 lines
3.0 KiB
TypeScript
85 lines
3.0 KiB
TypeScript
/**
|
|
* Phase 3 mobile — safe-area inset audit.
|
|
*
|
|
* The frontend uses `padding-bottom: env(safe-area-inset-bottom)` on every
|
|
* UI element that's anchored to the bottom of the viewport so content
|
|
* doesn't get covered by the iOS home indicator. The actual inset is 0
|
|
* inside Playwright's emulated devices (no notch), but we can assert that:
|
|
*
|
|
* 1. The `style` attribute references `env(safe-area-inset-bottom)`.
|
|
* 2. The element sits flush with the bottom of the viewport (no
|
|
* ghost gap of unexpected pixels).
|
|
*
|
|
* A future visual-regression pass on a real iPhone descriptor (Phase 3.5
|
|
* "real-device compat") would catch actual safe-area mis-sizing.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { inlineStyle } from '../../helpers/touch';
|
|
|
|
test.describe('Mobile — safe-area insets', () => {
|
|
test('bottom nav declares safe-area-inset-bottom in its inline style', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('SafeAreaNav');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const nav = page
|
|
.locator('nav')
|
|
.filter({ has: page.getByRole('link', { name: 'Galerie' }) })
|
|
.first();
|
|
await expect(nav).toBeVisible();
|
|
|
|
const style = await inlineStyle(nav);
|
|
expect(style).toContain('env(safe-area-inset-bottom)');
|
|
});
|
|
|
|
test('bottom nav stays flush with viewport bottom (no large gap)', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('SafeAreaFlush');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const nav = page
|
|
.locator('nav')
|
|
.filter({ has: page.getByRole('link', { name: 'Galerie' }) })
|
|
.first();
|
|
const viewport = page.viewportSize();
|
|
if (!viewport) throw new Error('No viewport size set on this project');
|
|
const box = await nav.boundingBox();
|
|
if (!box) throw new Error('nav not visible');
|
|
|
|
const distanceFromBottom = viewport.height - (box.y + box.height);
|
|
// With no notch the inset is 0; allow a tiny tolerance for sub-pixel rounding.
|
|
expect(distanceFromBottom).toBeLessThanOrEqual(2);
|
|
});
|
|
|
|
// (A vacuous `/join` probe that only asserted `Array.isArray(...)` — always true —
|
|
// was removed; the real sheet-level env() check is the structural test below.)
|
|
|
|
test('upload sheet and context sheet both honor env() (structural check)', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('SafeAreaSheets');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
// Tap the FAB to open the UploadSheet — its outer container should declare env().
|
|
await page.getByRole('button', { name: 'Hochladen' }).click();
|
|
// Even if the sheet is offscreen / hidden, the style attribute is present in the DOM.
|
|
const hits: number = await page.evaluate(() => {
|
|
return Array.from(document.querySelectorAll<HTMLElement>('[style]')).filter((el) =>
|
|
(el.getAttribute('style') ?? '').includes('env(safe-area-inset-bottom)')
|
|
).length;
|
|
});
|
|
expect(hits).toBeGreaterThanOrEqual(1);
|
|
});
|
|
});
|