bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
55 lines
2.3 KiB
TypeScript
55 lines
2.3 KiB
TypeScript
/**
|
|
* Regression guard — a locked/released event rejects uploads with the DISTINCT error code
|
|
* `uploads_locked` (not the generic `forbidden`), so the offline upload queue can tell this
|
|
* REVERSIBLE 403 apart from a permanent one (banned / quota). On `uploads_locked` the client
|
|
* KEEPS the queued blob and retries when the host reopens; a permanent 403 purges it. Before
|
|
* this, a photo staged during a lock was purged and lost the moment the host reopened.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { uploadRaw } from '../../helpers/upload-client';
|
|
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { BASE } from '../../helpers/env';
|
|
|
|
const SAMPLE = () => readFileSync(join(process.cwd(), 'fixtures', 'media', 'sample.jpg'));
|
|
|
|
test.describe('Upload — locked event uses a distinct, reversible 403 (audit fix)', () => {
|
|
test('closed event → 403 uploads_locked; reopen → upload succeeds', async ({ host, api }) => {
|
|
// Close the event: uploads are locked for everyone.
|
|
await api.closeEvent(host.jwt);
|
|
|
|
const locked = await uploadRaw(host.jwt, SAMPLE(), {
|
|
filename: 'during-lock.jpg',
|
|
contentType: 'image/jpeg',
|
|
});
|
|
expect(locked.status).toBe(403);
|
|
const lockedBody = await locked.json();
|
|
// The distinct code is what tells the client to KEEP the blob (reversible), not purge it.
|
|
expect(lockedBody.error).toBe('uploads_locked');
|
|
|
|
// Reopen → the same upload now goes through (the queued blob would have survived).
|
|
await api.openEvent(host.jwt);
|
|
const ok = await uploadRaw(host.jwt, SAMPLE(), {
|
|
filename: 'after-reopen.jpg',
|
|
contentType: 'image/jpeg',
|
|
});
|
|
expect(ok.status, 'upload succeeds once the host reopens').toBeLessThan(300);
|
|
});
|
|
|
|
test('released gallery → 403 uploads_locked (also reversible via reopen)', async ({ host }) => {
|
|
const rel = await fetch(`${BASE}/api/v1/host/gallery/release`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${host.jwt}` },
|
|
});
|
|
expect(rel.status).toBe(204);
|
|
|
|
const rejected = await uploadRaw(host.jwt, SAMPLE(), {
|
|
filename: 'after-release.jpg',
|
|
contentType: 'image/jpeg',
|
|
});
|
|
expect(rejected.status).toBe(403);
|
|
const body = await rejected.json();
|
|
expect(body.error).toBe('uploads_locked');
|
|
});
|
|
});
|