641174717c
Comprehensive user-flow review across guest/host/admin roles, then fixes with
e2e regression guards. Highlights:
- Offline upload queue auto-resumes on reconnect: network errors keep items
pending (not error), 4xx are terminal (no infinite retry), quota exhaustion
returns a distinct 413; queue cap + dedup.
- Export lifecycle: release atomically locks uploads; reopen invalidates and
re-release regenerates the keepsake; workers claim their job atomically so a
reopen->re-release can't corrupt the ZIP; startup re-spawns interrupted
exports.
- Sessions slide on activity (no 30-day cliff); JWT expiry deferred to the
revocable session row; sign-out-everywhere + revoke-on-PIN-reset.
- Ban always hides content (v_feed / find_visible_media / export filter
is_banned) but stays a read-only ban per USER_JOURNEYS §10 — sessions are
not revoked, read access + keepsake download preserved.
- Realtime: server-clock SSE delta cursor; event-closed/opened drive the UI
live; feed_delta rate-limited; like returns {liked, like_count} to fix
multi-device drift; lightbox live comments; diashow delta backfill.
- Forgotten-PIN in-app request flow; simultaneous same-name join returns 409;
quota increment is transactional; operator floor.
Adds e2e/specs/10-flow-review/ (offline resume, export integrity, deterministic
anti-race guard) and updates existing specs for the new contracts.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
81 lines
3.2 KiB
TypeScript
81 lines
3.2 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §7 — liking and commenting.
|
|
*
|
|
* Like behavior is asserted deterministically via the feed snapshot; the comment
|
|
* SSE round-trip is asserted by subscribing to the stream as a second user and
|
|
* waiting for the `new-comment` event to arrive.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { SseListener } from '../../helpers/sse-listener';
|
|
import { seedUpload, seedComment, findFeedRow } from '../../helpers/seed';
|
|
|
|
const BASE = process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101';
|
|
|
|
async function like(jwt: string, uploadId: string): Promise<number> {
|
|
const res = await fetch(`${BASE}/api/v1/upload/${uploadId}/like`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${jwt}` },
|
|
});
|
|
return res.status;
|
|
}
|
|
|
|
test.describe('Feed — like + comment', () => {
|
|
test('a like counts once per user and toggles off on repeat (no double-count)', async ({ api, guest }) => {
|
|
const author = await guest('Author');
|
|
const liker = await guest('Liker');
|
|
const uploadId = await seedUpload(author.jwt);
|
|
|
|
// Baseline: nobody has liked yet.
|
|
let row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// First like → counted exactly once.
|
|
expect(await like(liker.jwt, uploadId)).toBe(200);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(1);
|
|
expect(row.liked_by_me).toBe(true);
|
|
|
|
// Liking again is a toggle → back to zero (guards against a regression that
|
|
// double-counts a repeated like instead of removing it).
|
|
expect(await like(liker.jwt, uploadId)).toBe(200);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// A second distinct user's like is counted independently (per-user semantics).
|
|
expect(await like(liker.jwt, uploadId)).toBe(200); // liker likes again → 1
|
|
expect(await like(author.jwt, uploadId)).toBe(200); // author likes too → 2
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(2);
|
|
});
|
|
|
|
test('comment by user A → SSE new-comment delivered to user B', async ({ guest }) => {
|
|
// SSE frames can take a keep-alive tick to flush through the reverse proxy, so
|
|
// both the stream connect and the delivery may cost up to ~30s each.
|
|
test.setTimeout(120_000);
|
|
const a = await guest('CommenterA');
|
|
const b = await guest('ListenerB');
|
|
|
|
// B subscribes to the stream BEFORE A comments, so the broadcast is captured.
|
|
const sse = new SseListener();
|
|
await sse.start(b.jwt);
|
|
|
|
try {
|
|
const uploadId = await seedUpload(a.jwt, { caption: 'pic' });
|
|
await seedComment(a.jwt, uploadId, 'hello from A');
|
|
|
|
// B must receive the new-comment event for this upload. Generous timeout: SSE
|
|
// frames flush on the keep-alive tick through the compressing reverse proxy.
|
|
const evt = await sse.waitForEvent(
|
|
'new-comment',
|
|
(e) => e.data?.upload_id === uploadId,
|
|
45_000
|
|
);
|
|
expect(evt.data.comment_count).toBe(1);
|
|
} finally {
|
|
sse.stop();
|
|
}
|
|
});
|
|
});
|