H1: corrected a round-1 over-reach. Bans are read-only per USER_JOURNEYS §10:
the base AuthUser extractor no longer rejects banned users (they keep read
access); Require{Host,Admin} and write handlers enforce the ban via
auth.is_banned → 403 (incl. self-unban). Demoted hosts still lose powers
immediately (live DB role) and are bounced off the dashboard. Also fixed the
login/recover redirect regression on unauthenticated 401.
H2: failed compression now self-heals instead of leaving a permanent broken
card — refund the quota, delete the orphaned original, soft-delete the row;
the frontend toasts the uploader and evicts the card on upload-error.
H3: self-delete, ban-with-hide (user-hidden), and comment-deletes now broadcast
SSE; feed, diashow, and lightbox evict the affected content live instead of
waiting for a reload. sse-eviction.spec.ts covers it.
Riders: feed/+page.svelte also carries the medium truncated-delta pill; host.rs
also carries the low atomic release_gallery claim; admin/+page.svelte also drops
the dead compression_concurrency control (medium).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
124 lines
4.8 KiB
TypeScript
124 lines
4.8 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §9 — ban / unban / promote / demote. Driven mostly through
|
|
* the API because the host dashboard UI changes shape often; integration
|
|
* coverage of the buttons lives in a separate UI-focused spec.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
|
|
test.describe('Host — moderation API', () => {
|
|
test('ban with hide_uploads=true sets the right flags', async ({ api, host, guest }) => {
|
|
const target = await guest('Banned1');
|
|
await api.banUser(host.jwt, target.userId, true);
|
|
const users = await api.listUsers(host.jwt);
|
|
const row = users.find((u: any) => u.id === target.userId);
|
|
expect(row?.is_banned).toBe(true);
|
|
expect(row?.uploads_hidden).toBe(true);
|
|
});
|
|
|
|
test('ban without hiding leaves uploads_hidden=false', async ({ api, host, guest }) => {
|
|
const target = await guest('Banned2');
|
|
await api.banUser(host.jwt, target.userId, false);
|
|
const users = await api.listUsers(host.jwt);
|
|
const row = users.find((u: any) => u.id === target.userId);
|
|
expect(row?.is_banned).toBe(true);
|
|
expect(row?.uploads_hidden).toBe(false);
|
|
});
|
|
|
|
test('banned user cannot call /upload', async ({ api, host, guest }) => {
|
|
const target = await guest('Banned3');
|
|
await api.banUser(host.jwt, target.userId, false);
|
|
|
|
// Direct fetch — multipart body shape is just a marker; the auth middleware should reject before parsing.
|
|
const res = await fetch((process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101') + '/api/v1/upload', {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${target.jwt}` },
|
|
body: new FormData(),
|
|
});
|
|
expect(res.status).toBe(403);
|
|
});
|
|
|
|
test('host can promote a guest to host', async ({ api, host, guest }) => {
|
|
const target = await guest('Promoted');
|
|
await api.setRole(host.jwt, target.userId, 'host');
|
|
const users = await api.listUsers(host.jwt);
|
|
const row = users.find((u: any) => u.id === target.userId);
|
|
expect(row?.role).toBe('host');
|
|
});
|
|
});
|
|
|
|
/**
|
|
* Regression for the review's H1: role & ban used to be trusted from the JWT and
|
|
* never re-checked against the DB, so a demoted/banned host kept full powers for
|
|
* the life of their token (up to 30d) and a banned host could even unban
|
|
* themselves. The auth extractor now re-reads the live user row, so these take
|
|
* effect on the *existing* session with no re-login.
|
|
*/
|
|
test.describe('Host — live role/ban revocation (H1)', () => {
|
|
test('a demoted host loses host powers on their existing session', async ({
|
|
api,
|
|
adminToken,
|
|
guest,
|
|
}) => {
|
|
const u = await guest('DemoteMidSession');
|
|
await api.setRole(adminToken, u.userId, 'host');
|
|
// Fresh host token (role is encoded at mint time).
|
|
const { body } = await api.recover(u.displayName, u.pin);
|
|
const hostJwt = body.jwt;
|
|
|
|
// Sanity: the token currently has host powers.
|
|
await api.listUsers(hostJwt);
|
|
|
|
// Demote via admin — the host does NOT re-login.
|
|
await api.setRole(adminToken, u.userId, 'guest');
|
|
|
|
// Same token is now rejected with exactly 403 (RequireHost sees the DB role,
|
|
// not the JWT claim). Asserting the status guards against a spurious 500
|
|
// masquerading as "revoked".
|
|
await expect(api.listUsers(hostJwt)).rejects.toThrow(/→ 403/);
|
|
});
|
|
|
|
test('a banned host is locked out immediately on their existing session', async ({
|
|
api,
|
|
adminToken,
|
|
host,
|
|
}) => {
|
|
// Sanity: host token works.
|
|
await api.listUsers(host.jwt);
|
|
|
|
await api.banUser(adminToken, host.userId, false);
|
|
|
|
// Banned users are rejected with 403 by the auth extractor before any handler runs.
|
|
await expect(api.listUsers(host.jwt)).rejects.toThrow(/→ 403/);
|
|
});
|
|
|
|
test('a banned host cannot unban themselves', async ({ api, adminToken, host }) => {
|
|
await api.banUser(adminToken, host.userId, false);
|
|
await expect(
|
|
api.unbanUser(host.jwt, host.userId, { expectedStatus: [204] })
|
|
).rejects.toThrow(/→ 403/);
|
|
});
|
|
|
|
// H1 / USER_JOURNEYS §10: a banned user keeps *read* access but every write is
|
|
// rejected with 403. The ban is enforced on write handlers + Require{Host,Admin},
|
|
// NOT in the base extractor (which would wrongly block reads too).
|
|
test('a banned user keeps read access but is blocked from writes', async ({ api, host, guest }) => {
|
|
const base = process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101';
|
|
const target = await guest('BannedRW');
|
|
await api.banUser(host.jwt, target.userId, false);
|
|
|
|
// Reads still succeed.
|
|
const read = await fetch(base + '/api/v1/me/context', {
|
|
headers: { Authorization: `Bearer ${target.jwt}` },
|
|
});
|
|
expect(read.status).toBe(200);
|
|
|
|
// Writes are rejected.
|
|
const write = await fetch(base + '/api/v1/upload', {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${target.jwt}` },
|
|
body: new FormData(),
|
|
});
|
|
expect(write.status).toBe(403);
|
|
});
|
|
});
|