**1. The cached PIN could never be cleared after a host reset.** `/recover` clears a rejected cached PIN only when the submitted name is the one this device belongs to — narrowed on this branch so a guest who mistypes their own name does not lose the only copy of their PIN (the server keeps just the bcrypt). But it compared against `DISPLAY_NAME_KEY`, which `clearAuth` deletes for shared-device privacy — one step BEFORE the guest ever reaches that screen: host taps "PIN zurücksetzen" -> the backend also revokes every session for that user -> the guest's next request 401s -> clearAuth -> redirect to /join -> they go to /recover, where the field is pre-filled with the dead PIN and the guard can never fire again Since a 4-digit value auto-submits, every correction burns another of the four wrong-PIN attempts the shared venue IP allows per 15 minutes. The PIN's owner is now stored WITH the PIN and survives alongside it, with a fallback to the auth display name for devices that cached a PIN before this key existed. **2. Every layout-level SSE handler waited on the `/me/context` retry.** The retry was awaited inside the same `onMount` that registers `pin-reset`, `user-hidden`/`user-shown`, `event-closed`/`event-opened` and `event-updated`. Worst case is a 20s timeout + 2s backoff + a second 20s timeout: ~42s with an empty handler list, on exactly the wifi the retry exists for. Five of the six self-heal; `pin-reset` does not, and a missed one leaves a dead PIN displayed in "Mein Konto" and pre-filling /recover — the same state as (1), reached from the other end. Detached, since nothing below reads its result. **3. `crypto.randomUUID` was on the join critical path.** It needs Safari >= 15.4 / Chrome >= 92 AND a secure context. The queue already depended on it, so an old phone previously joined and browsed and only failed at upload — degraded but survivable. Minting an idempotency key at join turned that into a `TypeError` caught by the generic handler and rendered as "Ein Fehler ist aufgetreten." on every retry: cannot join, cannot browse, and /recover is no help because there is no account yet. The one screen where a hard failure has no way out at all. Falls back to `crypto.getRandomValues` with the RFC 4122 version and variant bits set; `Math.random` is deliberately NOT a further fallback, since a collision between two guests would replay one guest's join or upload onto another. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
220 lines
8.2 KiB
Svelte
220 lines
8.2 KiB
Svelte
<script lang="ts">
|
|
import { goto, afterNavigate } from '$app/navigation';
|
|
import { api, ApiError } from '$lib/api';
|
|
import { setAuth, getPin, getToken, clearPin, getPinOwner } from '$lib/auth';
|
|
import { markGuideSeen } from '$lib/onboarding';
|
|
import { browser } from '$app/environment';
|
|
import IconButton from '$lib/components/IconButton.svelte';
|
|
|
|
// We only want history.back() when the user actually reached /recover via in-app
|
|
// (client-side) navigation; on a cold load (deep link, new tab) history.back() would
|
|
// land on `about:blank`. `type === 'enter'` is SvelteKit's initial page load in BOTH
|
|
// SSR and CSR modes — keying on it (rather than `from === null`, which is only null on
|
|
// a cold load under SSR) keeps the check correct with `ssr = false`.
|
|
let cameFromApp = $state(false);
|
|
afterNavigate(({ from, type }) => {
|
|
cameFromApp = type !== 'enter' && from !== null;
|
|
});
|
|
|
|
function goBack() {
|
|
// Prefer the actual previous page (most users land here from /join or /account).
|
|
// Fall back to a sensible default based on auth state for deep-linked users.
|
|
if (cameFromApp) {
|
|
window.history.back();
|
|
return;
|
|
}
|
|
goto(getToken() ? '/feed' : '/join');
|
|
}
|
|
|
|
let displayName = $state('');
|
|
let pin = $state('');
|
|
let error = $state('');
|
|
let loading = $state(false);
|
|
let pinRequestLoading = $state(false);
|
|
let pinRequestSent = $state(false);
|
|
|
|
// Forgot the PIN entirely (never noted it, or a host reset it): ask a host to reset it.
|
|
// The endpoint always 204s (no name enumeration), so optimistically confirm regardless.
|
|
async function requestPinReset() {
|
|
if (!displayName.trim()) {
|
|
error = 'Bitte gib zuerst deinen Namen ein.';
|
|
return;
|
|
}
|
|
pinRequestLoading = true;
|
|
try {
|
|
await api.post('/recover/request', { display_name: displayName.trim() });
|
|
} catch {
|
|
// Non-fatal (rate limit etc.) — still confirm so the user isn't stuck.
|
|
} finally {
|
|
pinRequestLoading = false;
|
|
pinRequestSent = true;
|
|
}
|
|
}
|
|
|
|
// Pre-fill PIN from localStorage if available
|
|
if (browser) {
|
|
const savedPin = getPin();
|
|
if (savedPin) pin = savedPin;
|
|
}
|
|
|
|
async function handleRecover() {
|
|
if (!displayName.trim() || !pin.trim()) return;
|
|
loading = true;
|
|
error = '';
|
|
try {
|
|
const res = await api.post<{
|
|
jwt: string;
|
|
user_id: string;
|
|
}>('/recover', { display_name: displayName.trim(), pin: pin.trim() });
|
|
|
|
setAuth(res.jwt, pin.trim(), res.user_id, displayName.trim());
|
|
// Recovering proves this guest already has an account, so they have already been
|
|
// through onboarding — on their ORIGINAL device, whose localStorage this one does
|
|
// not share. Without this, every guest who switches phone, clears site data or
|
|
// opens the event in a second browser gets the full first-run guide again.
|
|
markGuideSeen();
|
|
// Surface a welcome-back toast on /feed after navigation. sessionStorage
|
|
// scopes the cue to the next page load so it doesn't replay on refresh.
|
|
if (browser) sessionStorage.setItem('eventsnap_just_recovered', displayName.trim());
|
|
goto('/feed');
|
|
} catch (e) {
|
|
if (e instanceof ApiError) {
|
|
error = e.message;
|
|
// A wrong PIN CAN mean the locally-cached PIN is stale (a host reset it while this
|
|
// device was offline and missed the `pin-reset` SSE), and then dropping it stops the
|
|
// field pre-filling with a dead value. `+layout.svelte` already handles the online
|
|
// case; this is the offline backstop.
|
|
//
|
|
// But it must be narrow, because the backend returns the SAME 401 for a wrong PIN
|
|
// and an UNKNOWN NAME (deliberately — it closes an enumeration and timing oracle).
|
|
// Clearing on any 401 meant a guest who mistyped their own name lost the only copy
|
|
// of their PIN: localStorage is where it lives, the server keeps only the bcrypt,
|
|
// and rejoining under the same name 409s. One typo, permanently locked out of their
|
|
// own account, needing a host with a dashboard open.
|
|
//
|
|
// So clear only when the evidence actually points at a stale cache: the name they
|
|
// submitted is the one this device belongs to, AND the PIN that was rejected is the
|
|
// cached one. Any other 401 leaves stored state untouched.
|
|
// `getPinOwner()`, NOT `getDisplayName()`. A host PIN reset also revokes the guest's
|
|
// sessions, so by the time they reach this screen `clearAuth` has already deleted the
|
|
// display name — and the guard could never fire again on that device. The dead PIN
|
|
// then pre-fills this field forever, and since a 4-digit value auto-submits, every
|
|
// correction burns another of the four wrong-PIN attempts the shared venue IP allows
|
|
// per 15 minutes. The PIN's owner is stored with the PIN and survives with it.
|
|
const submittedOwnName =
|
|
getPinOwner()?.trim().toLowerCase() === displayName.trim().toLowerCase();
|
|
const submittedCachedPin = getPin() !== null && pin.trim() === getPin();
|
|
if (e.status === 401 && submittedOwnName && submittedCachedPin) clearPin();
|
|
} else {
|
|
error = 'Ein Fehler ist aufgetreten.';
|
|
}
|
|
} finally {
|
|
loading = false;
|
|
}
|
|
}
|
|
|
|
// Strip non-digits synchronously in the input handler (not via $effect on
|
|
// bind:value) so a paste of "1234X" doesn't flash the longer string between
|
|
// the bind setting `pin` and the reactive cleanup reassigning it. Mutating
|
|
// el.value before Svelte's next render means the field never displays the
|
|
// invalid intermediate state.
|
|
function onPinInput(e: Event) {
|
|
const el = e.currentTarget as HTMLInputElement;
|
|
const cleaned = el.value.replace(/\D/g, '').slice(0, 4);
|
|
if (cleaned !== el.value) el.value = cleaned;
|
|
pin = cleaned;
|
|
if (pin.length === 4 && displayName.trim() && !loading) {
|
|
handleRecover();
|
|
}
|
|
}
|
|
</script>
|
|
|
|
<div
|
|
class="flex min-h-screen flex-col bg-gray-50 px-4 pt-[env(safe-area-inset-top)] dark:bg-gray-950"
|
|
>
|
|
<div class="-mx-4 flex items-center px-2 py-3">
|
|
<IconButton label="Zurück" onclick={goBack} data-testid="recover-back">
|
|
<svg class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
|
|
<path stroke-linecap="round" stroke-linejoin="round" d="M15.75 19.5 8.25 12l7.5-7.5" />
|
|
</svg>
|
|
</IconButton>
|
|
</div>
|
|
<div class="m-auto w-full max-w-sm">
|
|
<h1 class="mb-2 text-center text-2xl font-bold text-gray-900 dark:text-gray-100">
|
|
Konto wiederherstellen
|
|
</h1>
|
|
<p class="mb-6 text-center text-gray-600 dark:text-gray-400">
|
|
Gib deinen Namen und deinen PIN ein.
|
|
</p>
|
|
|
|
<form
|
|
onsubmit={(e) => {
|
|
e.preventDefault();
|
|
handleRecover();
|
|
}}
|
|
>
|
|
<input
|
|
type="text"
|
|
bind:value={displayName}
|
|
placeholder="Dein Name"
|
|
maxlength={50}
|
|
data-testid="recover-name-input"
|
|
class="input mb-3 text-lg"
|
|
/>
|
|
<input
|
|
type="text"
|
|
value={pin}
|
|
oninput={onPinInput}
|
|
placeholder="4-stelliger PIN"
|
|
maxlength={4}
|
|
inputmode="numeric"
|
|
pattern="[0-9]*"
|
|
data-testid="recover-pin-input"
|
|
class="input mb-3 text-center text-2xl font-mono tracking-widest"
|
|
/>
|
|
|
|
{#if error}
|
|
<p class="mb-3 text-sm text-red-600 dark:text-red-400" data-testid="recover-error">
|
|
{error}
|
|
</p>
|
|
{/if}
|
|
|
|
<button
|
|
type="submit"
|
|
disabled={loading || !displayName.trim() || pin.length < 4}
|
|
data-testid="recover-submit"
|
|
class="btn btn-primary btn-lg btn-block"
|
|
>
|
|
{loading ? 'Wird geladen...' : 'Wiederherstellen'}
|
|
</button>
|
|
</form>
|
|
|
|
<!-- PIN lost entirely (never noted, or reset by a host while offline): a soft dead-end
|
|
without this — offer the host-reset request path. -->
|
|
{#if pinRequestSent}
|
|
<p
|
|
class="mt-4 text-center text-sm text-green-700 dark:text-green-400"
|
|
data-testid="recover-pin-request-sent"
|
|
>
|
|
Anfrage gesendet. Bitte einen Host, deine PIN zurückzusetzen — komm danach mit der neuen PIN
|
|
zurück.
|
|
</p>
|
|
{:else}
|
|
<button
|
|
type="button"
|
|
onclick={requestPinReset}
|
|
disabled={pinRequestLoading}
|
|
data-testid="recover-request-pin-reset"
|
|
class="mt-4 w-full text-center text-sm text-blue-600 underline disabled:opacity-50 dark:text-blue-400"
|
|
>
|
|
{pinRequestLoading ? 'Wird gesendet…' : 'PIN vergessen? Host um Zurücksetzen bitten'}
|
|
</button>
|
|
{/if}
|
|
|
|
<p class="mt-4 text-center text-sm text-gray-500 dark:text-gray-400">
|
|
Noch kein Konto?
|
|
<a href="/join" class="text-blue-600 hover:underline dark:text-blue-400">Neu beitreten</a>
|
|
</p>
|
|
</div>
|
|
</div>
|