Adversarial re-review of the persona-audit + audit-followup rounds (6411747..)
found one HIGH and one MED regression plus LOW gaps. All fixed with coverage.
HIGH — export stale-keepsake resurrected by an open_event race
A reopen landing in the window between a *current* export worker's finalize_job
and its ready-flag flip cleared export_released_at + the ready flags but left the
export_job row `done` at the same release_seq. The seq-guarded flip then still
matched and re-set export_{zip,html}_ready=TRUE on a pre-reopen snapshot; the next
re-release read that stale TRUE and skipped regeneration (`if ready { continue }`),
serving a keepsake missing every upload from the reopen window — the exact data
loss migration 012 exists to prevent. Both ready-flip UPDATEs are now additionally
anchored on `export_released_at IS NOT NULL`, so a landed reopen makes the flip a
no-op and the re-release regenerates cleanly.
MED — queue dedup broke for reloaded items
loadQueue rebuilt QueueItems from IndexedDB without copying lastModified, which the
new addToQueue dedup keys on. A file re-selected after a page reload / PWA relaunch
missed the duplicate check and uploaded twice. Rehydration now carries lastModified
(extracted to a pure, tested entryToQueueItem helper).
LOW
- diashow: clear the upload-processed debounce timer in onDestroy (no stray
post-unmount /feed fetch).
- USER_JOURNEYS §9.5: document the reconnect-delta ban replay (hidden_user_ids /
uploads_hidden_at, migration 013), not just the live user-hidden SSE.
- e2e api-client: drop the misleading hide_uploads param from banUser — the backend
takes no body and always hides; strip the dead boolean at all call sites.
Tests
- Extract isReversibleLock (the terminal-403 KEEP-vs-PURGE-blob discriminator) into a
pure exported helper + unit tests, so the data-loss-critical branch is covered
without an XHR harness.
- entryToQueueItem unit tests lock the lastModified-carry regression.
- Document the export flip-race guard in the reopen/re-release spec (the sub-ms
finalize↔flip interleave isn't deterministically forceable with fast fixtures;
covered by the SQL guard + the end-to-end completeness test).
Verified: backend 40 tests, frontend 44 unit tests, svelte-check 0 errors,
e2e 156 passed / 1 skipped on chromium-desktop.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
173 lines
6.5 KiB
TypeScript
173 lines
6.5 KiB
TypeScript
/**
|
|
* Tiny typed wrapper around the EventSnap REST API for use inside tests.
|
|
* Used to seed data far faster than driving the UI through every join /
|
|
* upload, and to set up adversarial states (banned users, locked PINs) that
|
|
* the UI cannot reach.
|
|
*
|
|
* Auth: pass `token` on individual calls; no global state.
|
|
*/
|
|
|
|
export const ADMIN_PASSWORD = 'admin-test-pw';
|
|
|
|
export class ApiClient {
|
|
constructor(private baseUrl: string = process.env.E2E_FRONTEND_URL ?? 'http://localhost:3101') {}
|
|
|
|
private async request<T>(
|
|
method: string,
|
|
path: string,
|
|
opts: { token?: string; body?: unknown; expectedStatus?: number | number[] } = {}
|
|
): Promise<{ status: number; body: T }> {
|
|
const headers: Record<string, string> = {};
|
|
if (opts.token) headers['Authorization'] = `Bearer ${opts.token}`;
|
|
if (opts.body !== undefined) headers['Content-Type'] = 'application/json';
|
|
|
|
const res = await fetch(`${this.baseUrl}/api/v1${path}`, {
|
|
method,
|
|
headers,
|
|
body: opts.body !== undefined ? JSON.stringify(opts.body) : undefined,
|
|
});
|
|
|
|
const expected = opts.expectedStatus ?? [200, 201, 204];
|
|
const allowed = Array.isArray(expected) ? expected : [expected];
|
|
let body: unknown = undefined;
|
|
if (res.status !== 204) {
|
|
const text = await res.text();
|
|
try {
|
|
body = text.length > 0 ? JSON.parse(text) : undefined;
|
|
} catch {
|
|
body = text;
|
|
}
|
|
}
|
|
if (!allowed.includes(res.status)) {
|
|
throw new Error(
|
|
`API ${method} ${path} → ${res.status} (expected ${allowed.join('/')}). Body: ${JSON.stringify(body)}`
|
|
);
|
|
}
|
|
return { status: res.status, body: body as T };
|
|
}
|
|
|
|
// ── Auth ───────────────────────────────────────────────────────────────
|
|
async join(displayName: string): Promise<{ jwt: string; pin: string; user_id: string; is_new: boolean }> {
|
|
const { body } = await this.request<any>('POST', '/join', {
|
|
body: { display_name: displayName },
|
|
expectedStatus: [201],
|
|
});
|
|
return body;
|
|
}
|
|
|
|
async recover(displayName: string, pin: string, opts: { expectedStatus?: number | number[] } = {}) {
|
|
return this.request<any>('POST', '/recover', {
|
|
body: { display_name: displayName, pin },
|
|
expectedStatus: opts.expectedStatus ?? [200],
|
|
});
|
|
}
|
|
|
|
async adminLogin(password: string = ADMIN_PASSWORD): Promise<string> {
|
|
const { body } = await this.request<{ jwt: string }>('POST', '/admin/login', {
|
|
body: { password },
|
|
});
|
|
return body.jwt;
|
|
}
|
|
|
|
async logout(token: string) {
|
|
return this.request<void>('DELETE', '/session', { token, expectedStatus: [204] });
|
|
}
|
|
|
|
// ── Test-mode helpers ──────────────────────────────────────────────────
|
|
async truncate(adminToken: string) {
|
|
return this.request<void>('POST', '/admin/__truncate', {
|
|
token: adminToken,
|
|
expectedStatus: [204],
|
|
});
|
|
}
|
|
|
|
// ── Config ─────────────────────────────────────────────────────────────
|
|
async patchConfig(adminToken: string, patch: Record<string, string>) {
|
|
return this.request<void>('PATCH', '/admin/config', {
|
|
token: adminToken,
|
|
body: patch,
|
|
expectedStatus: [204],
|
|
});
|
|
}
|
|
|
|
async getConfig(adminToken: string): Promise<Record<string, string>> {
|
|
const { body } = await this.request<Record<string, string>>('GET', '/admin/config', { token: adminToken });
|
|
return body;
|
|
}
|
|
|
|
// ── Host moderation ────────────────────────────────────────────────────
|
|
async listUsers(token: string) {
|
|
const { body } = await this.request<any[]>('GET', '/host/users', { token });
|
|
return body;
|
|
}
|
|
|
|
async setRole(token: string, userId: string, role: 'guest' | 'host') {
|
|
return this.request<void>('PATCH', `/host/users/${userId}/role`, {
|
|
token,
|
|
body: { role },
|
|
expectedStatus: [200, 204],
|
|
});
|
|
}
|
|
|
|
// A ban ALWAYS hides the user's uploads — the backend takes no body and ignores any
|
|
// `hide_uploads` flag (the old opt-out was removed). No per-request options.
|
|
async banUser(token: string, userId: string) {
|
|
return this.request<void>('POST', `/host/users/${userId}/ban`, {
|
|
token,
|
|
expectedStatus: [200, 204],
|
|
});
|
|
}
|
|
|
|
async unbanUser(token: string, userId: string, opts: { expectedStatus?: number | number[] } = {}) {
|
|
return this.request<void>('POST', `/host/users/${userId}/unban`, {
|
|
token,
|
|
expectedStatus: opts.expectedStatus ?? [200, 204],
|
|
});
|
|
}
|
|
|
|
/** Reset another user's PIN. Returns the plaintext PIN the host must relay once. */
|
|
async resetUserPin(
|
|
token: string,
|
|
userId: string,
|
|
opts: { expectedStatus?: number | number[] } = {}
|
|
): Promise<{ status: number; body: { pin?: string } }> {
|
|
return this.request<{ pin?: string }>('POST', `/host/users/${userId}/pin-reset`, {
|
|
token,
|
|
expectedStatus: opts.expectedStatus ?? [200],
|
|
});
|
|
}
|
|
|
|
async closeEvent(token: string) {
|
|
return this.request<void>('POST', '/host/event/close', { token, expectedStatus: [200, 204] });
|
|
}
|
|
|
|
async openEvent(token: string) {
|
|
return this.request<void>('POST', '/host/event/open', { token, expectedStatus: [200, 204] });
|
|
}
|
|
|
|
// ── Feed ───────────────────────────────────────────────────────────────
|
|
async getFeed(token: string) {
|
|
const { body } = await this.request<any>('GET', '/feed', { token });
|
|
return body;
|
|
}
|
|
|
|
async getStats(adminToken: string) {
|
|
const { body } = await this.request<any>('GET', '/admin/stats', { token: adminToken });
|
|
return body;
|
|
}
|
|
|
|
// ── Health ─────────────────────────────────────────────────────────────
|
|
async waitForHealth(retries = 60): Promise<void> {
|
|
for (let i = 0; i < retries; i++) {
|
|
try {
|
|
const res = await fetch(`${this.baseUrl}/health`);
|
|
if (res.ok) return;
|
|
} catch {
|
|
/* keep retrying */
|
|
}
|
|
await new Promise((r) => setTimeout(r, 1000));
|
|
}
|
|
throw new Error(`Backend never became healthy at ${this.baseUrl}/health`);
|
|
}
|
|
}
|