136417d6b4
Several tests ran green while asserting nothing. Replace them with real assertions, and fix the SSE helper they depend on. sse-listener: exchange the JWT for a single-use ticket (POST /stream/ticket) and connect via ?ticket= — the helper still used the dead ?token= scheme, so every SSE-based assertion would have silently failed to receive events. like-comment: - "like is idempotent" asserted nothing (void feed; void b) → now seeds a real upload and pins the like contract: counted once per user, toggles off on repeat (guards double-count), and a second user's like is counted independently. - "comment → SSE to B" asserted length >= 0 (always true) → B now subscribes to the stream, A comments, and B must receive the new-comment event for that upload (comment_count === 1). ~30s due to reverse-proxy SSE buffering; timeout raised. sse-realtime: only checked a nav link was visible → now counts EventSource opens and asserts a fresh stream connection after hidden→visible (also fixes the sim, which set visibilityState but not document.hidden, so the close never fired). multi-tab "SSE delivers to both": only checked nav links → now asserts each tab opens its own stream connection (delivery isn't asserted — it hinges on the ~30s proxy buffering; connection establishment is the reliable, honest signal). safe-area: delete the /join probe whose only assertion was Array.isArray(x) === true (always true); the real sheet-level env() check already exists below it. All verified green against the live backend. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
67 lines
2.9 KiB
TypeScript
67 lines
2.9 KiB
TypeScript
/**
|
|
* Phase 3 mobile — safe-area inset audit.
|
|
*
|
|
* The frontend uses `padding-bottom: env(safe-area-inset-bottom)` on every
|
|
* UI element that's anchored to the bottom of the viewport so content
|
|
* doesn't get covered by the iOS home indicator. The actual inset is 0
|
|
* inside Playwright's emulated devices (no notch), but we can assert that:
|
|
*
|
|
* 1. The `style` attribute references `env(safe-area-inset-bottom)`.
|
|
* 2. The element sits flush with the bottom of the viewport (no
|
|
* ghost gap of unexpected pixels).
|
|
*
|
|
* A future visual-regression pass on a real iPhone descriptor (Phase 3.5
|
|
* "real-device compat") would catch actual safe-area mis-sizing.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { inlineStyle } from '../../helpers/touch';
|
|
|
|
test.describe('Mobile — safe-area insets', () => {
|
|
test('bottom nav declares safe-area-inset-bottom in its inline style', async ({ page, guest, signIn }) => {
|
|
const g = await guest('SafeAreaNav');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const nav = page.locator('nav').filter({ has: page.getByRole('link', { name: 'Galerie' }) }).first();
|
|
await expect(nav).toBeVisible();
|
|
|
|
const style = await inlineStyle(nav);
|
|
expect(style).toContain('env(safe-area-inset-bottom)');
|
|
});
|
|
|
|
test('bottom nav stays flush with viewport bottom (no large gap)', async ({ page, guest, signIn }) => {
|
|
const g = await guest('SafeAreaFlush');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const nav = page.locator('nav').filter({ has: page.getByRole('link', { name: 'Galerie' }) }).first();
|
|
const viewport = page.viewportSize();
|
|
if (!viewport) throw new Error('No viewport size set on this project');
|
|
const box = await nav.boundingBox();
|
|
if (!box) throw new Error('nav not visible');
|
|
|
|
const distanceFromBottom = viewport.height - (box.y + box.height);
|
|
// With no notch the inset is 0; allow a tiny tolerance for sub-pixel rounding.
|
|
expect(distanceFromBottom).toBeLessThanOrEqual(2);
|
|
});
|
|
|
|
// (A vacuous `/join` probe that only asserted `Array.isArray(...)` — always true —
|
|
// was removed; the real sheet-level env() check is the structural test below.)
|
|
|
|
test('upload sheet and context sheet both honor env() (structural check)', async ({ page, guest, signIn }) => {
|
|
const g = await guest('SafeAreaSheets');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
// Tap the FAB to open the UploadSheet — its outer container should declare env().
|
|
await page.getByRole('button', { name: 'Hochladen' }).click();
|
|
// Even if the sheet is offscreen / hidden, the style attribute is present in the DOM.
|
|
const hits: number = await page.evaluate(() => {
|
|
return Array.from(document.querySelectorAll<HTMLElement>('[style]'))
|
|
.filter((el) => (el.getAttribute('style') ?? '').includes('env(safe-area-inset-bottom)'))
|
|
.length;
|
|
});
|
|
expect(hits).toBeGreaterThanOrEqual(1);
|
|
});
|
|
});
|