bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
30 lines
928 B
TypeScript
30 lines
928 B
TypeScript
/**
|
|
* USER_JOURNEYS.md §15 — leaving an event clears auth and routes to /join.
|
|
* The journey doc spells out: clears JWT and PIN, calls DELETE /session.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { AccountPage } from '../../page-objects';
|
|
import { readStorage } from '../../helpers/storage-helpers';
|
|
|
|
test.describe('Auth — leave event', () => {
|
|
test('leave event clears localStorage and redirects to /join', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const h = await guest('Jens');
|
|
await signIn(page, h);
|
|
|
|
const account = new AccountPage(page);
|
|
await account.goto();
|
|
await account.leaveEvent();
|
|
|
|
await expect(page).toHaveURL(/\/join$/);
|
|
|
|
const storage = await readStorage(page);
|
|
expect(storage.jwt, 'JWT should be cleared').toBeNull();
|
|
// PIN is intentionally retained per auth.ts so the user can recover.
|
|
expect(storage.userId).toBeNull();
|
|
});
|
|
});
|