bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
83 lines
3.1 KiB
TypeScript
83 lines
3.1 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §7 — liking and commenting.
|
|
*
|
|
* Like behavior is asserted deterministically via the feed snapshot; the comment
|
|
* SSE round-trip is asserted by subscribing to the stream as a second user and
|
|
* waiting for the `new-comment` event to arrive.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { SseListener } from '../../helpers/sse-listener';
|
|
import { seedUpload, seedComment, findFeedRow } from '../../helpers/seed';
|
|
import { BASE } from '../../helpers/env';
|
|
|
|
async function like(jwt: string, uploadId: string): Promise<number> {
|
|
const res = await fetch(`${BASE}/api/v1/upload/${uploadId}/like`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${jwt}` },
|
|
});
|
|
return res.status;
|
|
}
|
|
|
|
test.describe('Feed — like + comment', () => {
|
|
test('a like counts once per user and toggles off on repeat (no double-count)', async ({
|
|
api,
|
|
guest,
|
|
}) => {
|
|
const author = await guest('Author');
|
|
const liker = await guest('Liker');
|
|
const uploadId = await seedUpload(author.jwt);
|
|
|
|
// Baseline: nobody has liked yet.
|
|
let row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// First like → counted exactly once.
|
|
expect(await like(liker.jwt, uploadId)).toBe(200);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(1);
|
|
expect(row.liked_by_me).toBe(true);
|
|
|
|
// Liking again is a toggle → back to zero (guards against a regression that
|
|
// double-counts a repeated like instead of removing it).
|
|
expect(await like(liker.jwt, uploadId)).toBe(200);
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(0);
|
|
expect(row.liked_by_me).toBe(false);
|
|
|
|
// A second distinct user's like is counted independently (per-user semantics).
|
|
expect(await like(liker.jwt, uploadId)).toBe(200); // liker likes again → 1
|
|
expect(await like(author.jwt, uploadId)).toBe(200); // author likes too → 2
|
|
row = findFeedRow(await api.getFeed(liker.jwt), uploadId);
|
|
expect(row.like_count).toBe(2);
|
|
});
|
|
|
|
test('comment by user A → SSE new-comment delivered to user B', async ({ guest }) => {
|
|
// SSE frames can take a keep-alive tick to flush through the reverse proxy, so
|
|
// both the stream connect and the delivery may cost up to ~30s each.
|
|
test.setTimeout(120_000);
|
|
const a = await guest('CommenterA');
|
|
const b = await guest('ListenerB');
|
|
|
|
// B subscribes to the stream BEFORE A comments, so the broadcast is captured.
|
|
const sse = new SseListener();
|
|
await sse.start(b.jwt);
|
|
|
|
try {
|
|
const uploadId = await seedUpload(a.jwt, { caption: 'pic' });
|
|
await seedComment(a.jwt, uploadId, 'hello from A');
|
|
|
|
// B must receive the new-comment event for this upload. Generous timeout: SSE
|
|
// frames flush on the keep-alive tick through the compressing reverse proxy.
|
|
const evt = await sse.waitForEvent(
|
|
'new-comment',
|
|
(e) => e.data?.upload_id === uploadId,
|
|
45_000
|
|
);
|
|
expect(evt.data.comment_count).toBe(1);
|
|
} finally {
|
|
sse.stop();
|
|
}
|
|
});
|
|
});
|