The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
103 lines
3.9 KiB
TypeScript
103 lines
3.9 KiB
TypeScript
/**
|
|
* Phase 3 mobile — long-press gesture.
|
|
*
|
|
* The `longpress` action attaches to `<article>` in FeedListCard and to
|
|
* grid cells in VirtualFeed (grid mode). Holding for ≥ 500 ms fires `onlongpress`,
|
|
* which opens the ContextSheet bottom sheet via the feed page's
|
|
* `contextTarget` state.
|
|
*
|
|
* Setup needs at least one upload to render a card. We post via the
|
|
* Phase 2 upload-client helper, then drive the gesture with the touch
|
|
* helper.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { uploadRaw } from '../../helpers/upload-client';
|
|
import { longPress } from '../../helpers/touch';
|
|
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
|
|
const SAMPLE_JPG = join(process.cwd(), 'fixtures', 'media', 'sample.jpg');
|
|
|
|
async function seedUpload(token: string, caption = 'Longpress fixture') {
|
|
const body = readFileSync(SAMPLE_JPG);
|
|
const res = await uploadRaw(token, body, {
|
|
filename: 'lp.jpg',
|
|
contentType: 'image/jpeg',
|
|
caption,
|
|
});
|
|
if (res.status !== 201) {
|
|
const text = await res.text();
|
|
throw new Error(`Upload seed failed (${res.status}): ${text}`);
|
|
}
|
|
return res.json() as Promise<{ id: string }>;
|
|
}
|
|
|
|
test.describe('Mobile — long-press gesture', () => {
|
|
test('long-press on a FeedListCard opens the ContextSheet', async ({ page, guest, signIn }) => {
|
|
const g = await guest('Lp1');
|
|
await seedUpload(g.jwt, 'Hold to open');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
// Wait for at least one article to render. Caption text appears once feed loads.
|
|
const card = page.locator('article').filter({ hasText: g.displayName }).first();
|
|
await expect(card).toBeVisible({ timeout: 10_000 });
|
|
|
|
await longPress(page, card, 600);
|
|
|
|
// The ContextSheet is always mounted (it translates off-screen when closed).
|
|
// Target it by its stable data-testid, gated on aria-modal="true" which the
|
|
// component sets only while open — unambiguous vs. the centered LightboxModal
|
|
// (which also has aria-modal) and independent of the animation classes.
|
|
const sheet = page.locator('[data-testid="context-sheet"][aria-modal="true"]');
|
|
await expect(sheet).toBeVisible({ timeout: 2_000 });
|
|
await expect(sheet.getByRole('button', { name: /abbrechen/i })).toBeVisible();
|
|
});
|
|
|
|
test('a quick tap (< 500 ms) does NOT open the ContextSheet — only opens the lightbox', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('Lp2');
|
|
await seedUpload(g.jwt, 'Quick tap');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const card = page.locator('article').filter({ hasText: g.displayName }).first();
|
|
await expect(card).toBeVisible({ timeout: 10_000 });
|
|
|
|
// Simulate a short press (200 ms — well under the 500 ms threshold).
|
|
await longPress(page, card, 200);
|
|
|
|
// Within 1 s, the ContextSheet must not be open (aria-modal is set only when
|
|
// open). A quick tap opens the lightbox instead, which is a different element.
|
|
await expect(page.locator('[data-testid="context-sheet"][aria-modal="true"]')).toHaveCount(0, {
|
|
timeout: 1_000,
|
|
});
|
|
});
|
|
|
|
test('long-press suppresses the click that lands at pointerup (no double-open of lightbox)', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('Lp3');
|
|
await seedUpload(g.jwt, 'Suppress click');
|
|
await signIn(page, g);
|
|
await page.goto('/feed');
|
|
|
|
const card = page.locator('article').filter({ hasText: g.displayName }).first();
|
|
await expect(card).toBeVisible({ timeout: 10_000 });
|
|
|
|
await longPress(page, card, 700);
|
|
|
|
// The longpress action sets `suppressNextClick = true` — so the lightbox
|
|
// (separate role=dialog) should NOT appear in addition to the context sheet.
|
|
// Exactly one aria-modal=true dialog should be open: the context sheet.
|
|
await expect(page.locator('[role="dialog"][aria-modal="true"]')).toHaveCount(1, {
|
|
timeout: 2_000,
|
|
});
|
|
});
|
|
});
|