bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
44 lines
1.6 KiB
TypeScript
44 lines
1.6 KiB
TypeScript
/**
|
|
* Critical a11y fix — bottom sheets on /account (data-mode warning and
|
|
* leave-confirm) now respond to Escape via the focusTrap action. They were
|
|
* previously click-only, blocking keyboard / switch-control users.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
|
|
test.describe('Mobile a11y — sheets dismiss on Escape', () => {
|
|
test('data-mode warning sheet closes on Escape', async ({ page, guest, signIn }) => {
|
|
const g = await guest('SheetEsc');
|
|
await signIn(page, g);
|
|
await page.goto('/account');
|
|
|
|
// Click the "Original" radio in the Datennutzung section to open the warning sheet.
|
|
// The radio's accessible name is its title + description ("Original Lädt die
|
|
// Originaldateien…"), so anchor on the start, not the end.
|
|
const originalRadio = page.getByRole('radio', { name: /^Original/i });
|
|
await originalRadio.click();
|
|
|
|
const sheet = page.locator('[role="dialog"][aria-labelledby="data-mode-title"]');
|
|
await expect(sheet).toBeVisible();
|
|
|
|
await page.keyboard.press('Escape');
|
|
await expect(sheet).not.toBeVisible({ timeout: 2_000 });
|
|
});
|
|
|
|
test('leave-confirm sheet (built on ConfirmSheet) closes on Escape', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('LeaveEsc');
|
|
await signIn(page, g);
|
|
await page.goto('/account');
|
|
|
|
await page.getByRole('button', { name: /Event verlassen/i }).click();
|
|
const sheet = page.getByTestId('confirm-sheet');
|
|
await expect(sheet).toBeVisible();
|
|
|
|
await page.keyboard.press('Escape');
|
|
await expect(sheet).not.toBeVisible({ timeout: 2_000 });
|
|
});
|
|
});
|