bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
51 lines
1.7 KiB
TypeScript
51 lines
1.7 KiB
TypeScript
/**
|
|
* UX fix — tapping X on the upload composer used to silently discard
|
|
* staged files + caption. Now opens a ConfirmSheet so a mistap from the
|
|
* corner is recoverable.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
|
|
test.describe('Mobile — upload composer cancel confirmation', () => {
|
|
test('typing a caption then tapping X opens the discard ConfirmSheet', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('CancelConf');
|
|
await signIn(page, g);
|
|
|
|
// Land on /upload directly (no staged files; the pending-upload-store is
|
|
// empty). Typing into the caption flips the dirty flag.
|
|
await page.goto('/upload');
|
|
|
|
const caption = page.getByTestId('upload-caption');
|
|
await expect(caption).toBeVisible();
|
|
await caption.fill('a meaningful caption that I do not want to lose');
|
|
|
|
// Tap the close (X) button in the composer header.
|
|
await page.getByRole('button', { name: 'Abbrechen' }).click();
|
|
|
|
const sheet = page.getByTestId('confirm-sheet');
|
|
await expect(sheet).toBeVisible();
|
|
await expect(sheet).toContainText(/Verwerfen/);
|
|
|
|
// Cancel — sheet closes, caption is preserved.
|
|
await page.getByTestId('confirm-sheet-cancel').click();
|
|
await expect(sheet).not.toBeVisible();
|
|
await expect(caption).toHaveValue(/a meaningful caption/);
|
|
});
|
|
|
|
test('with no content, tapping X navigates directly to /feed', async ({
|
|
page,
|
|
guest,
|
|
signIn,
|
|
}) => {
|
|
const g = await guest('CancelEmpty');
|
|
await signIn(page, g);
|
|
await page.goto('/upload');
|
|
|
|
await page.getByRole('button', { name: 'Abbrechen' }).click();
|
|
await page.waitForURL('**/feed', { timeout: 3_000 });
|
|
});
|
|
});
|