Follows the perf + security + user-flow work with a role/persona audit (guest, host, admin, projector) and fixes across three review rounds. Highlights: HIGH - Ban now replays on reconnect. A ban isn't a soft-delete, and the `user-hidden` SSE has no replay, so a client that missed it (esp. the unattended diashow) kept cycling a banned user's slides. New `uploads_hidden_at` (migration 013) + `hidden_user_ids` in /feed/delta; feed + diashow evict those users. Applied even on a truncated delta. MEDIUM - Locked-upload data loss: a photo staged offline during a lock/release was purged as a terminal 4xx and lost when the host reopened. New reversible `uploads_locked` error code; the queue keeps the blob and auto-resumes on the `event-opened` SSE. - Reopen after release now warns (ConfirmSheet) that it revokes the published keepsake. - Host "forgotten-PIN" badge updates live (`pin-reset-requested` was broadcast but never in KNOWN_EVENTS / subscribed); host page also refetches on `pin-reset` so a two-host race can't hand out a conflicting PIN. - Ban modal copy fixed (read-only ban, not "session ended"); Degradieren/Sperren/Entsperren hidden on peer-host rows for non-admins (they always 403'd). - Host dashboard shows live keepsake generation progress / ready state + link to /export. - Admin JWT moved to sessionStorage (§11.1) to bound exposure on shared devices. Export generation guard (H1 from the prior round, hardened): per-(event,type) `release_seq` (migration 012) with seq-guarded claim/finalize/mark_failed/update_progress, per-generation temp/final paths, download follows `file_path`, prune only strictly-older generations. LOW: diashow coalesces upload-processed (avoids self-rate-limit); event-closed reconciles galleryReleased; /recover gains a forgot-PIN request + drops a stale cached PIN on 401; delta `>=` tie-break + 429 retry; misc copy/labels. Adds e2e: ban-replay, upload-lock-code, and rewrites export-reopen-rerelease with a data-completeness test. Reconciles USER_JOURNEYS §9/§11. Verified: cargo build clean, 40 unit tests, svelte-check 0 errors, 33 frontend unit tests, 155 e2e passing on chromium-desktop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
175 lines
6.6 KiB
Svelte
175 lines
6.6 KiB
Svelte
<script lang="ts">
|
|
import { goto, afterNavigate } from '$app/navigation';
|
|
import { api, ApiError } from '$lib/api';
|
|
import { setAuth, getPin, getToken, clearPin } from '$lib/auth';
|
|
import { browser } from '$app/environment';
|
|
import IconButton from '$lib/components/IconButton.svelte';
|
|
|
|
// `from` is non-null only when we arrived here via in-app (client-side)
|
|
// navigation; on a full-page load (deep link, new tab) it's null. Using
|
|
// history.length is unreliable — a fresh tab keeps `about:blank` as the prior
|
|
// entry, so history.back() would land there instead of inside the app.
|
|
let cameFromApp = $state(false);
|
|
afterNavigate(({ from }) => {
|
|
cameFromApp = from !== null;
|
|
});
|
|
|
|
function goBack() {
|
|
// Prefer the actual previous page (most users land here from /join or /account).
|
|
// Fall back to a sensible default based on auth state for deep-linked users.
|
|
if (cameFromApp) {
|
|
window.history.back();
|
|
return;
|
|
}
|
|
goto(getToken() ? '/feed' : '/join');
|
|
}
|
|
|
|
let displayName = $state('');
|
|
let pin = $state('');
|
|
let error = $state('');
|
|
let loading = $state(false);
|
|
let pinRequestLoading = $state(false);
|
|
let pinRequestSent = $state(false);
|
|
|
|
// Forgot the PIN entirely (never noted it, or a host reset it): ask a host to reset it.
|
|
// The endpoint always 204s (no name enumeration), so optimistically confirm regardless.
|
|
async function requestPinReset() {
|
|
if (!displayName.trim()) {
|
|
error = 'Bitte gib zuerst deinen Namen ein.';
|
|
return;
|
|
}
|
|
pinRequestLoading = true;
|
|
try {
|
|
await api.post('/recover/request', { display_name: displayName.trim() });
|
|
} catch {
|
|
// Non-fatal (rate limit etc.) — still confirm so the user isn't stuck.
|
|
} finally {
|
|
pinRequestLoading = false;
|
|
pinRequestSent = true;
|
|
}
|
|
}
|
|
|
|
// Pre-fill PIN from localStorage if available
|
|
if (browser) {
|
|
const savedPin = getPin();
|
|
if (savedPin) pin = savedPin;
|
|
}
|
|
|
|
async function handleRecover() {
|
|
if (!displayName.trim() || !pin.trim()) return;
|
|
loading = true;
|
|
error = '';
|
|
try {
|
|
const res = await api.post<{
|
|
jwt: string;
|
|
user_id: string;
|
|
}>('/recover', { display_name: displayName.trim(), pin: pin.trim() });
|
|
|
|
setAuth(res.jwt, pin.trim(), res.user_id, displayName.trim());
|
|
// Surface a welcome-back toast on /feed after navigation. sessionStorage
|
|
// scopes the cue to the next page load so it doesn't replay on refresh.
|
|
if (browser) sessionStorage.setItem('eventsnap_just_recovered', displayName.trim());
|
|
goto('/feed');
|
|
} catch (e) {
|
|
if (e instanceof ApiError) {
|
|
error = e.message;
|
|
// A wrong PIN here often means the locally-cached PIN is stale (a host reset it
|
|
// while this device was offline and missed the `pin-reset` SSE). Drop the cached
|
|
// value so it doesn't keep pre-filling the field with the dead PIN.
|
|
if (e.status === 401) clearPin();
|
|
} else {
|
|
error = 'Ein Fehler ist aufgetreten.';
|
|
}
|
|
} finally {
|
|
loading = false;
|
|
}
|
|
}
|
|
|
|
// Strip non-digits synchronously in the input handler (not via $effect on
|
|
// bind:value) so a paste of "1234X" doesn't flash the longer string between
|
|
// the bind setting `pin` and the reactive cleanup reassigning it. Mutating
|
|
// el.value before Svelte's next render means the field never displays the
|
|
// invalid intermediate state.
|
|
function onPinInput(e: Event) {
|
|
const el = e.currentTarget as HTMLInputElement;
|
|
const cleaned = el.value.replace(/\D/g, '').slice(0, 4);
|
|
if (cleaned !== el.value) el.value = cleaned;
|
|
pin = cleaned;
|
|
if (pin.length === 4 && displayName.trim() && !loading) {
|
|
handleRecover();
|
|
}
|
|
}
|
|
</script>
|
|
|
|
<div class="flex min-h-screen flex-col bg-gray-50 px-4 pt-[env(safe-area-inset-top)] dark:bg-gray-950">
|
|
<div class="-mx-4 flex items-center px-2 py-3">
|
|
<IconButton label="Zurück" onclick={goBack} data-testid="recover-back">
|
|
<svg class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
|
|
<path stroke-linecap="round" stroke-linejoin="round" d="M15.75 19.5 8.25 12l7.5-7.5" />
|
|
</svg>
|
|
</IconButton>
|
|
</div>
|
|
<div class="m-auto w-full max-w-sm">
|
|
<h1 class="mb-2 text-center text-2xl font-bold text-gray-900 dark:text-gray-100">Konto wiederherstellen</h1>
|
|
<p class="mb-6 text-center text-gray-600 dark:text-gray-400">Gib deinen Namen und deinen PIN ein.</p>
|
|
|
|
<form onsubmit={(e) => { e.preventDefault(); handleRecover(); }}>
|
|
<input
|
|
type="text"
|
|
bind:value={displayName}
|
|
placeholder="Dein Name"
|
|
maxlength={50}
|
|
data-testid="recover-name-input"
|
|
class="mb-3 w-full rounded-lg border border-gray-300 bg-white px-4 py-3 text-lg text-gray-900 placeholder-gray-400 focus:border-blue-500 focus:outline-none focus:ring-2 focus:ring-blue-200 dark:border-gray-700 dark:bg-gray-900 dark:text-gray-100 dark:placeholder-gray-500"
|
|
/>
|
|
<input
|
|
type="text"
|
|
value={pin}
|
|
oninput={onPinInput}
|
|
placeholder="4-stelliger PIN"
|
|
maxlength={4}
|
|
inputmode="numeric"
|
|
pattern="[0-9]*"
|
|
data-testid="recover-pin-input"
|
|
class="mb-3 w-full rounded-lg border border-gray-300 bg-white px-4 py-3 text-center text-2xl font-mono tracking-widest text-gray-900 placeholder-gray-400 focus:border-blue-500 focus:outline-none focus:ring-2 focus:ring-blue-200 dark:border-gray-700 dark:bg-gray-900 dark:text-gray-100 dark:placeholder-gray-500"
|
|
/>
|
|
|
|
{#if error}
|
|
<p class="mb-3 text-sm text-red-600 dark:text-red-400" data-testid="recover-error">{error}</p>
|
|
{/if}
|
|
|
|
<button
|
|
type="submit"
|
|
disabled={loading || !displayName.trim() || pin.length < 4}
|
|
data-testid="recover-submit"
|
|
class="w-full rounded-lg bg-blue-600 px-4 py-3 text-lg font-medium text-white transition hover:bg-blue-700 disabled:opacity-50 dark:bg-blue-500 dark:hover:bg-blue-400"
|
|
>
|
|
{loading ? 'Wird geladen...' : 'Wiederherstellen'}
|
|
</button>
|
|
</form>
|
|
|
|
<!-- PIN lost entirely (never noted, or reset by a host while offline): a soft dead-end
|
|
without this — offer the host-reset request path. -->
|
|
{#if pinRequestSent}
|
|
<p class="mt-4 text-center text-sm text-green-700 dark:text-green-400" data-testid="recover-pin-request-sent">
|
|
Anfrage gesendet. Bitte einen Host, deine PIN zurückzusetzen — komm danach mit der neuen PIN zurück.
|
|
</p>
|
|
{:else}
|
|
<button
|
|
type="button"
|
|
onclick={requestPinReset}
|
|
disabled={pinRequestLoading}
|
|
data-testid="recover-request-pin-reset"
|
|
class="mt-4 w-full text-center text-sm text-blue-600 underline disabled:opacity-50 dark:text-blue-400"
|
|
>
|
|
{pinRequestLoading ? 'Wird gesendet…' : 'PIN vergessen? Host um Zurücksetzen bitten'}
|
|
</button>
|
|
{/if}
|
|
|
|
<p class="mt-4 text-center text-sm text-gray-500 dark:text-gray-400">
|
|
Noch kein Konto?
|
|
<a href="/join" class="text-blue-600 hover:underline dark:text-blue-400">Neu beitreten</a>
|
|
</p>
|
|
</div>
|
|
</div>
|