ee554e7f38
The backend had never been run through rustfmt. Doing it in one mechanical pass (134 files) so no future functional diff is buried under formatting churn, then gating `cargo fmt --check` in checks.yml so it stays clean. Formatting only — no logic, SQL, or behaviour changed. Verified after the reformat: cargo test 56 passed, clippy --all-targets -D warnings clean, cargo fmt --check clean. This is the deferred cleanup noted when CI's Format step was first left out. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
114 lines
3.9 KiB
YAML
114 lines
3.9 KiB
YAML
# The checks that were only ever running on a laptop.
|
|
#
|
|
# Before this file, CI ran Playwright (chromium-desktop) and the dependency audit — and nothing
|
|
# else. `cargo test` (40 tests), the frontend vitest suite (5 files, including the offline
|
|
# upload-queue and auth-token logic), svelte-check, and the e2e typecheck were all green on a
|
|
# developer's machine and gated NOTHING. A check that only ever runs locally is not running.
|
|
#
|
|
# In .github/workflows/ because Gitea Actions scans it too (see audit.yml). Rust is installed
|
|
# explicitly: the common Gitea runner images ship Node and Docker, not cargo.
|
|
name: Checks
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches: [main]
|
|
|
|
jobs:
|
|
backend:
|
|
name: Backend — cargo test + clippy + fmt
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- name: Install Rust toolchain
|
|
run: |
|
|
if ! command -v cargo > /dev/null; then
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
fi
|
|
rustup component add clippy rustfmt
|
|
|
|
- uses: actions/cache@v4
|
|
with:
|
|
path: |
|
|
~/.cargo/registry
|
|
~/.cargo/git
|
|
backend/target
|
|
key: cargo-${{ hashFiles('backend/Cargo.lock') }}
|
|
restore-keys: cargo-
|
|
|
|
# SQLx runs its queries against a live database at TEST time (see backend/tests/), so the
|
|
# DB-backed tests need one. The pure unit tests don't care, but starting it unconditionally
|
|
# keeps the job simple and honest about what it covers.
|
|
- name: Start Postgres
|
|
run: |
|
|
docker run -d --name ci-pg -p 5432:5432 \
|
|
-e POSTGRES_PASSWORD=postgres -e POSTGRES_DB=eventsnap_ci \
|
|
postgres:16-alpine
|
|
for _ in $(seq 1 30); do
|
|
docker exec ci-pg pg_isready -U postgres > /dev/null 2>&1 && break
|
|
sleep 1
|
|
done
|
|
|
|
- name: Test
|
|
working-directory: ./backend
|
|
env:
|
|
DATABASE_URL: postgres://postgres:postgres@localhost:5432/eventsnap_ci
|
|
# `#[sqlx::test]` creates a fresh database per test and opens its own pool; run at unbounded
|
|
# parallelism against a default `max_connections=100` Postgres, a full suite can exhaust the
|
|
# server's connection slots and fail with PoolTimedOut — a pure infra flake, not a real
|
|
# failure. Cap the concurrency so the gate stays trustworthy on a loaded runner.
|
|
run: cargo test --all-features -- --test-threads=8
|
|
|
|
- name: Clippy
|
|
working-directory: ./backend
|
|
run: cargo clippy --all-targets -- -D warnings
|
|
|
|
- name: Format
|
|
working-directory: ./backend
|
|
run: cargo fmt --check
|
|
|
|
frontend:
|
|
name: Frontend — vitest + svelte-check
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 15
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '22'
|
|
cache: 'npm'
|
|
cache-dependency-path: 'frontend/package-lock.json'
|
|
|
|
- name: Install deps
|
|
working-directory: ./frontend
|
|
run: npm ci || npm install
|
|
|
|
- name: Unit tests
|
|
working-directory: ./frontend
|
|
run: npm run test:unit
|
|
|
|
- name: svelte-check
|
|
working-directory: ./frontend
|
|
run: npx svelte-check --threshold error
|
|
|
|
e2e-typecheck:
|
|
name: E2E — typecheck
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '22'
|
|
- name: Install deps
|
|
working-directory: ./e2e
|
|
run: npm install
|
|
# Playwright TRANSPILES specs without typechecking them, so a type error in a spec is
|
|
# invisible until the assertion it guards silently does the wrong thing at runtime.
|
|
- name: tsc --noEmit
|
|
working-directory: ./e2e
|
|
run: npx tsc --noEmit
|