f8cba95e49
The frontend had no JS/TS linter — only svelte-check. Add flat-config ESLint (typescript-eslint
+ eslint-plugin-svelte) and Prettier (tabs/single-quote, matching the existing style).
Rules encode "catch bugs, not enforce taste":
- svelte/require-each-key KEPT — it is the exact bug class as the feed mis-tap fix. Fixed every
flagged block: keyed activeFilters, filteredUsers, stagedFiles (by previewUrl), captionTags,
admin tabs/jobs/users, the export-viewer suggestions/filters/comments, and the static skeleton
loops.
- svelte/prefer-svelte-reactivity KEPT — inline-disabled only the verified-safe sites (a local
freq Map in a $derived.by, throwaway URLSearchParams query builders), with a reason each.
- svelte/no-navigation-without-resolve OFF — wants resolve() around every goto()/href; taste, not
a bug, and pure churn.
- svelte/no-unused-svelte-ignore OFF — those comments are consumed by svelte-check, which ESLint
can't see, so it wrongly calls them unused; removing them would reintroduce a11y warnings.
- no-explicit-any OFF for *.test.ts only (partial fixtures legitimately use any).
Real code fixes beyond keys: removed a dead jobLabel(), an unused ViewerComment import and unused
catch binding, an unused scroll-lock arg, and replaced an empty interface with a type alias.
Then `prettier --write` (54 files). Formatting only. Verified: eslint clean, svelte-check 0 errors,
vitest 46 passed, vite build succeeds.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
51 lines
1.6 KiB
TypeScript
51 lines
1.6 KiB
TypeScript
// Body scroll-lock for open dialogs/sheets. While any locker is active, the
|
|
// document body can't scroll behind the overlay. Ref-counted so that nested or
|
|
// stacked dialogs (e.g. a ConfirmSheet opened from the LightboxModal) don't let
|
|
// the first one to close unlock the page out from under the others. Compensates
|
|
// for the vanished scrollbar width so the layout doesn't jump on lock.
|
|
|
|
import type { ActionReturn } from 'svelte/action';
|
|
|
|
let lockCount = 0;
|
|
let savedOverflow = '';
|
|
let savedPaddingRight = '';
|
|
|
|
function lock() {
|
|
if (typeof document === 'undefined') return;
|
|
if (lockCount === 0) {
|
|
const body = document.body;
|
|
const scrollbarWidth = window.innerWidth - document.documentElement.clientWidth;
|
|
savedOverflow = body.style.overflow;
|
|
savedPaddingRight = body.style.paddingRight;
|
|
body.style.overflow = 'hidden';
|
|
if (scrollbarWidth > 0) {
|
|
const current = parseFloat(getComputedStyle(body).paddingRight) || 0;
|
|
body.style.paddingRight = `${current + scrollbarWidth}px`;
|
|
}
|
|
}
|
|
lockCount++;
|
|
}
|
|
|
|
function unlock() {
|
|
if (typeof document === 'undefined') return;
|
|
lockCount = Math.max(0, lockCount - 1);
|
|
if (lockCount === 0) {
|
|
document.body.style.overflow = savedOverflow;
|
|
document.body.style.paddingRight = savedPaddingRight;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Locks body scroll for the lifetime of the node. Mount the node only while the
|
|
* dialog is open (e.g. inside `{#if open}` or alongside a `class:` toggle) so the
|
|
* action's create/destroy line up with open/close.
|
|
*/
|
|
export function scrollLock(_node: HTMLElement): ActionReturn {
|
|
lock();
|
|
return {
|
|
destroy() {
|
|
unlock();
|
|
}
|
|
};
|
|
}
|