f8cba95e49
The frontend had no JS/TS linter — only svelte-check. Add flat-config ESLint (typescript-eslint
+ eslint-plugin-svelte) and Prettier (tabs/single-quote, matching the existing style).
Rules encode "catch bugs, not enforce taste":
- svelte/require-each-key KEPT — it is the exact bug class as the feed mis-tap fix. Fixed every
flagged block: keyed activeFilters, filteredUsers, stagedFiles (by previewUrl), captionTags,
admin tabs/jobs/users, the export-viewer suggestions/filters/comments, and the static skeleton
loops.
- svelte/prefer-svelte-reactivity KEPT — inline-disabled only the verified-safe sites (a local
freq Map in a $derived.by, throwaway URLSearchParams query builders), with a reason each.
- svelte/no-navigation-without-resolve OFF — wants resolve() around every goto()/href; taste, not
a bug, and pure churn.
- svelte/no-unused-svelte-ignore OFF — those comments are consumed by svelte-check, which ESLint
can't see, so it wrongly calls them unused; removing them would reintroduce a11y warnings.
- no-explicit-any OFF for *.test.ts only (partial fixtures legitimately use any).
Real code fixes beyond keys: removed a dead jobLabel(), an unused ViewerComment import and unused
catch binding, an unused scroll-lock arg, and replaced an empty interface with a type alias.
Then `prettier --write` (54 files). Formatting only. Verified: eslint clean, svelte-check 0 errors,
vitest 46 passed, vite build succeeds.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
996 B
Svelte
39 lines
996 B
Svelte
<script lang="ts">
|
|
// Simplest transition: render whatever the parent gave us, full-bleed, with a CSS
|
|
// opacity fade. Tied to the parent's `{#key}` block — when the src changes, the
|
|
// parent re-mounts this component and the `in:` transition runs.
|
|
|
|
interface Props {
|
|
src: string;
|
|
isVideo: boolean;
|
|
durationMs: number;
|
|
/** Fired when a video slide finishes so the parent can advance early. */
|
|
onended?: () => void;
|
|
}
|
|
|
|
let { src, isVideo, durationMs, onended }: Props = $props();
|
|
</script>
|
|
|
|
<div
|
|
class="absolute inset-0 flex items-center justify-center bg-black"
|
|
style="animation: crossfade-in {durationMs}ms ease-out forwards;"
|
|
>
|
|
{#if isVideo}
|
|
<!-- svelte-ignore a11y_media_has_caption -->
|
|
<video {src} autoplay muted playsinline {onended} class="h-full w-full object-contain"></video>
|
|
{:else}
|
|
<img {src} alt="" class="h-full w-full object-contain" />
|
|
{/if}
|
|
</div>
|
|
|
|
<style>
|
|
@keyframes crossfade-in {
|
|
from {
|
|
opacity: 0;
|
|
}
|
|
to {
|
|
opacity: 1;
|
|
}
|
|
}
|
|
</style>
|