fabi/Mangalord
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: design system with light/dark themes and icon-first UI

Browse Source 
Adds a real design system to replace the per-route ad-hoc styling:

- docs/design-system.md is the contract. Semantic CSS custom-property
  tokens (color/type/spacing/radii/shadows/z-index) with verified WCAG
  AA/AAA contrast ratios for both themes.
- frontend/src/lib/styles/tokens.css defines :root tokens + a
  [data-theme="dark"] override + base element resets, a .form-field
  helper, and a global prefers-reduced-motion rule.
- frontend/src/lib/theme.svelte.ts is a Svelte 5 runes store backing
  the theme state machine (system | light | dark). localStorage key
  'mangalord-theme'; matchMedia subscription that re-resolves on OS
  theme change while in 'system' mode; init() / destroy() lifecycle
  wired from +layout.svelte.
- frontend/src/app.html runs a synchronous inline script before
  %sveltekit.head% to set [data-theme] before first paint. No FOUC.
- /settings gains a System / Light / Dark radiogroup (real fieldset +
  legend + radios with lucide icons).
- Every route's <style> block is rewritten to consume tokens — home,
  auth, upload (drop-zone + page list), bookmarks, manga overview,
  reader.
- @lucide/svelte icons replace ad-hoc text controls per the spec:
  Search (icon-only primary), LogOut (icon-only muted), Upload /
  Bookmarks / Settings nav inline icons, ChevronLeft/Right for the
  reader, ArrowUp/Down/Trash2 for the upload page list. The bookmark
  toggle keeps its '☆ Bookmark' / '★ Bookmarked' text verbatim.
- Home search controls split into two rows: input + Search CTA on
  row 1, Sort (and future filters) on row 2.

Accessibility: every icon-only button carries aria-label, every
decorative SVG aria-hidden; existing image alt text preserved;
focus-visible rings reach every interactive element including the
visually-hidden theme radios; color is never the sole conveyor.

Version bump 0.12.0 → 0.13.0 across backend/Cargo.toml and
frontend/package.json (feat: → minor per CLAUDE.md).

Bars: svelte-check 0/0, vitest 51/51, playwright 18/18, cargo test
88/88, clippy -D warnings clean. Two rounds of independent review;
verdict ship-ready.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-05-17 11:52:58 +02:00
parent f0e57b0615
commit 567d56bfa1
17 changed files with 1271 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

216
frontend/src/routes/upload/+page.svelte
View File

@@ -5,6 +5,11 @@
import { request } from '$lib/api/client';
import { session } from '$lib/session.svelte';
import { formatBytes, validateImageFile } from '$lib/upload-validation';
import ArrowUp from '@lucide/svelte/icons/arrow-up';
import ArrowDown from '@lucide/svelte/icons/arrow-down';
import Trash2 from '@lucide/svelte/icons/trash-2';
import UploadCloud from '@lucide/svelte/icons/upload-cloud';
import BookImage from '@lucide/svelte/icons/book-image';
let { data } = $props();
const mangas = $derived(data.mangas);
@@ -190,17 +195,17 @@
<h1>Upload</h1>
{#if !session.loaded}
<p data-testid="upload-loading">Loading…</p>
<p class="status" data-testid="upload-loading">Loading…</p>
{:else if !session.user}
<p data-testid="upload-signin">
<p class="status" data-testid="upload-signin">
<a href="/login">Sign in</a> to upload mangas or chapters.
</p>
{:else}
<section class="card">
<h2>Create manga</h2>
<form onsubmit={submitManga} action="javascript:void(0)" data-testid="manga-form">
<label>
Title <span aria-hidden="true">*</span>
<label class="form-field">
<span>Title <span aria-hidden="true">*</span></span>
<input
type="text"
bind:value={mangaTitle}
@@ -212,8 +217,8 @@
<span class="field-error" role="alert">{mangaFieldErrors.title}</span>
{/if}
</label>
<label>
Author
<label class="form-field">
<span>Author</span>
<input
type="text"
bind:value={mangaAuthor}
@@ -221,16 +226,16 @@
data-testid="manga-author"
/>
</label>
<label>
Description
<label class="form-field">
<span>Description</span>
<textarea
bind:value={mangaDescription}
rows="4"
data-testid="manga-description"
></textarea>
</label>
<label>
Cover (optional)
<label class="form-field">
<span>Cover (optional)</span>
<input
type="file"
accept="image/*"
@@ -244,7 +249,7 @@
<span class="field-error" role="alert">{coverError}</span>
{/if}
</label>
<button type="submit" disabled={!canSubmitManga} data-testid="manga-submit">
<button class="primary" type="submit" disabled={!canSubmitManga} data-testid="manga-submit">
{mangaSubmitting ? 'Creating…' : 'Create manga'}
</button>
{#if mangaSuccess}
@@ -259,7 +264,7 @@
<section class="card">
<h2>Upload chapter</h2>
{#if mangas.length === 0}
<p data-testid="chapter-no-mangas">
<p class="status" data-testid="chapter-no-mangas">
No mangas yet — create one above first.
</p>
{:else}
@@ -268,8 +273,8 @@
action="javascript:void(0)"
data-testid="chapter-form"
>
<label>
Manga <span aria-hidden="true">*</span>
<label class="form-field">
<span>Manga <span aria-hidden="true">*</span></span>
<select
bind:value={chapterMangaId}
required
@@ -293,7 +298,9 @@
loading="lazy"
/>
{:else}
<span class="preview-cover preview-cover-placeholder" aria-hidden="true">📖</span>
<span class="preview-cover preview-cover-placeholder" aria-hidden="true">
<BookImage size={22} aria-hidden="true" />
</span>
{/if}
<div class="preview-meta">
<span class="preview-title">{selectedManga.title}</span>
@@ -303,8 +310,8 @@
</div>
</div>
{/if}
<label>
Chapter number <span aria-hidden="true">*</span>
<label class="form-field">
<span>Chapter number <span aria-hidden="true">*</span></span>
<input
type="number"
min="1"
@@ -314,8 +321,8 @@
data-testid="chapter-number"
/>
</label>
<label>
Title (optional)
<label class="form-field">
<span>Title (optional)</span>
<input
type="text"
bind:value={chapterTitle}
@@ -334,6 +341,7 @@
aria-label="page upload"
data-testid="drop-zone"
>
<UploadCloud size={32} aria-hidden="true" class="drop-icon" />
<p>
Drop pages here, or
<label class="file-link">
@@ -356,28 +364,34 @@
<span class="page-name">{p.file.name}</span>
<span class="page-size">{formatBytes(p.file.size)}</span>
<button
class="icon-btn"
type="button"
onclick={() => movePage(p.id, -1)}
disabled={i === 0}
aria-label="Move up"
title="Move up"
>
↑
<ArrowUp size={16} aria-hidden="true" />
</button>
<button
class="icon-btn"
type="button"
onclick={() => movePage(p.id, 1)}
disabled={i === chapterPages.length - 1}
aria-label="Move down"
title="Move down"
>
↓
<ArrowDown size={16} aria-hidden="true" />
</button>
<button
class="icon-btn danger"
type="button"
onclick={() => removePage(p.id)}
aria-label="Remove"
aria-label="Remove page"
title="Remove page"
data-testid="page-remove"
>
Remove
<Trash2 size={16} aria-hidden="true" />
</button>
{#if p.error}
<span class="field-error" role="alert">{p.error}</span>
@@ -388,6 +402,7 @@
{/if}
<button
class="primary"
type="submit"
disabled={!canSubmitChapter}
data-testid="chapter-submit"
@@ -408,113 +423,182 @@
{/if}
<style>
.card {
border: 1px solid #ddd;
border-radius: 6px;
padding: 1rem;
margin-bottom: 1rem;
.status {
color: var(--text-muted);
}
.card {
background: var(--surface);
border: 1px solid var(--border);
border-radius: var(--radius-md);
padding: var(--space-4);
margin-bottom: var(--space-4);
}
form {
display: flex;
flex-direction: column;
gap: 0.75rem;
gap: var(--space-3);
}
label {
display: flex;
flex-direction: column;
gap: 0.25rem;
.primary {
background: var(--primary);
color: var(--primary-contrast);
border-color: var(--primary);
margin-top: var(--space-1);
align-self: flex-start;
}
.primary:hover:not(:disabled) {
background: var(--primary-hover);
border-color: var(--primary-hover);
}
.hint {
color: #666;
font-size: 0.9rem;
color: var(--text-muted);
font-size: var(--font-sm);
}
.field-error {
color: #b00020;
font-size: 0.9rem;
color: var(--danger);
font-size: var(--font-sm);
}
.form-error {
color: #b00020;
color: var(--danger);
}
.success {
color: #0a7d2c;
color: var(--success);
}
.manga-preview {
display: flex;
align-items: center;
gap: 0.75rem;
padding: 0.5rem;
border: 1px solid #eee;
border-radius: 4px;
background: #fafafa;
gap: var(--space-3);
padding: var(--space-2);
border: 1px solid var(--border);
border-radius: var(--radius-md);
background: var(--surface-elevated);
}
.preview-cover {
width: 48px;
height: 72px;
object-fit: cover;
border-radius: 3px;
background: #f0f0f0;
border-radius: var(--radius-sm);
background: var(--surface);
flex-shrink: 0;
}
.preview-cover-placeholder {
display: inline-flex;
align-items: center;
justify-content: center;
font-size: 1.5rem;
color: #999;
color: var(--text-muted);
}
.preview-meta {
display: flex;
flex-direction: column;
min-width: 0;
}
.preview-title {
font-weight: 600;
font-weight: var(--weight-semibold);
color: var(--text);
}
.preview-author {
color: #777;
font-size: 0.85rem;
color: var(--text-muted);
font-size: var(--font-sm);
}
.drop-zone {
border: 2px dashed #aaa;
border-radius: 6px;
padding: 1.5rem;
display: flex;
flex-direction: column;
align-items: center;
gap: var(--space-2);
border: 2px dashed var(--border-strong);
border-radius: var(--radius-md);
padding: var(--space-6);
text-align: center;
background: #fafafa;
background: var(--surface);
color: var(--text-muted);
transition:
background var(--transition),
border-color var(--transition);
}
.drop-zone :global(.drop-icon) {
color: var(--text-muted);
}
.drop-zone.drag-over {
background: #eef6ff;
border-color: #06f;
background: var(--primary-soft-bg);
border-color: var(--primary);
}
.file-link input[type='file'] {
display: none;
}
.file-link {
color: #06f;
color: var(--primary);
text-decoration: underline;
cursor: pointer;
}
.pages {
padding: 0;
margin: 0;
list-style: decimal inside;
}
.pages li {
display: flex;
align-items: center;
gap: 0.5rem;
padding: 0.25rem 0;
border-bottom: 1px solid #eee;
gap: var(--space-2);
padding: var(--space-1) var(--space-2);
border-bottom: 1px solid var(--border);
}
.pages li.invalid {
background: #fff5f5;
background: var(--danger-soft-bg);
}
.page-name {
flex: 1;
min-width: 0;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
.page-size {
color: #777;
color: var(--text-muted);
font-size: var(--font-sm);
}
button:focus-visible {
outline: 2px solid #06f;
outline-offset: 2px;
.icon-btn {
display: inline-flex;
align-items: center;
justify-content: center;
width: 32px;
height: 32px;
padding: 0;
background: transparent;
color: var(--text-muted);
border: 1px solid transparent;
border-radius: var(--radius-sm);
}
.icon-btn:hover:not(:disabled) {
background: var(--surface-elevated);
color: var(--text);
}
.icon-btn.danger:hover:not(:disabled) {
color: var(--danger);
}
</style>