feat: author pages with /authors/:id route (0.16.0)

- `GET /v1/authors/:id` returns `AuthorWithCount` (id, name, manga_count). - `GET /v1/authors/:id/mangas` paged works by that author. - `GET /v1/authors?search=` autocomplete (already used by Phase 1 forms; now formally exposed). - New `/authors/:id` page on the frontend; author chips on the manga detail page (added in Phase 1) now link to a real page. - Extracts `lib/components/MangaCard.svelte` — already used by the home page, ready for the collection page in Phase 3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 14:39:11 +02:00
parent 59d380b6d7
commit 5e92a2c450
12 changed files with 739 additions and 96 deletions
--- a/frontend/src/lib/api/authors.test.ts
+++ b/frontend/src/lib/api/authors.test.ts
@@ -0,0 +1,91 @@
+import { describe, it, expect, vi, beforeEach, afterEach, type MockInstance } from 'vitest';
+import { listAuthors, getAuthor, listAuthorMangas } from './authors';
+
+function ok(body: unknown, status = 200): Response {
+    return new Response(JSON.stringify(body), {
+        status,
+        headers: { 'content-type': 'application/json' }
+    });
+}
+
+function envelope(status: number, code: string, message: string): Response {
+    return new Response(JSON.stringify({ error: { code, message } }), {
+        status,
+        headers: { 'content-type': 'application/json' }
+    });
+}
+
+describe('authors api client', () => {
+    let fetchSpy: MockInstance<typeof globalThis.fetch>;
+
+    beforeEach(() => {
+        fetchSpy = vi.spyOn(globalThis, 'fetch');
+    });
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+
+    it('listAuthors GETs /v1/authors with no params by default', async () => {
+        fetchSpy.mockResolvedValueOnce(ok([]));
+        await listAuthors();
+        const url = fetchSpy.mock.calls[0][0] as string;
+        expect(url).toMatch(/\/v1\/authors$/);
+    });
+
+    it('listAuthors encodes search, limit, offset', async () => {
+        fetchSpy.mockResolvedValueOnce(ok([]));
+        await listAuthors({ search: 'miura', limit: 5, offset: 0 });
+        const url = fetchSpy.mock.calls[0][0] as string;
+        expect(url).toContain('search=miura');
+        expect(url).toContain('limit=5');
+        expect(url).toContain('offset=0');
+    });
+
+    it('getAuthor returns the AuthorWithCount shape', async () => {
+        fetchSpy.mockResolvedValueOnce(
+            ok({
+                id: 'a1',
+                name: 'Kentaro Miura',
+                created_at: '2026-01-01T00:00:00Z',
+                manga_count: 3
+            })
+        );
+        const a = await getAuthor('a1');
+        expect(a.name).toBe('Kentaro Miura');
+        expect(a.manga_count).toBe(3);
+    });
+
+    it('getAuthor surfaces 404 as ApiError', async () => {
+        fetchSpy.mockResolvedValueOnce(envelope(404, 'not_found', 'not found'));
+        await expect(getAuthor('missing')).rejects.toMatchObject({
+            status: 404,
+            code: 'not_found'
+        });
+    });
+
+    it('listAuthorMangas hits the nested route and forwards pagination', async () => {
+        fetchSpy.mockResolvedValueOnce(
+            ok({
+                items: [
+                    {
+                        id: 'm1',
+                        title: 'Berserk',
+                        status: 'ongoing',
+                        alt_titles: [],
+                        description: null,
+                        cover_image_path: null,
+                        created_at: '2026-01-01T00:00:00Z',
+                        updated_at: '2026-01-01T00:00:00Z'
+                    }
+                ],
+                page: { limit: 50, offset: 0, total: 1 }
+            })
+        );
+        const result = await listAuthorMangas('a1', { limit: 20, offset: 10 });
+        expect(result.items[0].title).toBe('Berserk');
+        const url = fetchSpy.mock.calls[0][0] as string;
+        expect(url).toMatch(/\/v1\/authors\/a1\/mangas\?/);
+        expect(url).toContain('limit=20');
+        expect(url).toContain('offset=10');
+    });
+});
--- a/frontend/src/lib/api/authors.ts
+++ b/frontend/src/lib/api/authors.ts
@@ -0,0 +1,56 @@
+import { request, type Page } from './client';
+import type { Manga } from './client';
+
+export type Author = {
+    id: string;
+    name: string;
+    created_at: string;
+};
+
+/** Returned by `GET /v1/authors/:id` — adds the count of attached mangas. */
+export type AuthorWithCount = Author & {
+    manga_count: number;
+};
+
+export type AuthorMangasPage = {
+    items: Manga[];
+    page: Page;
+};
+
+export type ListAuthorsOptions = {
+    search?: string;
+    limit?: number;
+    offset?: number;
+};
+
+export type ListAuthorMangasOptions = {
+    limit?: number;
+    offset?: number;
+};
+
+/** Autocomplete for author pickers. Server sorts by trigram similarity. */
+export async function listAuthors(opts: ListAuthorsOptions = {}): Promise<Author[]> {
+    const params = new URLSearchParams();
+    if (opts.search) params.set('search', opts.search);
+    if (opts.limit != null) params.set('limit', String(opts.limit));
+    if (opts.offset != null) params.set('offset', String(opts.offset));
+    const qs = params.toString();
+    return request<Author[]>(`/v1/authors${qs ? `?${qs}` : ''}`);
+}
+
+export async function getAuthor(id: string): Promise<AuthorWithCount> {
+    return request<AuthorWithCount>(`/v1/authors/${encodeURIComponent(id)}`);
+}
+
+export async function listAuthorMangas(
+    id: string,
+    opts: ListAuthorMangasOptions = {}
+): Promise<AuthorMangasPage> {
+    const params = new URLSearchParams();
+    if (opts.limit != null) params.set('limit', String(opts.limit));
+    if (opts.offset != null) params.set('offset', String(opts.offset));
+    const qs = params.toString();
+    return request<AuthorMangasPage>(
+        `/v1/authors/${encodeURIComponent(id)}/mangas${qs ? `?${qs}` : ''}`
+    );
+}
--- a/frontend/src/lib/components/MangaCard.svelte
+++ b/frontend/src/lib/components/MangaCard.svelte
@@ -0,0 +1,107 @@
+<script lang="ts">
+    import { fileUrl } from '$lib/api/client';
+    import type { Manga } from '$lib/api/client';
+    import type { AuthorRef, GenreRef } from '$lib/api/mangas';
+    import BookImage from '@lucide/svelte/icons/book-image';
+
+    let {
+        manga,
+        authors = [],
+        genres = [],
+        testid
+    }: {
+        manga: Manga;
+        authors?: AuthorRef[];
+        genres?: GenreRef[];
+        testid?: string;
+    } = $props();
+</script>
+
+<li class="manga-card" data-testid={testid}>
+    <a href="/manga/{manga.id}" class="cover-link" aria-hidden="true" tabindex="-1">
+        {#if manga.cover_image_path}
+            <img
+                src={fileUrl(manga.cover_image_path)}
+                alt=""
+                class="cover"
+                loading="lazy"
+            />
+        {:else}
+            <div class="cover cover-placeholder">
+                <BookImage size={36} aria-hidden="true" />
+            </div>
+        {/if}
+    </a>
+    <div class="meta">
+        <a href="/manga/{manga.id}" class="title">{manga.title}</a>
+        {#if authors.length > 0}
+            <span class="author">{authors.map((a) => a.name).join(', ')}</span>
+        {/if}
+        {#if genres.length > 0}
+            <span class="genres">{genres.map((g) => g.name).join(' · ')}</span>
+        {/if}
+    </div>
+</li>
+
+<style>
+    .manga-card {
+        display: flex;
+        flex-direction: column;
+        gap: var(--space-2);
+        list-style: none;
+    }
+
+    .cover-link {
+        display: block;
+        line-height: 0;
+    }
+
+    .cover {
+        width: 100%;
+        aspect-ratio: 2 / 3;
+        object-fit: cover;
+        border-radius: var(--radius-md);
+        background: var(--surface);
+    }
+
+    .cover-placeholder {
+        display: flex;
+        align-items: center;
+        justify-content: center;
+        color: var(--text-muted);
+        user-select: none;
+    }
+
+    .meta {
+        display: flex;
+        flex-direction: column;
+        min-width: 0;
+        gap: var(--space-1);
+    }
+
+    .title {
+        font-weight: var(--weight-semibold);
+        font-size: var(--font-sm);
+        line-height: var(--leading-tight);
+        color: var(--text);
+        overflow: hidden;
+        display: -webkit-box;
+        -webkit-line-clamp: 2;
+        line-clamp: 2;
+        -webkit-box-orient: vertical;
+    }
+
+    .title:hover {
+        color: var(--primary);
+        text-decoration: none;
+    }
+
+    .author,
+    .genres {
+        color: var(--text-muted);
+        font-size: var(--font-xs);
+        white-space: nowrap;
+        overflow: hidden;
+        text-overflow: ellipsis;
+    }
+</style>
--- a/frontend/src/routes/+page.svelte
+++ b/frontend/src/routes/+page.svelte
@@ -5,20 +5,19 @@
    import { page } from '$app/stores';
    import {
        listMangas,
-        type MangaCard,
+        type MangaCard as MangaCardData,
        type MangaSort,
        type MangaStatus
    } from '$lib/api/mangas';
    import { listGenres, type Genre } from '$lib/api/genres';
    import { listTags, type Tag } from '$lib/api/tags';
-    import { fileUrl } from '$lib/api/client';
    import Chip from '$lib/components/Chip.svelte';
+    import MangaCard from '$lib/components/MangaCard.svelte';
    import Search from '@lucide/svelte/icons/search';
-    import BookImage from '@lucide/svelte/icons/book-image';
    import SlidersHorizontal from '@lucide/svelte/icons/sliders-horizontal';
    import Plus from '@lucide/svelte/icons/plus';

-    let mangas: MangaCard[] = $state([]);
+    let mangas: MangaCardData[] = $state([]);
    let search = $state('');
    let sort: MangaSort = $state('recent');
    let statusFilter = $state<'' | MangaStatus>('');
@@ -389,35 +388,7 @@
    {/if}
    <ul class="manga-grid" data-testid="manga-list">
        {#each mangas as m (m.id)}
-            <li class="manga-card">
-                <a href="/manga/{m.id}" class="cover-link" aria-hidden="true" tabindex="-1">
-                    {#if m.cover_image_path}
-                        <img
-                            src={fileUrl(m.cover_image_path)}
-                            alt=""
-                            class="cover"
-                            loading="lazy"
-                        />
-                    {:else}
-                        <div class="cover cover-placeholder">
-                            <BookImage size={36} aria-hidden="true" />
-                        </div>
-                    {/if}
-                </a>
-                <div class="meta">
-                    <a href="/manga/{m.id}" class="title">{m.title}</a>
-                    {#if m.authors.length > 0}
-                        <span class="author">
-                            {m.authors.map((a) => a.name).join(', ')}
-                        </span>
-                    {/if}
-                    {#if m.genres.length > 0}
-                        <span class="genres">
-                            {m.genres.map((g) => g.name).join(' · ')}
-                        </span>
-                    {/if}
-                </div>
-            </li>
+            <MangaCard manga={m} authors={m.authors} genres={m.genres} />
        {/each}
    </ul>
 {/if}
@@ -648,64 +619,4 @@
        grid-template-columns: repeat(auto-fill, minmax(140px, 1fr));
        gap: var(--space-4);
    }
-
-    .manga-card {
-        display: flex;
-        flex-direction: column;
-        gap: var(--space-2);
-    }
-
-    .cover-link {
-        display: block;
-        line-height: 0;
-    }
-
-    .cover {
-        width: 100%;
-        aspect-ratio: 2 / 3;
-        object-fit: cover;
-        border-radius: var(--radius-md);
-        background: var(--surface);
-    }
-
-    .cover-placeholder {
-        display: flex;
-        align-items: center;
-        justify-content: center;
-        color: var(--text-muted);
-        user-select: none;
-    }
-
-    .meta {
-        display: flex;
-        flex-direction: column;
-        min-width: 0;
-        gap: var(--space-1);
-    }
-
-    .title {
-        font-weight: var(--weight-semibold);
-        font-size: var(--font-sm);
-        line-height: var(--leading-tight);
-        color: var(--text);
-        overflow: hidden;
-        display: -webkit-box;
-        -webkit-line-clamp: 2;
-        line-clamp: 2;
-        -webkit-box-orient: vertical;
-    }
-
-    .title:hover {
-        color: var(--primary);
-        text-decoration: none;
-    }
-
-    .author,
-    .genres {
-        color: var(--text-muted);
-        font-size: var(--font-xs);
-        white-space: nowrap;
-        overflow: hidden;
-        text-overflow: ellipsis;
-    }
 </style>
--- a/frontend/src/routes/authors/[id]/+page.svelte
+++ b/frontend/src/routes/authors/[id]/+page.svelte
@@ -0,0 +1,96 @@
+<script lang="ts">
+    import MangaCard from '$lib/components/MangaCard.svelte';
+    import ArrowLeft from '@lucide/svelte/icons/arrow-left';
+
+    let { data } = $props();
+    const author = $derived(data.author);
+    const mangas = $derived(data.mangas);
+    const total = $derived(data.total);
+</script>
+
+<svelte:head>
+    <title>{author.name} — Mangalord</title>
+</svelte:head>
+
+<nav class="back">
+    <a href="/" class="back-link">
+        <ArrowLeft size={16} aria-hidden="true" />
+        <span>Back to search</span>
+    </a>
+</nav>
+
+<header class="overview">
+    <h1 data-testid="author-name">{author.name}</h1>
+    <p class="count" data-testid="author-manga-count">
+        {author.manga_count}
+        {author.manga_count === 1 ? 'work' : 'works'}
+    </p>
+</header>
+
+{#if mangas.length === 0}
+    <p class="status" data-testid="author-no-mangas">
+        No mangas attributed to this author.
+    </p>
+{:else}
+    {#if total != null}
+        <p class="meta" data-testid="author-shown-of-total">
+            Showing {mangas.length} of {total}
+        </p>
+    {/if}
+    <ul class="manga-grid" data-testid="author-manga-list">
+        {#each mangas as m (m.id)}
+            <MangaCard manga={m} testid={`author-manga-${m.id}`} />
+        {/each}
+    </ul>
+{/if}
+
+<style>
+    .back {
+        margin-bottom: var(--space-3);
+    }
+
+    .back-link {
+        display: inline-flex;
+        align-items: center;
+        gap: var(--space-1);
+        color: var(--text-muted);
+        font-size: var(--font-sm);
+    }
+
+    .back-link:hover {
+        color: var(--primary);
+        text-decoration: none;
+    }
+
+    .overview {
+        margin-bottom: var(--space-5);
+    }
+
+    .overview h1 {
+        margin: 0 0 var(--space-1);
+    }
+
+    .count {
+        color: var(--text-muted);
+        margin: 0 0 var(--space-2);
+    }
+
+    .meta {
+        color: var(--text-muted);
+        font-size: var(--font-sm);
+        margin: 0 0 var(--space-3);
+    }
+
+    .status {
+        color: var(--text-muted);
+    }
+
+    .manga-grid {
+        list-style: none;
+        padding: 0;
+        margin: 0;
+        display: grid;
+        grid-template-columns: repeat(auto-fill, minmax(140px, 1fr));
+        gap: var(--space-4);
+    }
+</style>
--- a/frontend/src/routes/authors/[id]/+page.ts
+++ b/frontend/src/routes/authors/[id]/+page.ts
@@ -0,0 +1,24 @@
+import { error } from '@sveltejs/kit';
+import { ApiError } from '$lib/api/client';
+import { getAuthor, listAuthorMangas } from '$lib/api/authors';
+import type { PageLoad } from './$types';
+
+export const ssr = false;
+
+export const load: PageLoad = async ({ params }) => {
+    try {
+        const [author, mangas] = await Promise.all([
+            getAuthor(params.id),
+            listAuthorMangas(params.id, { limit: 50 })
+        ]);
+        return { author, mangas: mangas.items, total: mangas.page.total };
+    } catch (e) {
+        // 404 surfaces as a real SvelteKit error so the framework shell
+        // renders the standard not-found page instead of the route's
+        // happy-path markup with undefined data.
+        if (e instanceof ApiError && e.status === 404) {
+            error(404, 'Author not found');
+        }
+        throw e;
+    }
+};