fix(mangas): address review on sort feature — alias, index, validation, a11y

Backend
- sort=recent stays a back-compat alias for created (parse_sort); invalid
  sort/order now return the structured 422 envelope instead of plain-text 400
- per-field default direction on omitted order (dates desc, text asc), matching
  the frontend so a bare ?sort=<field> reads the same in UI and API
- migration 0033: index mangas(updated_at DESC, id) backing the default sort
  and its id tie-break; NULLS LAST now applied only to the nullable author key
- tests: recent alias, per-field default (title+author), invalid-value 422,
  and a tie-break test that pins ordering by ascending id (mutation-verified)

Frontend
- pure sort helpers extracted to $lib/mangaSort with unit tests; coerceSort
  honors the recent alias so pasted/legacy URLs resolve to the same field
- SegmentedControl: roving tabindex + arrow/Home/End keyboard nav, anchored on
  focus so rapid keypresses don't stick
- UX: visible "Direction" labels (desktop + mobile), mobile sort-sheet section
  headings and a "Done" button; README sort/order contract updated

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-06-25 07:15:33 +02:00
parent 1079a0151a
commit 78edea4277
11 changed files with 650 additions and 73 deletions

View File

@@ -1,5 +1,5 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { render, screen, cleanup } from '@testing-library/svelte';
import { render, screen, cleanup, fireEvent } from '@testing-library/svelte';
import SegmentedControl from './SegmentedControl.svelte';
afterEach(() => cleanup());
@@ -50,4 +50,74 @@ describe('SegmentedControl', () => {
});
expect(screen.getByRole('radiogroup', { name: 'Library tab' })).toBeTruthy();
});
it('gives the selected option a roving tabindex of 0 and the rest -1', () => {
render(SegmentedControl, {
props: { options: opts, value: 'collections', onchange: () => {}, ariaLabel: 'Library tab' }
});
expect(screen.getByRole('radio', { name: 'Collections' }).getAttribute('tabindex')).toBe('0');
expect(screen.getByRole('radio', { name: 'Bookmarks' }).getAttribute('tabindex')).toBe('-1');
expect(screen.getByRole('radio', { name: 'History' }).getAttribute('tabindex')).toBe('-1');
});
it('selects the next option on ArrowRight/ArrowDown (selection follows focus)', async () => {
const onchange = vi.fn();
render(SegmentedControl, {
props: { options: opts, value: 'bookmarks', onchange, ariaLabel: 'Library tab' }
});
const group = screen.getByRole('radiogroup', { name: 'Library tab' });
const first = screen.getByRole('radio', { name: 'Bookmarks' });
first.focus();
await fireEvent.keyDown(group, { key: 'ArrowRight' });
expect(onchange).toHaveBeenCalledWith('collections');
onchange.mockClear();
// Re-anchor on the first option to assert ArrowDown behaves the same.
first.focus();
await fireEvent.keyDown(group, { key: 'ArrowDown' });
expect(onchange).toHaveBeenCalledWith('collections');
});
it('wraps from the first option to the last on ArrowLeft', async () => {
const onchange = vi.fn();
render(SegmentedControl, {
props: { options: opts, value: 'bookmarks', onchange, ariaLabel: 'Library tab' }
});
await fireEvent.keyDown(screen.getByRole('radiogroup', { name: 'Library tab' }), {
key: 'ArrowLeft'
});
expect(onchange).toHaveBeenCalledWith('history');
});
it('jumps to the first/last option with Home/End', async () => {
const onchange = vi.fn();
render(SegmentedControl, {
props: { options: opts, value: 'collections', onchange, ariaLabel: 'Library tab' }
});
const group = screen.getByRole('radiogroup', { name: 'Library tab' });
await fireEvent.keyDown(group, { key: 'Home' });
expect(onchange).toHaveBeenCalledWith('bookmarks');
onchange.mockClear();
await fireEvent.keyDown(group, { key: 'End' });
expect(onchange).toHaveBeenCalledWith('history');
});
// Navigation anchors on the focused button, not the (parent-controlled,
// lagging) `value` prop: even when `value` never updates, consecutive
// ArrowRights fired on the focused child advance step by step. This pins
// both the keydown-bubbles-from-child path and the no-stick behavior.
it('advances step by step on consecutive ArrowRights, following focus', async () => {
const onchange = vi.fn();
render(SegmentedControl, {
props: { options: opts, value: 'bookmarks', onchange, ariaLabel: 'Library tab' }
});
screen.getByRole('radio', { name: 'Bookmarks' }).focus();
await fireEvent.keyDown(document.activeElement as Element, { key: 'ArrowRight' });
expect(onchange).toHaveBeenLastCalledWith('collections');
expect((document.activeElement as HTMLElement).textContent?.trim()).toBe('Collections');
// `value` is still 'bookmarks' (vi.fn never feeds it back), yet the next
// press lands on the third option because it anchors on focus.
await fireEvent.keyDown(document.activeElement as Element, { key: 'ArrowRight' });
expect(onchange).toHaveBeenLastCalledWith('history');
expect((document.activeElement as HTMLElement).textContent?.trim()).toBe('History');
});
});