Operators whose sources shard images across numbered CDN subdomains can't pre-enumerate every host in CRAWLER_DOWNLOAD_ALLOWLIST. The new flag short-circuits the host check in DownloadAllowlist::contains while leaving scheme, localhost, and private-IP defenses in is_safe_url untouched — scraped URLs pointing at 10.x / 169.254.169.254 / file:// stay refused. Default is false; fail-closed posture is preserved unless the operator opts in. Wired into both the server (config::build_download_allowlist) and the bin/crawler.rs one-shot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
313 lines
12 KiB
Rust
313 lines
12 KiB
Rust
use std::path::PathBuf;
|
|
use std::time::Duration;
|
|
|
|
use chrono::NaiveTime;
|
|
use chrono_tz::Tz;
|
|
|
|
use crate::crawler::browser::LaunchOptions;
|
|
use crate::crawler::safety::{DownloadAllowlist, DEFAULT_MAX_IMAGE_BYTES};
|
|
|
|
#[derive(Clone, Debug)]
|
|
pub struct AuthConfig {
|
|
pub cookie_secure: bool,
|
|
pub cookie_domain: Option<String>,
|
|
pub session_ttl_days: i64,
|
|
pub rate_limit: crate::auth::rate_limit::RateLimitConfig,
|
|
/// When `false`, `POST /auth/register` returns 403
|
|
/// `registration_disabled` and the frontend hides its register
|
|
/// affordance. Admins can still mint accounts via
|
|
/// `POST /admin/users`. Defaults to `true` (open registration)
|
|
/// for backward compatibility.
|
|
pub allow_self_register: bool,
|
|
}
|
|
|
|
impl Default for AuthConfig {
|
|
fn default() -> Self {
|
|
Self {
|
|
cookie_secure: true,
|
|
cookie_domain: None,
|
|
session_ttl_days: 30,
|
|
// Disabled by default so the test harness inherits a
|
|
// non-throttling limiter. Production `from_env` overrides
|
|
// to the [`PRODUCTION_PER_SEC`]/[`PRODUCTION_BURST`]
|
|
// defaults.
|
|
rate_limit: crate::auth::rate_limit::RateLimitConfig::default(),
|
|
allow_self_register: true,
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Debug)]
|
|
pub struct UploadConfig {
|
|
/// Total request size cap, enforced by axum's DefaultBodyLimit on the
|
|
/// upload routes. Rejected requests get a 413.
|
|
pub max_request_bytes: usize,
|
|
/// Per-image-part size cap, enforced after the part is read. Lets us
|
|
/// reject a single oversized cover/page without failing the whole
|
|
/// request just because the total happens to fit.
|
|
pub max_file_bytes: usize,
|
|
}
|
|
|
|
impl Default for UploadConfig {
|
|
fn default() -> Self {
|
|
Self {
|
|
max_request_bytes: 200 * 1024 * 1024, // 200 MiB
|
|
max_file_bytes: 20 * 1024 * 1024, // 20 MiB
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Debug)]
|
|
pub struct Config {
|
|
pub database_url: String,
|
|
pub bind_address: String,
|
|
pub storage_dir: PathBuf,
|
|
pub auth: AuthConfig,
|
|
pub upload: UploadConfig,
|
|
pub cors_allowed_origins: Vec<String>,
|
|
pub crawler: CrawlerConfig,
|
|
/// `(username, password)` for the admin user provisioned at startup
|
|
/// when both `ADMIN_USERNAME` and `ADMIN_PASSWORD` are set. `None`
|
|
/// skips the bootstrap entirely. See `repo::user::bootstrap_admin`
|
|
/// for the create-vs-promote semantics — notably the password here
|
|
/// is used only when creating a new row, never to overwrite an
|
|
/// existing one.
|
|
pub admin_bootstrap: Option<(String, String)>,
|
|
}
|
|
|
|
/// All crawler-daemon knobs read from env. Mirrors the env vars the
|
|
/// `bin/crawler` binary already reads, plus the new daemon-only knobs
|
|
/// (daily_at, tz, idle_timeout, retention_days, daemon_enabled).
|
|
///
|
|
/// `daemon_enabled = false` skips the daemon spawn entirely — used by
|
|
/// integration tests and dev runs that don't want background activity.
|
|
#[derive(Clone, Debug)]
|
|
pub struct CrawlerConfig {
|
|
pub daemon_enabled: bool,
|
|
pub daily_at: NaiveTime,
|
|
pub tz: Tz,
|
|
pub idle_timeout: Duration,
|
|
pub chapter_workers: usize,
|
|
pub retention_days: u32,
|
|
pub start_url: Option<String>,
|
|
pub rate_ms: u64,
|
|
pub cdn_host: Option<String>,
|
|
pub cdn_rate_ms: u64,
|
|
pub phpsessid: Option<String>,
|
|
pub cookie_domain: Option<String>,
|
|
pub user_agent: Option<String>,
|
|
pub proxy: Option<String>,
|
|
pub browser: LaunchOptions,
|
|
/// Hosts the crawler is allowed to download images / covers from.
|
|
/// Always seeded with the host of `start_url` and (when set) the
|
|
/// configured `cdn_host`. Additional hosts can be added via
|
|
/// `CRAWLER_DOWNLOAD_ALLOWLIST` (comma-separated).
|
|
pub download_allowlist: DownloadAllowlist,
|
|
/// Hard upper bound on a single image download. Defaults to 32 MiB.
|
|
pub max_image_bytes: usize,
|
|
}
|
|
|
|
impl Default for CrawlerConfig {
|
|
fn default() -> Self {
|
|
Self {
|
|
daemon_enabled: false,
|
|
daily_at: NaiveTime::from_hms_opt(0, 0, 0).unwrap(),
|
|
tz: Tz::UTC,
|
|
idle_timeout: Duration::from_secs(600),
|
|
chapter_workers: 1,
|
|
retention_days: 7,
|
|
start_url: None,
|
|
rate_ms: 1000,
|
|
cdn_host: None,
|
|
cdn_rate_ms: 1000,
|
|
phpsessid: None,
|
|
cookie_domain: None,
|
|
user_agent: None,
|
|
proxy: None,
|
|
browser: LaunchOptions::headless(),
|
|
download_allowlist: DownloadAllowlist::new(),
|
|
max_image_bytes: DEFAULT_MAX_IMAGE_BYTES,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Config {
|
|
pub fn from_env() -> anyhow::Result<Self> {
|
|
Ok(Self {
|
|
database_url: std::env::var("DATABASE_URL")
|
|
.map_err(|_| anyhow::anyhow!("DATABASE_URL must be set"))?,
|
|
bind_address: std::env::var("BIND_ADDRESS")
|
|
.unwrap_or_else(|_| "0.0.0.0:8080".to_string()),
|
|
storage_dir: std::env::var("STORAGE_DIR")
|
|
.unwrap_or_else(|_| "./data/storage".to_string())
|
|
.into(),
|
|
auth: AuthConfig {
|
|
cookie_secure: env_bool("COOKIE_SECURE", true),
|
|
cookie_domain: std::env::var("COOKIE_DOMAIN")
|
|
.ok()
|
|
.filter(|s| !s.is_empty()),
|
|
session_ttl_days: env_i64("SESSION_TTL_DAYS", 30),
|
|
rate_limit: crate::auth::rate_limit::RateLimitConfig {
|
|
per_sec: env_u64(
|
|
"AUTH_RATE_PER_SEC",
|
|
crate::auth::rate_limit::PRODUCTION_PER_SEC.into(),
|
|
) as u32,
|
|
burst: env_u64(
|
|
"AUTH_RATE_BURST",
|
|
crate::auth::rate_limit::PRODUCTION_BURST.into(),
|
|
) as u32,
|
|
},
|
|
allow_self_register: env_bool("ALLOW_SELF_REGISTER", true),
|
|
},
|
|
upload: UploadConfig {
|
|
max_request_bytes: env_usize("MAX_REQUEST_BYTES", 200 * 1024 * 1024),
|
|
max_file_bytes: env_usize("MAX_FILE_BYTES", 20 * 1024 * 1024),
|
|
},
|
|
cors_allowed_origins: std::env::var("CORS_ALLOWED_ORIGINS")
|
|
.ok()
|
|
.map(|s| {
|
|
s.split(',')
|
|
.map(|o| o.trim().to_string())
|
|
.filter(|o| !o.is_empty())
|
|
.collect()
|
|
})
|
|
.unwrap_or_default(),
|
|
crawler: CrawlerConfig::from_env()?,
|
|
admin_bootstrap: admin_bootstrap_from_env(),
|
|
})
|
|
}
|
|
}
|
|
|
|
/// Returns `Some((username, password))` only when BOTH `ADMIN_USERNAME`
|
|
/// and `ADMIN_PASSWORD` are set and non-empty. Half-set configuration is
|
|
/// treated as "no bootstrap" rather than a hard error, so an operator
|
|
/// can comment out one env var without crashing the server.
|
|
fn admin_bootstrap_from_env() -> Option<(String, String)> {
|
|
let username = std::env::var("ADMIN_USERNAME").ok().filter(|s| !s.is_empty())?;
|
|
let password = std::env::var("ADMIN_PASSWORD").ok().filter(|s| !s.is_empty())?;
|
|
Some((username, password))
|
|
}
|
|
|
|
impl CrawlerConfig {
|
|
pub fn from_env() -> anyhow::Result<Self> {
|
|
// Parse CRAWLER_DAILY_AT (HH:MM, 24h). Invalid → fail fast.
|
|
let daily_at = match std::env::var("CRAWLER_DAILY_AT").ok().as_deref() {
|
|
None | Some("") => NaiveTime::from_hms_opt(0, 0, 0).unwrap(),
|
|
Some(raw) => NaiveTime::parse_from_str(raw, "%H:%M").map_err(|e| {
|
|
anyhow::anyhow!("CRAWLER_DAILY_AT must be HH:MM (got {raw:?}): {e}")
|
|
})?,
|
|
};
|
|
let tz: Tz = match std::env::var("CRAWLER_TZ").ok().as_deref() {
|
|
None | Some("") => Tz::UTC,
|
|
Some(raw) => raw
|
|
.parse()
|
|
.map_err(|e| anyhow::anyhow!("CRAWLER_TZ must be a valid IANA TZ (got {raw:?}): {e}"))?,
|
|
};
|
|
let start_url = std::env::var("CRAWLER_START_URL")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty());
|
|
let cdn_host = std::env::var("CRAWLER_CDN_HOST")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty());
|
|
let download_allowlist =
|
|
build_download_allowlist(start_url.as_deref(), cdn_host.as_deref());
|
|
Ok(Self {
|
|
daemon_enabled: env_bool("CRAWLER_DAEMON", true),
|
|
daily_at,
|
|
tz,
|
|
idle_timeout: Duration::from_secs(env_u64("CRAWLER_IDLE_TIMEOUT_S", 600)),
|
|
chapter_workers: env_u64("CRAWLER_CHAPTER_WORKERS", 1).max(1) as usize,
|
|
retention_days: env_u64("CRAWLER_JOB_RETENTION_DAYS", 7) as u32,
|
|
start_url,
|
|
rate_ms: env_u64("CRAWLER_RATE_MS", 1000),
|
|
cdn_host,
|
|
cdn_rate_ms: env_u64("CRAWLER_CDN_RATE_MS", env_u64("CRAWLER_RATE_MS", 1000)),
|
|
phpsessid: std::env::var("CRAWLER_PHPSESSID")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty()),
|
|
cookie_domain: std::env::var("CRAWLER_COOKIE_DOMAIN")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty()),
|
|
user_agent: std::env::var("CRAWLER_USER_AGENT")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty()),
|
|
proxy: std::env::var("CRAWLER_PROXY")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty()),
|
|
browser: LaunchOptions::from_env(),
|
|
download_allowlist,
|
|
max_image_bytes: env_usize("CRAWLER_MAX_IMAGE_BYTES", DEFAULT_MAX_IMAGE_BYTES),
|
|
})
|
|
}
|
|
}
|
|
|
|
/// Build the download allowlist from env. Always includes
|
|
/// `CRAWLER_START_URL`'s host (so the crawler can fetch covers from
|
|
/// the catalog itself) and `CRAWLER_CDN_HOST` when set. Additional
|
|
/// hosts can be supplied via `CRAWLER_DOWNLOAD_ALLOWLIST` (comma-
|
|
/// separated). Empty by default — meaning the crawler refuses to
|
|
/// download anything when no source is configured, which is the safe
|
|
/// fail-closed posture.
|
|
///
|
|
/// `CRAWLER_ALLOW_ANY_HOST=true` short-circuits the host enumeration
|
|
/// for operators whose sources shard across numbered CDN subdomains.
|
|
/// Scheme + private-IP defenses still apply.
|
|
fn build_download_allowlist(
|
|
start_url: Option<&str>,
|
|
cdn_host: Option<&str>,
|
|
) -> DownloadAllowlist {
|
|
if env_bool("CRAWLER_ALLOW_ANY_HOST", false) {
|
|
return DownloadAllowlist::allow_any();
|
|
}
|
|
let mut allow = DownloadAllowlist::new();
|
|
if let Some(url) = start_url {
|
|
if let Ok(parsed) = reqwest::Url::parse(url) {
|
|
if let Some(h) = parsed.host_str() {
|
|
allow = allow.allow(h);
|
|
}
|
|
}
|
|
}
|
|
if let Some(host) = cdn_host {
|
|
allow = allow.allow(host);
|
|
}
|
|
if let Ok(extras) = std::env::var("CRAWLER_DOWNLOAD_ALLOWLIST") {
|
|
for piece in extras.split(',') {
|
|
let trimmed = piece.trim();
|
|
if !trimmed.is_empty() {
|
|
allow = allow.allow(trimmed);
|
|
}
|
|
}
|
|
}
|
|
allow
|
|
}
|
|
|
|
fn env_u64(name: &str, default: u64) -> u64 {
|
|
std::env::var(name)
|
|
.ok()
|
|
.and_then(|s| s.parse().ok())
|
|
.unwrap_or(default)
|
|
}
|
|
|
|
fn env_bool(name: &str, default: bool) -> bool {
|
|
match std::env::var(name).ok().as_deref() {
|
|
Some("1") | Some("true") | Some("TRUE") | Some("yes") => true,
|
|
Some("0") | Some("false") | Some("FALSE") | Some("no") => false,
|
|
_ => default,
|
|
}
|
|
}
|
|
|
|
fn env_i64(name: &str, default: i64) -> i64 {
|
|
std::env::var(name)
|
|
.ok()
|
|
.and_then(|s| s.parse().ok())
|
|
.unwrap_or(default)
|
|
}
|
|
|
|
fn env_usize(name: &str, default: usize) -> usize {
|
|
std::env::var(name)
|
|
.ok()
|
|
.and_then(|s| s.parse().ok())
|
|
.unwrap_or(default)
|
|
}
|
|
|