From 0bce113d280fb68514952765f82b059b701aa149 Mon Sep 17 00:00:00 2001 From: MechaCat02 Date: Sun, 7 Jun 2026 20:44:56 +0200 Subject: [PATCH] fix(manager-core): F-M-001 drop unused idx_cron_triggers_due MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Migration 0017_cron_triggers.sql created idx_cron_triggers_due on (last_fired_at) with a comment claiming it serves the scheduler. The actual scheduler query has no last_fired_at predicate — it filters purely on `t.enabled = TRUE FOR UPDATE OF d SKIP LOCKED`. The index has been pure write amplification with no read payoff. Migration 0037 drops it. Reversible by re-running 0017's CREATE INDEX if the planner story ever changes. AUDIT.md anchor: F-M-001. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../migrations/0037_drop_idx_cron_triggers_due.sql | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 crates/manager-core/migrations/0037_drop_idx_cron_triggers_due.sql diff --git a/crates/manager-core/migrations/0037_drop_idx_cron_triggers_due.sql b/crates/manager-core/migrations/0037_drop_idx_cron_triggers_due.sql new file mode 100644 index 0000000..eeba180 --- /dev/null +++ b/crates/manager-core/migrations/0037_drop_idx_cron_triggers_due.sql @@ -0,0 +1,12 @@ +-- F-M-001 (audit 2026-06-07): drop idx_cron_triggers_due. +-- +-- Created in 0017_cron_triggers.sql with a comment claiming it serves +-- the scheduler. The actual scheduler query is +-- `... WHERE t.enabled = TRUE FOR UPDATE OF d SKIP LOCKED` — no +-- `last_fired_at` predicate. The index is unused; the join is +-- effectively a full table scan of cron details against enabled +-- triggers (small N today, so the overhead is invisible — but the +-- index is also pure write amplification with zero read payoff). +-- +-- Drop is reversible by re-running the CREATE INDEX from 0017. +DROP INDEX IF EXISTS idx_cron_triggers_due;