fabi/PiCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(v1.1.7): fix clippy --all-targets warnings

Browse Source 
Clears the workspace under `clippy --all-targets --all-features
-D warnings`. Four were pre-existing at v1.1.6 HEAD (latent finding,
see HANDBACK): double_must_use on realtime_router, map_unwrap_or in
pubsub_service, redundant_closure in topic_repo, needless_raw_string in
a subscriber-token test. The rest are v1.1.7 nits (needless_borrow +
semicolon in the dead-letter / realtime-migration code).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-06-04 22:38:11 +02:00
parent b35585195b
commit 2ea47eb05a
6 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/executor-core/tests/sdk_subscriber_token.rs
View File

@@ -197,7 +197,7 @@ async fn unit_ttl_uses_default() {
async fn empty_topics_throws() { async fn empty_topics_throws() {
run_err( run_err(
make_engine(), make_engine(),
r#"pubsub::subscriber_token([], 60)"#, r"pubsub::subscriber_token([], 60)",
request(AppId::new(), true), request(AppId::new(), true),
) )
.await; .await;

2
crates/manager-core/src/dispatcher.rs
View File

@@ -496,7 +496,7 @@ impl Dispatcher {
// top of this function, so this fan-out is only reached for // top of this function, so this fan-out is only reached for
// non-handler executions. // non-handler executions.
if let Some(dl_id) = dl_id { if let Some(dl_id) = dl_id {
self.fan_out_dead_letter(&row, &resolved, dl_id, &source, attempt, &err, now) self.fan_out_dead_letter(row, resolved, dl_id, &source, attempt, &err, now)
.await; .await;
} }

2
crates/manager-core/src/pubsub_service.rs
View File

@@ -254,7 +254,7 @@ impl PubsubService for PubsubServiceImpl {
.get(cx.app_id, name) .get(cx.app_id, name)
.await .await
.map_err(|e| PubsubError::Unavailable(e.to_string()))?; .map_err(|e| PubsubError::Unavailable(e.to_string()))?;
if !registered.map(|t| t.external_subscribable).unwrap_or(false) { if !registered.is_some_and(|t| t.external_subscribable) {
return Err(PubsubError::SubscriberToken(format!( return Err(PubsubError::SubscriberToken(format!(
"pubsub::subscriber_token: topic {name} is not externally subscribable" "pubsub::subscriber_token: topic {name} is not externally subscribable"
))); )));

2
crates/manager-core/src/topic_repo.rs
View File

@@ -195,7 +195,7 @@ impl TopicRepo for PostgresTopicRepo {
.bind(app_id.into_inner()) .bind(app_id.into_inner())
.bind(name) .bind(name)
.bind(external_subscribable) .bind(external_subscribable)
.bind(auth_mode.map(|m| m.as_str())) .bind(auth_mode.map(TopicAuthMode::as_str))
.fetch_optional(&self.pool) .fetch_optional(&self.pool)
.await?; .await?;
row.map(TopicRow::into_topic).transpose() row.map(TopicRow::into_topic).transpose()

1
crates/orchestrator-core/src/realtime_api.rs
View File

@@ -80,7 +80,6 @@ pub fn heartbeat_secs_from_env() -> u64 {
} }
/// Router for the realtime SSE surface. Merged at the router root. /// Router for the realtime SSE surface. Merged at the router root.
#[must_use]
pub fn realtime_router(state: RealtimeState) -> Router { pub fn realtime_router(state: RealtimeState) -> Router {
Router::new() Router::new()
.route("/realtime/topics/{topic}", get(sse_topic)) .route("/realtime/topics/{topic}", get(sse_topic))

8
crates/picloud/src/lib.rs
View File

@@ -198,12 +198,14 @@ pub async fn build_app(
// plaintext column is dropped in v1.1.8. // plaintext column is dropped in v1.1.8.
match app_secrets_repo.migrate_plaintext_keys().await { match app_secrets_repo.migrate_plaintext_keys().await {
Ok(0) => {} Ok(0) => {}
Ok(n) => tracing::info!( Ok(n) => {
tracing::info!(
migrated = n, migrated = n,
"encrypted plaintext realtime signing keys at rest" "encrypted plaintext realtime signing keys at rest"
), );
}
Err(e) => { Err(e) => {
tracing::error!(error = %e, "failed to encrypt realtime signing keys (continuing)") tracing::error!(error = %e, "failed to encrypt realtime signing keys (continuing)");
} }
} }
let realtime_authority: Arc<dyn RealtimeAuthority> = Arc::new(RealtimeAuthorityImpl::new( let realtime_authority: Arc<dyn RealtimeAuthority> = Arc::new(RealtimeAuthorityImpl::new(