feat: E2E #2 (Stash) gap remediation + S6 hardening
Closes the gaps and the one security finding from the second end-to-end
CLI test (E2E_STASH_REPORT.md), plus the H1 boot-regression found while
re-reviewing those fixes.
Security
- S6: reserved-path validation (`check_reserved`) now case-folds before
comparing, so `/API/v2/x`, `/HEALTHZ`, `/Admin/x` are rejected like
their lowercase forms. Request-time matching stays case-sensitive.
- S10: "public route != public data" callout in sdk-shape.md (script_gate
skips authz when the principal is anonymous).
Observability / features
- G1: trigger executions now write `execution_logs`. Migration 0043 adds
a `source` column (CHECK mirrors ExecutionSource/OutboxSourceKind,
DEFAULT 'http' backfills history); a shared `build_execution_log` helper
in executor-core; dispatcher logging for outbox triggers + queue
consumers (skips sync-HTTP rows the orchestrator already logs). `pic
logs` gains a source column + `--source` filter.
- G5: dev-only in-memory email capture under PICLOUD_DEV_MODE with no SMTP
(email::send succeeds locally), readable at GET /api/v1/admin/dev/emails
(Owner/Admin only; route mounted only in capture mode).
- G6: generalized the Rhai in-place-mutation footgun note (trim/replace/
make_upper/make_lower/crop/truncate/pad return ()).
- G2/G3/G4 (CLI): `pic members`, `pic files`, `pic queues`, read-only
`pic kv` (+ new kv_api.rs); `pic deploy --timeout/--memory/--kind/
--sandbox`; first-class `pic triggers create-{docs,files,pubsub,queue,
email}` wrappers. All new client path segments percent-encoded via seg().
H1 regression fix (found in re-review)
- The S6 change also runs in `compile_routes`, which compiles every stored
route at boot and on each route CRUD. A single stored route the new
validation rejects (creatable while the S6 gap existed) made the whole
compile Err and aborted startup. `compile_routes` is now lenient: it
skips an un-compilable row with a warning instead of bricking boot
(route creation still validates separately). Migration 0044 sweeps
pre-existing reserved-path routes on upgrade (WHERE mirrors
check_reserved exactly). Added regression tests for both.
Verified: cargo fmt, clippy --all-targets --all-features -D warnings, the
schema_snapshot test, and the new S6/lenient-compile unit tests all pass;
boot-resilience and G1/G5 confirmed live.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -108,8 +108,15 @@ pub fn parse_path(kind: PathKind, raw: &str) -> Result<PathPattern, ParseError>
|
||||
}
|
||||
|
||||
fn check_reserved(raw: &str) -> Result<(), ParseError> {
|
||||
// Case-fold before comparing: request-time path matching is case-sensitive,
|
||||
// but the reserved namespace must be rejected regardless of case so a tenant
|
||||
// can't publish look-alikes like `/Admin/login` or `/API/v2/x`. Method/host
|
||||
// matching are already case-insensitive; this keeps the validation guard
|
||||
// durable even if path matching ever follows.
|
||||
let lowered = raw.to_ascii_lowercase();
|
||||
for r in RESERVED_PATH_PREFIXES {
|
||||
if raw == r.trim_end_matches('/') || raw.starts_with(r) {
|
||||
if lowered == r.trim_end_matches('/') || lowered.starts_with(r) {
|
||||
// Preserve the caller's original case in the error for clarity.
|
||||
return Err(ParseError::ReservedPath(raw.to_string()));
|
||||
}
|
||||
}
|
||||
@@ -456,6 +463,29 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn rejects_reserved_paths_case_insensitively() {
|
||||
// Case variants of every reserved prefix must be rejected: the reserved
|
||||
// namespace is a security boundary and must not be bypassable by casing.
|
||||
for raw in [
|
||||
"/API/v2/foo",
|
||||
"/Api/v2/foo",
|
||||
"/aPi/x",
|
||||
"/Admin/dashboard",
|
||||
"/ADMIN/x",
|
||||
"/HEALTHZ",
|
||||
"/HealthZ",
|
||||
"/Version",
|
||||
"/VERSION",
|
||||
] {
|
||||
let e = parse_path(PathKind::Exact, raw).unwrap_err();
|
||||
assert!(
|
||||
matches!(e, ParseError::ReservedPath(_)),
|
||||
"expected reserved for {raw:?}, got {e:?}"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn rejects_missing_leading_slash() {
|
||||
let e = parse_path(PathKind::Exact, "greet").unwrap_err();
|
||||
|
||||
Reference in New Issue
Block a user