fix(executor-core): F-Q-002 promote sdk::bridge::block_on, migrate 9 SDK modules

Replace ten near-identical `block_on` helpers (one per SDK module)
with a single shared `sdk::bridge::block_on(service: &str, fut)`.
The helper takes a service-prefix string and a future whose error
implements Display, so each module's `KvError`/`DocsError`/etc.
still self-formats.

Migrated:
- kv, docs, pubsub, users, dead_letters, secrets, files, email
- queue.rs has two helpers; the inline-shaped enqueue path and the
  block_on_u64 (u64→i64) wrapper are left in place — the latter
  could use the shared helper but the local form is one less call
  site per finding overlap. Will revisit on a later pass if needed.
- http.rs is intentionally NOT migrated: it has per-variant error
  mapping via `map_http_err` that the generic helper can't express.

Net: -218 / +97 lines across the 9 migrated files. Single source of
truth for the runtime-handle lookup and error wrapping.

AUDIT.md anchor: F-Q-002.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

crates/executor-core/src/sdk/kv.rs

@@ -28,11 +28,10 @@
 
 use std::sync::Arc;
 
-use picloud_shared::{KvError, KvService, SdkCallCx, Services};
+use picloud_shared::{KvService, SdkCallCx, Services};
 use rhai::{Array, Dynamic, Engine as RhaiEngine, EvalAltResult, Map, Module};
-use tokio::runtime::Handle as TokioHandle;
 
-use super::bridge::{dynamic_to_json, json_to_dynamic};
+use super::bridge::{block_on, dynamic_to_json, json_to_dynamic};
 
 /// Per-call handle captured by the Rhai SDK. Cheap to clone (two Arcs
 /// plus an owned string).
@@ -85,7 +84,7 @@ fn register_get(engine: &mut RhaiEngine) {
         "get",
         |handle: &mut KvHandle, key: &str| -> Result<Dynamic, Box<EvalAltResult>> {
             let h = handle.clone();
-            block_on(async move { h.service.get(&h.cx, &h.collection, key).await })
+            block_on("kv", async move { h.service.get(&h.cx, &h.collection, key).await })
                 .map(|opt| opt.map_or(Dynamic::UNIT, json_to_dynamic))
         },
     );
@@ -97,7 +96,7 @@ fn register_set(engine: &mut RhaiEngine) {
         |handle: &mut KvHandle, key: &str, value: Dynamic| -> Result<(), Box<EvalAltResult>> {
             let h = handle.clone();
             let json = dynamic_to_json(&value);
-            block_on(async move { h.service.set(&h.cx, &h.collection, key, json).await })
+            block_on("kv", async move { h.service.set(&h.cx, &h.collection, key, json).await })
         },
     );
 }
@@ -107,7 +106,7 @@ fn register_has(engine: &mut RhaiEngine) {
         "has",
         |handle: &mut KvHandle, key: &str| -> Result<bool, Box<EvalAltResult>> {
             let h = handle.clone();
-            block_on(async move { h.service.has(&h.cx, &h.collection, key).await })
+            block_on("kv", async move { h.service.has(&h.cx, &h.collection, key).await })
         },
     );
 }
@@ -117,7 +116,7 @@ fn register_delete(engine: &mut RhaiEngine) {
         "delete",
         |handle: &mut KvHandle, key: &str| -> Result<bool, Box<EvalAltResult>> {
             let h = handle.clone();
-            block_on(async move { h.service.delete(&h.cx, &h.collection, key).await })
+            block_on("kv", async move { h.service.delete(&h.cx, &h.collection, key).await })
         },
     );
 }
@@ -153,7 +152,7 @@ fn list_call(
     limit: u32,
 ) -> Result<Map, Box<EvalAltResult>> {
     let h = handle.clone();
-    let page = block_on(async move {
+    let page = block_on("kv", async move {
         h.service
             .list(&h.cx, &h.collection, cursor.as_deref(), limit)
             .await
@@ -168,26 +167,3 @@ fn list_call(
     Ok(m)
 }
 
-/// Run an async future inside the synchronous Rhai context.
-///
-/// `LocalExecutorClient` wraps script execution in `spawn_blocking`, so
-/// the current Tokio runtime is reachable via `Handle::current()`. We
-/// block on it directly; we are NOT calling this from an async task,
-/// so blocking is the correct primitive (`block_in_place` would also
-/// work, but we're already on a blocking worker).
-fn block_on<F, T>(fut: F) -> Result<T, Box<EvalAltResult>>
-where
-    F: std::future::Future<Output = Result<T, KvError>> + Send,
-    T: Send,
-{
-    let handle = TokioHandle::try_current().map_err(|e| -> Box<EvalAltResult> {
-        EvalAltResult::ErrorRuntime(
-            format!("kv: no tokio runtime available: {e}").into(),
-            rhai::Position::NONE,
-        )
-        .into()
-    })?;
-    handle.block_on(fut).map_err(|err| -> Box<EvalAltResult> {
-        EvalAltResult::ErrorRuntime(format!("kv: {err}").into(), rhai::Position::NONE).into()
-    })
-}