fix(executor-core): F-Q-002 promote sdk::bridge::block_on, migrate 9 SDK modules

Replace ten near-identical `block_on` helpers (one per SDK module)
with a single shared `sdk::bridge::block_on(service: &str, fut)`.
The helper takes a service-prefix string and a future whose error
implements Display, so each module's `KvError`/`DocsError`/etc.
still self-formats.

Migrated:
- kv, docs, pubsub, users, dead_letters, secrets, files, email
- queue.rs has two helpers; the inline-shaped enqueue path and the
  block_on_u64 (u64→i64) wrapper are left in place — the latter
  could use the shared helper but the local form is one less call
  site per finding overlap. Will revisit on a later pass if needed.
- http.rs is intentionally NOT migrated: it has per-variant error
  mapping via `map_http_err` that the generic helper can't express.

Net: -218 / +97 lines across the 9 migrated files. Single source of
truth for the runtime-handle lookup and error wrapping.

AUDIT.md anchor: F-Q-002.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

crates/executor-core/src/sdk/secrets.rs

@@ -18,11 +18,10 @@
 
 use std::sync::Arc;
 
-use picloud_shared::{SdkCallCx, SecretsError, SecretsListPage, Services};
+use picloud_shared::{SdkCallCx, SecretsListPage, Services};
 use rhai::{Array, Dynamic, Engine as RhaiEngine, EvalAltResult, Map, Module};
-use tokio::runtime::Handle as TokioHandle;
 
-use super::bridge::{dynamic_to_json, json_to_dynamic};
+use super::bridge::{block_on, dynamic_to_json, json_to_dynamic};
 
 pub(super) fn register(engine: &mut RhaiEngine, services: &Services, cx: Arc<SdkCallCx>) {
     let svc = services.secrets.clone();
@@ -38,7 +37,7 @@ pub(super) fn register(engine: &mut RhaiEngine, services: &Services, cx: Arc<Sdk
                 let json = dynamic_to_json(&value);
                 let svc = svc.clone();
                 let cx = cx.clone();
-                block_on(async move { svc.set(&cx, name, json).await })
+                block_on("secrets", async move { svc.set(&cx, name, json).await })
             },
         );
     }
@@ -52,7 +51,7 @@ pub(super) fn register(engine: &mut RhaiEngine, services: &Services, cx: Arc<Sdk
             move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
                 let svc = svc.clone();
                 let cx = cx.clone();
-                let opt = block_on(async move { svc.get(&cx, name).await })?;
+                let opt = block_on("secrets", async move { svc.get(&cx, name).await })?;
                 Ok(opt.map_or(Dynamic::UNIT, json_to_dynamic))
             },
         );
@@ -67,7 +66,7 @@ pub(super) fn register(engine: &mut RhaiEngine, services: &Services, cx: Arc<Sdk
             move |name: &str| -> Result<bool, Box<EvalAltResult>> {
                 let svc = svc.clone();
                 let cx = cx.clone();
-                block_on(async move { svc.delete(&cx, name).await })
+                block_on("secrets", async move { svc.delete(&cx, name).await })
             },
         );
     }
@@ -83,7 +82,7 @@ pub(super) fn register(engine: &mut RhaiEngine, services: &Services, cx: Arc<Sdk
                 let svc = svc.clone();
                 let cx = cx.clone();
                 let page: SecretsListPage =
-                    block_on(async move { svc.list(&cx, cursor.as_deref(), limit).await })?;
+                    block_on("secrets", async move { svc.list(&cx, cursor.as_deref(), limit).await })?;
                 Ok(list_page_to_map(page))
             },
         );
@@ -132,22 +131,3 @@ fn runtime_err(msg: &str) -> Box<EvalAltResult> {
     EvalAltResult::ErrorRuntime(msg.into(), rhai::Position::NONE).into()
 }
 
-/// Run a `SecretsService` future inside the synchronous Rhai context,
-/// mapping any `SecretsError` to a Rhai runtime error. Mirrors
-/// `kv::block_on` / `pubsub::block_on`.
-fn block_on<T, F>(fut: F) -> Result<T, Box<EvalAltResult>>
-where
-    F: std::future::Future<Output = Result<T, SecretsError>> + Send,
-    T: Send,
-{
-    let handle = TokioHandle::try_current().map_err(|e| -> Box<EvalAltResult> {
-        EvalAltResult::ErrorRuntime(
-            format!("secrets: no tokio runtime available: {e}").into(),
-            rhai::Position::NONE,
-        )
-        .into()
-    })?;
-    handle.block_on(fut).map_err(|err| -> Box<EvalAltResult> {
-        EvalAltResult::ErrorRuntime(format!("secrets: {err}").into(), rhai::Position::NONE).into()
-    })
-}