fix(project-tool): address independent review of init + staleness
Remediation after an independent review of the two feature commits. pic init: - Fix the headline `pic init --dir <new-dir>` flow: slug derivation used `canonicalize()`, which fails on a not-yet-created directory → empty slug → bail. Derive from the path's own final component first, falling back to canonicalize only for `.`. Add a test that exercised the gap (the existing tests all passed an explicit slug). - `ensure_gitignored` no longer overwrites an existing-but-unreadable `.gitignore` (only a genuinely-absent file is treated as empty). Bound-plan staleness: - Token trigger coverage now mirrors the diff exactly via `current_trigger_identity`: dead-letter triggers (which the diff ignores and the manifest can't represent) and the currently-inert `enabled` flag are no longer hashed, so an out-of-band dead-letter change can't force a spurious `--force`. Add a test. - Correct two overclaiming comments: the check shares the diff's pool-read apply-vs-interactive-write window (it is not tx-scoped), and the token deliberately mirrors the diff's inputs. - `.picloud/` self-ignores via a `*` `.gitignore` written alongside the plan token, so projects created with `pic pull`/`plan` (not just `init`) keep it out of git. - `clear_plan` is now app-scoped: it won't discard a token recorded for a different app sharing the directory. Tested: manager-core lib 364 + cli bins 31 + 14 project-tool journeys green; clippy -D warnings clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -36,6 +36,25 @@ fn init_scaffolds_a_deployable_project() {
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn init_derives_slug_from_a_not_yet_created_dir() {
|
||||
// The natural `pic init --dir new-project` flow: the target doesn't exist
|
||||
// yet, and the slug is derived from its name (not via canonicalize, which
|
||||
// would fail on a missing path).
|
||||
let parent = TempDir::new().unwrap();
|
||||
let target = parent.path().join("new-project");
|
||||
pic()
|
||||
.args(["init", "--dir"])
|
||||
.arg(&target)
|
||||
.assert()
|
||||
.success();
|
||||
let toml = fs::read_to_string(target.join("picloud.toml")).unwrap();
|
||||
assert!(
|
||||
toml.contains("slug = \"new-project\""),
|
||||
"slug should derive from the dir name:\n{toml}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn init_refuses_to_overwrite_without_force() {
|
||||
let dir = TempDir::new().unwrap();
|
||||
|
||||
Reference in New Issue
Block a user