chore(v1.1.8): clippy --all-targets clean (F2)

Sweep the v1.1.8-introduced clippy warnings under
--workspace --all-targets --all-features -- -D warnings:

  * 12x map_unwrap_or in executor-core/sdk/users.rs — rewrite as
    map_or; mostly the Option<X> -> Dynamic conversion shape.
  * Doc-list-without-indentation in
    app_user_password_reset_repo.rs's module docstring — rewrap
    so a continuation line doesn't start with `+ `.
  * usize-as-i64 cast in app_user_repo.rs list — use
    i64::try_from(...).unwrap_or(i64::MAX) for the cursor cap.
  * 2x map_unwrap_or in users_service.rs env helpers — map_or.
  * single-pattern match in users_service.rs login — let-else
    rewrite so the dummy-Argon2 side-effect stays in the
    diverging branch (no semantic change).

Also updated the 10 executor-core integration-test bins
(sdk_email, sdk_kv, sdk_docs, sdk_files, sdk_pubsub,
sdk_secrets, sdk_http, sdk_subscriber_token,
module_redaction_logging, modules) to pass the new
NoopUsersService positional arg into Services::new().

NOTE — the brief specifies running this attestation under `cargo
clean` first. I skipped the clean step because an earlier
`cargo test --workspace` froze this host (the user explicitly
asked me to keep subsequent builds lighter). The incremental
cache was hot for every workspace crate when clippy ran; test
binaries appeared in the Checking output as expected. Flagged in
HANDBACK §6 F2 + §7.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

crates/executor-core/tests/module_redaction_logging.rs

@@ -103,6 +103,7 @@ async fn original_backend_error_is_logged_at_error_level() {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     let engine = Engine::new(Limits::default(), services);
 

crates/executor-core/tests/modules.rs

@@ -101,6 +101,7 @@ fn services_with(modules: Arc<dyn ModuleSource>) -> Services {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     )
 }
 

crates/executor-core/tests/sdk_docs.rs

@@ -232,6 +232,7 @@ fn make_engine() -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_email.rs

@@ -41,6 +41,7 @@ fn engine_with(rec: Arc<RecordingEmail>) -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         rec,
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_files.rs

@@ -169,6 +169,7 @@ fn make_engine() -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_http.rs

@@ -92,6 +92,7 @@ fn engine_with(http: Arc<dyn HttpService>) -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_kv.rs

@@ -111,6 +111,7 @@ fn make_engine() -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_pubsub.rs

@@ -49,6 +49,7 @@ fn make_engine(svc: Arc<RecordingPubsub>) -> Arc<Engine> {
         svc,
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_secrets.rs

@@ -102,6 +102,7 @@ fn make_engine() -> Arc<Engine> {
         Arc::new(picloud_shared::NoopPubsubService),
         Arc::new(InMemorySecrets::default()),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }

crates/executor-core/tests/sdk_subscriber_token.rs

@@ -96,6 +96,7 @@ fn make_engine() -> Arc<Engine> {
         Arc::new(FakeMintPubsub),
         Arc::new(picloud_shared::NoopSecretsService),
         Arc::new(picloud_shared::NoopEmailService),
+        Arc::new(picloud_shared::NoopUsersService),
     );
     Arc::new(Engine::new(Limits::default(), services))
 }