feat(v1.1.3-modules): shared types, migrations, engine + resolver scaffold
Lays down the v1.1.3 plumbing:
- `ScriptKind` enum in `picloud-shared` ('endpoint' | 'module').
- `ModuleSource` trait + `ModuleScript` DTO + `NoopModuleSource` in
`picloud-shared`. Resolver lives in `executor-core`; Postgres impl
in `manager-core` (`PostgresModuleSource`).
- `Services::new` grows a fifth `modules: Arc<dyn ModuleSource>` arg.
- `ScriptValidator` returns `ValidatedScript { imports }` so the
manager can populate the dep-graph table on save. New
`validate_module` method on the trait gates module-shape rules.
- `Engine::execute_ast(&Arc<rhai::AST>, req)` lets the orchestrator's
script cache reuse compiled ASTs. `Engine::execute(&str, req)` is
preserved as a convenience that compiles inline. `Engine::compile`
exposes the AST for callers that want to cache.
- `PicloudModuleResolver` replaces `DummyModuleResolver` per-call.
Bridges Rhai's sync `ModuleResolver::resolve` to async
`ModuleSource::lookup` via `Handle::block_on`. Enforces:
- cross-app isolation (resolver captures `Arc<SdkCallCx>`),
- circular import detection (in-progress stack on the resolver),
- import depth limit (default 8 via
`Limits::module_import_depth_max`).
- Module-shape validation walks `ast.statements()` via `rhai/internals`
and accepts only `Var { CONSTANT }`, `Import`, and `Noop`. The
manager admin endpoint runs `validate_module` at save (primary
gate); resolver re-runs it at load (defense in depth).
- LRU cache `(AppId, name) -> (updated_at, Arc<Module>)` owned by
`Engine`. Size from `PICLOUD_MODULE_CACHE_SIZE` (default 512).
- Migration `0015_scripts_kind.sql` adds `scripts.kind` + composite
index + module-name shape CHECK.
- Migration `0016_script_imports.sql` adds the dep-graph table with
FK CASCADE on both columns.
- Repo: `kind` threaded through SELECT/INSERT/UPDATE. New
`count_routes_for_script` / `count_triggers_for_script` /
`list_imports` methods. `create`/`update` open a transaction and
call `replace_imports_tx` to populate the dep-graph.
- Admin endpoint: accepts `kind`; rejects reserved module names;
rejects `endpoint → module` transitions when routes / triggers
exist.
- SDK_VERSION 1.3 → 1.4.
Workspace builds; full test suite (~440 tests) green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -120,12 +120,13 @@ pub async fn build_app(pool: PgPool, auth: AuthDeps) -> anyhow::Result<Router> {
|
||||
let abandoned_repo: Arc<dyn AbandonedRepo> = Arc::new(PostgresAbandonedRepo::new(pool.clone()));
|
||||
let trigger_config = TriggerConfig::from_env();
|
||||
|
||||
// SDK services bundle. v1.1.1 added KV + dead-letter; v1.1.2 adds
|
||||
// the docs store. All four bound services share the
|
||||
// outbox-backed event emitter so KV and docs mutations both fan
|
||||
// out through the same dispatcher.
|
||||
// SDK services bundle. v1.1.1 added KV + dead-letter; v1.1.2 added
|
||||
// the docs store; v1.1.3 adds the module source backing the Rhai
|
||||
// resolver. All bound services share the outbox-backed event
|
||||
// emitter so KV and docs mutations both fan out through the same
|
||||
// dispatcher.
|
||||
let kv_repo = Arc::new(PostgresKvRepo::new(pool.clone()));
|
||||
let docs_repo = Arc::new(PostgresDocsRepo::new(pool));
|
||||
let docs_repo = Arc::new(PostgresDocsRepo::new(pool.clone()));
|
||||
let events: Arc<dyn ServiceEventEmitter> = Arc::new(OutboxEventEmitter::new(
|
||||
trigger_repo.clone(),
|
||||
outbox_repo.clone(),
|
||||
@@ -142,7 +143,9 @@ pub async fn build_app(pool: PgPool, auth: AuthDeps) -> anyhow::Result<Router> {
|
||||
outbox_repo.clone(),
|
||||
authz.clone(),
|
||||
));
|
||||
let services = Services::new(kv, docs, dl_service.clone(), events);
|
||||
let modules: Arc<dyn picloud_shared::ModuleSource> =
|
||||
Arc::new(picloud_manager_core::PostgresModuleSource::new(pool));
|
||||
let services = Services::new(kv, docs, dl_service.clone(), events, modules);
|
||||
let engine = Arc::new(Engine::new(Limits::default(), services));
|
||||
|
||||
// Compile the routes table once at startup; admin writes refresh it.
|
||||
@@ -418,4 +421,22 @@ impl picloud_manager_core::ScriptRepository for PostgresScriptRepoHandle {
|
||||
) -> Result<(), picloud_manager_core::ScriptRepositoryError> {
|
||||
self.0.delete(id).await
|
||||
}
|
||||
async fn count_routes_for_script(
|
||||
&self,
|
||||
script_id: picloud_shared::ScriptId,
|
||||
) -> Result<i64, picloud_manager_core::ScriptRepositoryError> {
|
||||
self.0.count_routes_for_script(script_id).await
|
||||
}
|
||||
async fn count_triggers_for_script(
|
||||
&self,
|
||||
script_id: picloud_shared::ScriptId,
|
||||
) -> Result<i64, picloud_manager_core::ScriptRepositoryError> {
|
||||
self.0.count_triggers_for_script(script_id).await
|
||||
}
|
||||
async fn list_imports(
|
||||
&self,
|
||||
script_id: picloud_shared::ScriptId,
|
||||
) -> Result<Vec<picloud_shared::Script>, picloud_manager_core::ScriptRepositoryError> {
|
||||
self.0.list_imports(script_id).await
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user