ci: run the DB-backed tests that CI was silently skipping
CI ran `cargo test --workspace` with no `--include-ignored`, so it executed 927 tests and skipped 237 — every DB-backed integration test is `#[ignore = "needs DATABASE_URL..."]`, which covers ALL of api.rs, ALL of authz.rs, and the entire CLI journey suite. The isolation and RBAC tests existed but never ran (AUDIT.md F-Q-014, logged and never remediated). CI provides Postgres, so it can run them. Three things had to be right for that to go green: - **`--all-targets`, not a bare workspace run.** `-- --include-ignored` un-ignores not just `#[ignore]` tests but also ` ```ignore ` DOCTESTS, which are illustrative pseudocode that does not compile. `--all-targets` runs lib/bins/ integration tests but excludes doctests (the same reason clippy uses it); a separate `--doc` step runs the doctests without the flag. Structural, so a future pseudocode doctest can't silently break CI either. - **The CLI journeys are their own step.** They spawn a real picloud whose dispatcher/orchestrator claim loops are global by design; run concurrently with the manager-core suites on the shared database they would claim those suites' outbox and workflow rows. Sequential steps keep the live server off the DB while the other suites use it. The step also rebuilds `-p picloud` first (the harness execs the prebuilt binary) and sets the dev-mode env the server needs. - **A higher `max_connections`.** `#[sqlx::test]` pools are lazy, but mass-parallel test startup briefly opens many at once (each test creates its own throwaway database); on a many-core box that transient spike exceeded the default 100 and Postgres answered "sorry, too many clients already". Steady-state peak is only ~26; 500 absorbs the spike with room to spare. Serving the app needs nothing like this many. (This is the local compose ceiling; a small CI runner's default 100 has ample headroom for its lower parallelism.) Also fixes the test the CI gap had let rot: api.rs asserted `v["schema"] == 66` with a hand-bump comment, and since nothing ran it, it sat broken from migration 0066 to 0073. It now asserts `/version` surfaces the live constants (`migrations::latest_version()`, `SDK_VERSION`) — the wiring — while value drift stays caught by schema_snapshot + check-versioning. A constant hand-synced to another constant is a chore, not a test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
48
.github/workflows/ci.yml
vendored
48
.github/workflows/ci.yml
vendored
@@ -47,11 +47,49 @@ jobs:
|
||||
- name: Clippy
|
||||
run: cargo clippy --all-targets --all-features -- -D warnings
|
||||
|
||||
# Runs the whole workspace, including the schema-snapshot guardrail
|
||||
# (it picks up DATABASE_URL from the env above and the postgres
|
||||
# service; without a DB it would skip cleanly).
|
||||
- name: Test
|
||||
run: cargo test --workspace
|
||||
# `--include-ignored` is load-bearing. Every DB-backed integration test is
|
||||
# `#[ignore = "needs DATABASE_URL..."]`, and CI omitted the flag — so CI ran
|
||||
# 927 tests and silently skipped 237, among them ALL of authz.rs and api.rs
|
||||
# and the entire CLI journey suite. The isolation and RBAC tests existed but
|
||||
# never executed (AUDIT.md F-Q-014). CI does provide Postgres, so run them.
|
||||
#
|
||||
# `--all-targets` (not a bare `cargo test`) is deliberate: it runs the lib,
|
||||
# bins, and integration tests but NOT doctests. `-- --include-ignored`
|
||||
# un-ignores not just `#[ignore]` tests but also ` ```ignore ` DOCTESTS,
|
||||
# which are illustrative pseudocode that does not compile — so a bare
|
||||
# `cargo test ... -- --include-ignored` fails on them. Doctests run in their
|
||||
# own step below, without the flag. (Clippy already uses `--all-targets` for
|
||||
# the same doctest-excluding reason.)
|
||||
#
|
||||
# The CLI journeys are a SEPARATE step, and deliberately not part of the
|
||||
# workspace run: they spawn a real picloud whose dispatcher/orchestrator
|
||||
# claim loops are global by design (one instance owns one database). Run
|
||||
# concurrently with the manager-core suites — which share this database —
|
||||
# it would claim their outbox and workflow rows out from under them. Keeping
|
||||
# the steps sequential keeps that live server off the shared DB while the
|
||||
# other suites are using it.
|
||||
- name: Test (workspace, including DB-backed tests)
|
||||
run: cargo test --workspace --exclude picloud-cli --all-targets -- --include-ignored
|
||||
|
||||
# Doctests, run WITHOUT --include-ignored so ` ```ignore ` snippets stay
|
||||
# ignored. `--all-targets` above skips these, so nothing else covers them.
|
||||
- name: Doctests
|
||||
run: cargo test --workspace --doc
|
||||
|
||||
# The journey harness execs the prebuilt target/debug/picloud and does NOT
|
||||
# rebuild it, so a stale binary would silently test old server code.
|
||||
- name: Build picloud (the journey harness execs this binary)
|
||||
run: cargo build -p picloud
|
||||
|
||||
# The spawned server inherits this env; without a secret key it aborts at
|
||||
# startup and every journey fails as "/healthz never returned 200".
|
||||
# `--all-targets` for the same reason as above (the journeys are `#[ignore]`
|
||||
# integration tests; picloud-cli's doctests, if any, run in the Doctests step).
|
||||
- name: Test (CLI journeys)
|
||||
env:
|
||||
PICLOUD_DEV_MODE: "true"
|
||||
PICLOUD_DEV_INSECURE_KEY: i-understand-this-is-insecure
|
||||
run: cargo test -p picloud-cli --all-targets -- --include-ignored
|
||||
|
||||
dashboard:
|
||||
name: Dashboard — check
|
||||
|
||||
Reference in New Issue
Block a user