ci: run the DB-backed tests that CI was silently skipping
CI ran `cargo test --workspace` with no `--include-ignored`, so it executed 927 tests and skipped 237 — every DB-backed integration test is `#[ignore = "needs DATABASE_URL..."]`, which covers ALL of api.rs, ALL of authz.rs, and the entire CLI journey suite. The isolation and RBAC tests existed but never ran (AUDIT.md F-Q-014, logged and never remediated). CI provides Postgres, so it can run them. Three things had to be right for that to go green: - **`--all-targets`, not a bare workspace run.** `-- --include-ignored` un-ignores not just `#[ignore]` tests but also ` ```ignore ` DOCTESTS, which are illustrative pseudocode that does not compile. `--all-targets` runs lib/bins/ integration tests but excludes doctests (the same reason clippy uses it); a separate `--doc` step runs the doctests without the flag. Structural, so a future pseudocode doctest can't silently break CI either. - **The CLI journeys are their own step.** They spawn a real picloud whose dispatcher/orchestrator claim loops are global by design; run concurrently with the manager-core suites on the shared database they would claim those suites' outbox and workflow rows. Sequential steps keep the live server off the DB while the other suites use it. The step also rebuilds `-p picloud` first (the harness execs the prebuilt binary) and sets the dev-mode env the server needs. - **A higher `max_connections`.** `#[sqlx::test]` pools are lazy, but mass-parallel test startup briefly opens many at once (each test creates its own throwaway database); on a many-core box that transient spike exceeded the default 100 and Postgres answered "sorry, too many clients already". Steady-state peak is only ~26; 500 absorbs the spike with room to spare. Serving the app needs nothing like this many. (This is the local compose ceiling; a small CI runner's default 100 has ample headroom for its lower parallelism.) Also fixes the test the CI gap had let rot: api.rs asserted `v["schema"] == 66` with a hand-bump comment, and since nothing ran it, it sat broken from migration 0066 to 0073. It now asserts `/version` surfaces the live constants (`migrations::latest_version()`, `SDK_VERSION`) — the wiring — while value drift stays caught by schema_snapshot + check-versioning. A constant hand-synced to another constant is a chore, not a test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -890,14 +890,22 @@ async fn version_includes_public_base_url(pool: PgPool) {
|
||||
let v: Value = r.json();
|
||||
assert!(v["public_base_url"].is_string());
|
||||
assert_eq!(v["api"], 1);
|
||||
// `schema` is migrations::latest_version() — the highest embedded
|
||||
// migration number, currently 66 (…0065_group_queues, then
|
||||
// 0066_projects wiring the §7 multi-repo ownership seam). This test is
|
||||
// #[ignore]-gated so it doesn't run in the default `cargo test`; pinned to
|
||||
// current reality so an unintended schema change is still caught. Bump it
|
||||
// whenever a migration lands.
|
||||
assert_eq!(v["schema"], 66);
|
||||
assert_eq!(v["sdk"], "1.10");
|
||||
// This asserts the WIRING — that `/version` actually surfaces the live
|
||||
// constants — not the values themselves. It used to hardcode `66`, with a
|
||||
// comment to bump it by hand on every migration. Nobody did: CI never ran
|
||||
// this test (it is `#[ignore]`d, and CI omitted `--include-ignored`), so it
|
||||
// sat broken from 0066 all the way to 0073 and only surfaced when the CI gap
|
||||
// was closed. A constant that must be hand-synced with a constant is not a
|
||||
// test, it is a chore that fails silently.
|
||||
//
|
||||
// Drift in the values is already caught where it belongs: the schema by
|
||||
// `manager-core/tests/schema_snapshot.rs`, the version surfaces by
|
||||
// `scripts/check-versioning.sh`.
|
||||
assert_eq!(
|
||||
v["schema"],
|
||||
picloud_manager_core::migrations::latest_version()
|
||||
);
|
||||
assert_eq!(v["sdk"], picloud_shared::version::SDK_VERSION);
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
|
||||
Reference in New Issue
Block a user