chore(v1.1.9): clippy clean — workspace -D warnings
Surfaced + fixed during the F3 attestation:
- executor-core/sdk/queue.rs: drop redundant .map(|()| ()) call sites;
enqueue_blocking discards QueueMessageId via .map(|_id| ()) (intentional)
- executor-core/sdk/retry.rs: hoist use std::collections::hash_map::DefaultHasher
+ use std::hash::Hasher to the top of the file (clippy::items_after_statements);
replace `as i64` casts with i64::try_from + clear comment about jitter
bound (clippy::cast_possible_wrap)
- executor-core/sdk/invoke.rs: move _LIMITS_IS_COPY const before #[cfg(test)]
mod tests (clippy::items_after_test_module)
- manager-core/dispatcher.rs: dispatch_one_queue gains #[allow(too_many_lines)]
(it's the queue tick's whole logic — split makes it less readable than
the lint); .map(...).unwrap_or(default) → .map_or(default, ...)
- picloud/lib.rs: Limits { trigger_depth_max, ..Limits::default() } via
struct-update instead of let-mut-assign (clippy::field_reassign_with_default)
- tests: r#"..."# → r"..." where there are no `"` inside (clippy::needless_raw_string_hashes);
combine InvokeTarget::Name | InvokeTarget::Path arms with identical bodies
in sdk_invoke.rs (clippy::match_same_arms)
cargo fmt --all -- --check 2>&1 | tail -3: no output (exit 0)
cargo clippy --workspace --all-targets --all-features -- -D warnings:
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s
Workspace lib smoke: 432 passing (306 manager-core + 74 executor-core + 34 shared + 18 orchestrator-core).
DB-gated E2E (against docker compose postgres on localhost:15432):
queue_e2e: 4 ok / invoke_e2e: 4 ok / retry_e2e: 3 ok / migration_queue_messages: 4 ok / schema_snapshot: 1 ok
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -93,7 +93,9 @@ async fn execute(server: &TestServer, script_id: &str) -> Value {
|
||||
|
||||
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
||||
async fn retry_run_eventually_succeeds_inside_http_handler() {
|
||||
let Some(pool) = pool_or_skip().await else { return };
|
||||
let Some(pool) = pool_or_skip().await else {
|
||||
return;
|
||||
};
|
||||
let (server, app_id) = server_for(pool, "retry-succ").await;
|
||||
|
||||
// attempt counter mutates across retries; the 3rd attempt returns
|
||||
@@ -114,7 +116,9 @@ async fn retry_run_eventually_succeeds_inside_http_handler() {
|
||||
|
||||
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
||||
async fn retry_run_surfaces_last_error_after_max_attempts() {
|
||||
let Some(pool) = pool_or_skip().await else { return };
|
||||
let Some(pool) = pool_or_skip().await else {
|
||||
return;
|
||||
};
|
||||
let (server, app_id) = server_for(pool, "retry-surf").await;
|
||||
|
||||
let src = r#"
|
||||
@@ -135,7 +139,9 @@ async fn retry_run_surfaces_last_error_after_max_attempts() {
|
||||
|
||||
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
||||
async fn retry_on_codes_filters_unmatched_errors() {
|
||||
let Some(pool) = pool_or_skip().await else { return };
|
||||
let Some(pool) = pool_or_skip().await else {
|
||||
return;
|
||||
};
|
||||
let (server, app_id) = server_for(pool, "retry-codes").await;
|
||||
|
||||
// attempts is mutated on every entry; we throw a non-matching code
|
||||
@@ -156,5 +162,9 @@ async fn retry_on_codes_filters_unmatched_errors() {
|
||||
"#;
|
||||
let script_id = create_script(&server, &app_id, "codes", src).await;
|
||||
let body = execute(&server, &script_id).await;
|
||||
assert_eq!(body, json!(1), "non-matching error should surface immediately");
|
||||
assert_eq!(
|
||||
body,
|
||||
json!(1),
|
||||
"non-matching error should surface immediately"
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user