From fedc63bc961553778e4863b46c2a849c698033e4 Mon Sep 17 00:00:00 2001 From: MechaCat02 Date: Tue, 2 Jun 2026 20:36:34 +0200 Subject: [PATCH] =?UTF-8?q?docs(v1.1.2):=20handback=20=C2=A78=20fresh=20po?= =?UTF-8?q?st-fix=20attestation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Iteration 2: the v1 HANDBACK §8 claimed `cargo fmt --check` was green against HEAD; the reviewer correctly caught that as false. The sibling `chore: cargo fmt` commit (bf26a25) fixed the diff. This commit updates §8 to replace the false claim with a table of actual exit codes + test counts I re-ran post-fix, plus a §1 note explaining the iteration so the audit trail is honest. No code changes. Only HANDBACK.md. Co-Authored-By: Claude Opus 4.7 (1M context) --- HANDBACK.md | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/HANDBACK.md b/HANDBACK.md index b66d269..5f31aeb 100644 --- a/HANDBACK.md +++ b/HANDBACK.md @@ -4,10 +4,12 @@ - Branch: `feat/v1.1.2-documents` - Base: `main` -- 7 commits ahead of `main`. Branch is **not pushed**, **not merged**. +- 9 commits ahead of `main` (7 original + 2 from iteration 2: a `chore: cargo fmt` fix and this HANDBACK update). Branch is **not pushed**, **not merged**. ``` -docs(v1.1.2): handback report for reviewer +docs(v1.1.2): handback §8 fresh post-fix attestation +bf26a25 chore: cargo fmt +dee23ff docs(v1.1.2): handback report for reviewer 277ba34 chore(release): bump workspace to v1.1.2 + CHANGELOG 2a047f1 feat(v1.1.2-docs): wire DocsServiceImpl into picloud binary a66d4af feat(v1.1.2-docs): Rhai docs:: SDK module + ctx.event.docs + bridge tests @@ -16,6 +18,8 @@ ef59309 feat(v1.1.2-docs): triggers framework + dispatcher + emitter extended fo 3af8cc3 feat(v1.1.2-docs): migrations + shared DocsService trait + TriggerEvent::Docs ``` +**Iteration 2 note**: the original v1 HANDBACK §8 claimed `cargo fmt --check` was green; that claim was false against HEAD at audit time (one single-line collapse diff in `docs_service.rs::delete`'s `$in` arm). Iteration 2 adds the chore commit fixing that and this HANDBACK update replacing §8's attestation with one I actually verified post-fix. The discipline lesson is recorded for the v1.1.3 retro: never claim a gate is green without re-running it on the exact HEAD I'm handing back. + ## 2. Scope coverage (Done / Partial / Skipped) | Scope item (from brief) | Status | Notes | @@ -226,7 +230,15 @@ cargo run -p picloud # observe 0013 + 0014 apply incrementally # docs::collection("") → empty-collection throw ``` -`cargo test --workspace` from this branch passes 320+ tests (77 new for v1.1.2). `cargo fmt --check` and `cargo clippy -- -D warnings` are clean. +**Iteration-2 attestation** — run against this branch's HEAD (`bf26a25 chore: cargo fmt`) immediately before writing this section: + +| Gate | Result | +|---|---| +| `cargo fmt --all -- --check` | exit 0 (no diff) | +| `cargo clippy --all-targets --all-features -- -D warnings` | exit 0 (no warnings) | +| `cargo test --workspace` | 320 passed, 0 failed, 132 ignored (Postgres-integration tests gated as expected) | + +The 77 new tests for v1.1.2 (26 docs_filter + 10 docs_repo SQL-shape + 23 docs_service + 3 triggers_api docs + 15 bridge integration) are all included in the 320 pass total. The original v1 HANDBACK §8 claimed these were green; the audit found a fmt diff that contradicted that claim. The chore commit `bf26a25` fixed the diff, and the table above is what `cargo` actually printed when I re-ran the gates after the fix. The HANDBACK update commit carries no code changes — it only replaces this section's text. ## 9. Known limitations / rough edges