Commit Graph

2 Commits

Author SHA1 Message Date
MechaCat02
fe1dd90836 feat(executor-core): plumb app_id/principal/depth through ExecRequest
Adds the four internal-only fields every v1.1.x stateful service needs
to isolate by app and audit by caller:

  - app_id            — owning app for this invocation
  - principal         — Option<Principal>; data-plane is unauthenticated
                        today so the orchestrator passes None until the
                        opportunistic middleware lands in the next commit
  - trigger_depth     — 0 for direct invocations; the triggers framework
                        (v1.1.1) bounds runaway feedback loops via this
  - root_execution_id — equal to execution_id for direct invocations;
                        preserved across trigger fan-out for audit grouping

ExecRequest stays serializable (cluster mode still has to ship it across
processes when v1.3+ arrives). principal is `#[serde(skip)]` because
shared::Principal has no wire derivation today — when cluster mode lands
the wire-Principal question gets revisited properly.

Engine now carries a Services bundle (empty in v1.1.0). Engine::execute
constructs an SdkCallCx from the request and hands it to sdk::register_all
just after the per-call Rhai engine is built. The hook is a no-op in v1.1.0;
v1.1.1 KV registers its first native fns there.

Adds ExecError::Overloaded { retry_after_secs } and the matching 503 +
Retry-After mapping in orchestrator-core's IntoResponse. The gate that
actually produces this variant lands in the next commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-30 18:48:39 +02:00
MechaCat02
f33c88b9d0 test(executor-core): golden SDK contract suite
Pins the user-visible Rhai SDK behaviors to a concrete test file so
SemVer enforcement isn't aspirational. **Editing this file is an SDK
version bump event** — the file header documents the rule.

  * 30 tests covering every documented SDK 1.0 + 1.1 surface:
      ctx.sdk_version (format + feature-detection)
      ctx.execution_id / request_id / script_id (UUID shape)
      ctx.script_name (round-trip)
      ctx.invocation_type (http / function / scheduled)
      ctx.request.path / headers / body / params / query / rest
      log::trace / info / warn / error (with and without data)
      response convention: bare value → 200, structured map →
        statusCode pass-through, missing statusCode → wrapped 200,
        non-integer statusCode → InvalidResponse error
      sandbox restrictions: imports blocked, print disabled,
        log::debug rejected (Rhai keyword — use log::trace)
      JSON type fidelity (string/int/float/bool/null/array/object/
        nested round-trip)

  * Separate from tests/engine.rs (which tests internal Engine
    behaviors) — same crate, different audience: engine.rs is
    "does the engine work right", sdk_contract.rs is "does the
    public contract hold". Some overlap is intentional so the
    contract is readable in one place.

  * Plain cargo test --workspace runs all 30 (no infrastructure
    needed); these are pure unit tests.

Wires up enforcement item (3) from docs/versioning.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-23 22:21:10 +02:00