Three related fixes from the test audit. **The CLI journey fixture gets its own database.** It spawned a real picloud — whose dispatcher/orchestrator claim loops are global by design (one instance owns one database) — against the shared dev DB, so it could claim the manager-core suites' outbox/workflow rows (the same class of bug already fixed for the e2e suites, one binary over). It now clones one dedicated database per journey run from the migrated template. test-support gains `named_test_db_url` (explicit stable name) + a blocking wrapper for the sync `LazyLock` fixture. The one journey that talks to Postgres directly (dead-letter injection) now uses the fixture's DB URL, not the base DATABASE_URL, so it hits the database the server reads. **workflow_orchestrator moves to per-test databases.** Its `claim_ready_step` is global, so the old harness serialized every test behind a process-wide CLAIM_LOCK AND ran `DELETE FROM workflow_runs` (unscoped — it wiped every app's runs) before each one. A private database per test makes the global claim see only that test's rows, so both the lock and the unscoped DELETE are deleted. **DB-backed suites fail loud instead of skipping green.** ~15 manager-core suites `return None` when DATABASE_URL is unset and report PASS — so in any environment that lost its database the entire integration surface reports green while running nothing (why the CI gap went unnoticed for so long). New `picloud_test_support::abort_if_db_required` panics when `PICLOUD_REQUIRE_DB` is set (CI now sets it) but DATABASE_URL is not, injected into each suite's skip path. Local runs without the var still skip cleanly. Mutation-verified: with PICLOUD_REQUIRE_DB=1 and DATABASE_URL unset, a suite panics; without the var it skips. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
226 lines
7.8 KiB
Rust
226 lines
7.8 KiB
Rust
//! `pic dead-letters` smoke tests. The ls + show + resolve round trip
|
|
//! is hard to drive end-to-end without forcing a trigger to exhaust
|
|
//! retries (which the dispatcher tests already cover). Instead, write
|
|
//! a synthetic DL row via the admin API and drive the CLI against it.
|
|
|
|
use predicates::prelude::*;
|
|
use serde_json::json;
|
|
|
|
use crate::common;
|
|
use crate::common::cleanup::AppGuard;
|
|
|
|
#[ignore = "needs DATABASE_URL pointing at a running Postgres"]
|
|
#[test]
|
|
fn ls_empty_app_succeeds() {
|
|
let Some(fx) = common::fixture_or_skip() else {
|
|
return;
|
|
};
|
|
let env = common::admin_env(fx);
|
|
let slug = common::unique_slug("dl-empty");
|
|
common::pic_as(&env)
|
|
.args(["apps", "create", &slug])
|
|
.assert()
|
|
.success();
|
|
let _guard = AppGuard::new(&env.url, &env.token, &slug);
|
|
|
|
let out = common::pic_as(&env)
|
|
.args(["dead-letters", "ls", "--app", &slug])
|
|
.output()
|
|
.expect("dl ls");
|
|
assert!(out.status.success(), "ls failed: {out:?}");
|
|
let stdout = String::from_utf8(out.stdout).unwrap();
|
|
let header = stdout.lines().next().expect("header row");
|
|
assert_eq!(
|
|
common::cells(header),
|
|
vec![
|
|
"id",
|
|
"source",
|
|
"op",
|
|
"attempts",
|
|
"resolved",
|
|
"last_error",
|
|
"created_at"
|
|
]
|
|
);
|
|
// No data rows in a fresh app.
|
|
assert_eq!(stdout.lines().count(), 1, "fresh app has no DL rows");
|
|
}
|
|
|
|
#[ignore = "needs DATABASE_URL pointing at a running Postgres"]
|
|
#[test]
|
|
fn count_returns_unresolved_total() {
|
|
let Some(fx) = common::fixture_or_skip() else {
|
|
return;
|
|
};
|
|
let env = common::admin_env(fx);
|
|
let slug = common::unique_slug("dl-count");
|
|
common::pic_as(&env)
|
|
.args(["apps", "create", &slug])
|
|
.assert()
|
|
.success();
|
|
let _guard = AppGuard::new(&env.url, &env.token, &slug);
|
|
|
|
let out = common::pic_as(&env)
|
|
.args(["dead-letters", "count", "--app", &slug])
|
|
.output()
|
|
.expect("dl count");
|
|
assert!(out.status.success(), "count failed: {out:?}");
|
|
let stdout = String::from_utf8(out.stdout).unwrap();
|
|
let header = stdout.lines().next().expect("header");
|
|
assert_eq!(common::cells(header), vec!["unresolved"]);
|
|
let row = stdout.lines().nth(1).expect("data row");
|
|
assert_eq!(common::cells(row), vec!["0"]);
|
|
}
|
|
|
|
#[ignore = "needs DATABASE_URL pointing at a running Postgres"]
|
|
#[test]
|
|
fn replay_against_real_dl_row_succeeds() {
|
|
use postgres::{Client as PgClient, NoTls};
|
|
use uuid::Uuid;
|
|
|
|
let Some(fx) = common::fixture_or_skip() else {
|
|
return;
|
|
};
|
|
let env = common::admin_env(fx);
|
|
let (script_id_str, guard) = common::deploy_fixture(&env, "dl-replay", "hello.rhai");
|
|
let app_slug = guard.slug().to_string();
|
|
|
|
// Need the app's UUID to inject the DL row. Resolve via the admin
|
|
// GET — picloud accepts either slug or id, returns both.
|
|
let app_id: String = reqwest::blocking::Client::new()
|
|
.get(format!("{}/api/v1/admin/apps/{}", env.url, app_slug))
|
|
.bearer_auth(&env.token)
|
|
.send()
|
|
.expect("apps_get")
|
|
.json::<serde_json::Value>()
|
|
.expect("apps_get json")["id"]
|
|
.as_str()
|
|
.expect("app id")
|
|
.to_string();
|
|
|
|
// Direct INSERT — no admin endpoint creates DL rows; the real ones
|
|
// come from the dispatcher's retry-exhaust path, which would take
|
|
// minutes to drive. The replay path doesn't care how the row got
|
|
// there, only that it exists, belongs to this app, and is
|
|
// unresolved.
|
|
// Inject into the SAME database the spawned picloud is using — the fixture's
|
|
// per-journey-run cloned DB, not the base DATABASE_URL. Using DATABASE_URL
|
|
// here would write the row into a different database than the server reads.
|
|
let mut pg = PgClient::connect(&fx.database_url, NoTls).expect("postgres connect");
|
|
let dl_id = Uuid::new_v4();
|
|
let app_uuid = Uuid::parse_str(&app_id).expect("app uuid");
|
|
let script_uuid = Uuid::parse_str(&script_id_str).expect("script uuid");
|
|
// Payload shape must round-trip through the dispatcher: source="kv"
|
|
// matches a KV TriggerEvent, op="set" is a KvEventOp, and the
|
|
// service_kind=`kv` outbox row gets routed by resolve_trigger.
|
|
let payload = serde_json::json!({
|
|
"source": "kv",
|
|
"op": "set",
|
|
"kv": {
|
|
"collection": "x",
|
|
"key": "y",
|
|
"value": { "v": 1 }
|
|
}
|
|
});
|
|
pg.execute(
|
|
"INSERT INTO dead_letters (
|
|
id, app_id, original_event_id, source, op, trigger_id, script_id,
|
|
payload, attempt_count, first_attempt_at, last_attempt_at, last_error
|
|
) VALUES ($1, $2, $3, 'kv', 'set', NULL, $4, $5, 1, NOW(), NOW(), 'forced')",
|
|
&[&dl_id, &app_uuid, &Uuid::new_v4(), &script_uuid, &payload],
|
|
)
|
|
.expect("insert synthetic DL row");
|
|
|
|
// Verify CLI count picks the row up.
|
|
let out = common::pic_as(&env)
|
|
.args(["dead-letters", "count", "--app", &app_slug])
|
|
.output()
|
|
.expect("dl count");
|
|
let stdout = String::from_utf8(out.stdout).unwrap();
|
|
assert!(
|
|
stdout.lines().nth(1) == Some("1"),
|
|
"count should be 1: {stdout}"
|
|
);
|
|
|
|
// Replay — pic exits 0, the server resolves the row with reason=replayed.
|
|
common::pic_as(&env)
|
|
.args([
|
|
"dead-letters",
|
|
"replay",
|
|
"--app",
|
|
&app_slug,
|
|
&dl_id.to_string(),
|
|
])
|
|
.assert()
|
|
.success()
|
|
.stdout(predicate::str::contains("Replayed dead-letter"));
|
|
|
|
// Verify the row is now resolved with reason=replayed.
|
|
let row = pg
|
|
.query_one(
|
|
"SELECT resolution FROM dead_letters WHERE id = $1",
|
|
&[&dl_id],
|
|
)
|
|
.expect("dl row exists post-replay");
|
|
let resolution: Option<String> = row.get(0);
|
|
assert_eq!(resolution.as_deref(), Some("replayed"));
|
|
|
|
// And the unresolved count drops back to 0.
|
|
let out = common::pic_as(&env)
|
|
.args(["dead-letters", "count", "--app", &app_slug])
|
|
.output()
|
|
.expect("dl count");
|
|
let stdout = String::from_utf8(out.stdout).unwrap();
|
|
assert!(
|
|
stdout.lines().nth(1) == Some("0"),
|
|
"count should be 0 after replay: {stdout}"
|
|
);
|
|
}
|
|
|
|
#[ignore = "needs DATABASE_URL pointing at a running Postgres"]
|
|
#[test]
|
|
fn resolve_marks_row_resolved() {
|
|
let Some(fx) = common::fixture_or_skip() else {
|
|
return;
|
|
};
|
|
let env = common::admin_env(fx);
|
|
let (script_id, guard) = common::deploy_fixture(&env, "dl-resolve", "hello.rhai");
|
|
let app = guard.slug().to_string();
|
|
|
|
// Synth a DL row directly through the existing admin path —
|
|
// there's no test-only insert endpoint, so we use the resolve
|
|
// API on an arbitrary id and assert 404 (the path resolves cleanly
|
|
// but the row doesn't exist). The intent here is to assert the
|
|
// CLI plumbs the URL correctly; force-exhausting retries from a
|
|
// CLI test is too slow.
|
|
let _ = script_id; // suppress unused warning
|
|
|
|
let client = reqwest::blocking::Client::new();
|
|
let resp = client
|
|
.post(format!(
|
|
"{}/api/v1/admin/apps/{}/dead_letters/{}/resolve",
|
|
env.url, app, "00000000-0000-0000-0000-000000000000"
|
|
))
|
|
.bearer_auth(&env.token)
|
|
.json(&json!({ "reason": "test" }))
|
|
.send()
|
|
.expect("resolve");
|
|
assert_eq!(resp.status().as_u16(), 404);
|
|
|
|
// The CLI mirrors that 404 — verify the wire round-trips through
|
|
// pic without mangling the path.
|
|
common::pic_as(&env)
|
|
.args([
|
|
"dead-letters",
|
|
"resolve",
|
|
"--app",
|
|
&app,
|
|
"00000000-0000-0000-0000-000000000000",
|
|
"--reason",
|
|
"test",
|
|
])
|
|
.assert()
|
|
.failure()
|
|
.stderr(predicate::str::contains("HTTP 404"));
|
|
}
|