PiCloud/crates/manager-core/src/topic_repo.rs

//! `TopicRepo` — CRUD for the `topics` table (v1.1.6).
//!
//! This table holds ONLY topics that have been explicitly externalized
//! for SSE subscription (design notes §5). Internal-only pub/sub topics
//! stay implicit — they never get a row here, and the publish path never
//! consults this table. The two readers are the topic admin endpoints
//! ([`crate::topics_api`]) and the SSE subscribe authorization
//! ([`crate::realtime_authority`]).

use async_trait::async_trait;
use chrono::{DateTime, Utc};
use picloud_shared::AppId;
use serde::{Deserialize, Serialize};
use sqlx::PgPool;

/// External-subscriber auth gate for a topic. v1.1.6 shipped
/// `'public'` + `'token'`; v1.1.8 F3 adds `'session'` (per-app user
/// sessions authorize subscription); `'script'` (v1.2) extends the
/// DB CHECK constraint and this enum later.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum TopicAuthMode {
    Public,
    Token,
    Session,
}

impl TopicAuthMode {
    #[must_use]
    pub const fn as_str(self) -> &'static str {
        match self {
            Self::Public => "public",
            Self::Token => "token",
            Self::Session => "session",
        }
    }

    fn from_db(s: &str) -> Result<Self, TopicRepoError> {
        match s {
            "public" => Ok(Self::Public),
            "token" => Ok(Self::Token),
            "session" => Ok(Self::Session),
            other => Err(TopicRepoError::Backend(format!(
                "unknown auth_mode in DB: {other}"
            ))),
        }
    }
}

/// A registered, externally-subscribable topic row.
#[derive(Debug, Clone, Serialize)]
pub struct Topic {
    pub name: String,
    pub external_subscribable: bool,
    pub auth_mode: TopicAuthMode,
    pub created_at: DateTime<Utc>,
    pub updated_at: DateTime<Utc>,
}

#[derive(Debug, thiserror::Error)]
pub enum TopicRepoError {
    #[error("a topic named {0:?} already exists in this app")]
    AlreadyExists(String),
    #[error("database error: {0}")]
    Db(#[from] sqlx::Error),
    #[error("topic backend error: {0}")]
    Backend(String),
}

#[async_trait]
pub trait TopicRepo: Send + Sync {
    /// Register a topic. Errors `AlreadyExists` on PK conflict.
    async fn create(
        &self,
        app_id: AppId,
        name: &str,
        external_subscribable: bool,
        auth_mode: TopicAuthMode,
    ) -> Result<Topic, TopicRepoError>;

    /// List every registered topic in the app, ordered by name.
    async fn list(&self, app_id: AppId) -> Result<Vec<Topic>, TopicRepoError>;

    /// Fetch one topic by name, `None` if not registered.
    async fn get(&self, app_id: AppId, name: &str) -> Result<Option<Topic>, TopicRepoError>;

    /// Update `external_subscribable` and/or `auth_mode` (each `None`
    /// leaves the column unchanged). `None` return = no such topic.
    async fn update(
        &self,
        app_id: AppId,
        name: &str,
        external_subscribable: Option<bool>,
        auth_mode: Option<TopicAuthMode>,
    ) -> Result<Option<Topic>, TopicRepoError>;

    /// Unregister a topic. Returns `true` if a row was removed.
    async fn delete(&self, app_id: AppId, name: &str) -> Result<bool, TopicRepoError>;
}

#[derive(sqlx::FromRow)]
struct TopicRow {
    name: String,
    external_subscribable: bool,
    auth_mode: String,
    created_at: DateTime<Utc>,
    updated_at: DateTime<Utc>,
}

impl TopicRow {
    fn into_topic(self) -> Result<Topic, TopicRepoError> {
        Ok(Topic {
            auth_mode: TopicAuthMode::from_db(&self.auth_mode)?,
            name: self.name,
            external_subscribable: self.external_subscribable,
            created_at: self.created_at,
            updated_at: self.updated_at,
        })
    }
}

const SELECT_COLS: &str = "name, external_subscribable, auth_mode, created_at, updated_at";

pub struct PostgresTopicRepo {
    pool: PgPool,
}

impl PostgresTopicRepo {
    #[must_use]
    pub fn new(pool: PgPool) -> Self {
        Self { pool }
    }
}

#[async_trait]
impl TopicRepo for PostgresTopicRepo {
    async fn create(
        &self,
        app_id: AppId,
        name: &str,
        external_subscribable: bool,
        auth_mode: TopicAuthMode,
    ) -> Result<Topic, TopicRepoError> {
        let row: Option<TopicRow> = sqlx::query_as(&format!(
            "INSERT INTO topics (app_id, name, external_subscribable, auth_mode) \
             VALUES ($1, $2, $3, $4) \
             ON CONFLICT (app_id, name) DO NOTHING \
             RETURNING {SELECT_COLS}"
        ))
        .bind(app_id.into_inner())
        .bind(name)
        .bind(external_subscribable)
        .bind(auth_mode.as_str())
        .fetch_optional(&self.pool)
        .await?;
        match row {
            Some(r) => r.into_topic(),
            None => Err(TopicRepoError::AlreadyExists(name.to_string())),
        }
    }

    async fn list(&self, app_id: AppId) -> Result<Vec<Topic>, TopicRepoError> {
        let rows: Vec<TopicRow> = sqlx::query_as(&format!(
            "SELECT {SELECT_COLS} FROM topics WHERE app_id = $1 ORDER BY name"
        ))
        .bind(app_id.into_inner())
        .fetch_all(&self.pool)
        .await?;
        rows.into_iter().map(TopicRow::into_topic).collect()
    }

    async fn get(&self, app_id: AppId, name: &str) -> Result<Option<Topic>, TopicRepoError> {
        let row: Option<TopicRow> = sqlx::query_as(&format!(
            "SELECT {SELECT_COLS} FROM topics WHERE app_id = $1 AND name = $2"
        ))
        .bind(app_id.into_inner())
        .bind(name)
        .fetch_optional(&self.pool)
        .await?;
        row.map(TopicRow::into_topic).transpose()
    }

    async fn update(
        &self,
        app_id: AppId,
        name: &str,
        external_subscribable: Option<bool>,
        auth_mode: Option<TopicAuthMode>,
    ) -> Result<Option<Topic>, TopicRepoError> {
        // COALESCE leaves a column untouched when its bind is NULL.
        let row: Option<TopicRow> = sqlx::query_as(&format!(
            "UPDATE topics SET \
                external_subscribable = COALESCE($3, external_subscribable), \
                auth_mode = COALESCE($4, auth_mode), \
                updated_at = NOW() \
             WHERE app_id = $1 AND name = $2 \
             RETURNING {SELECT_COLS}"
        ))
        .bind(app_id.into_inner())
        .bind(name)
        .bind(external_subscribable)
        .bind(auth_mode.map(TopicAuthMode::as_str))
        .fetch_optional(&self.pool)
        .await?;
        row.map(TopicRow::into_topic).transpose()
    }

    async fn delete(&self, app_id: AppId, name: &str) -> Result<bool, TopicRepoError> {
        let res = sqlx::query("DELETE FROM topics WHERE app_id = $1 AND name = $2")
            .bind(app_id.into_inner())
            .bind(name)
            .execute(&self.pool)
            .await?;
        Ok(res.rows_affected() > 0)
    }
}