From 02cf187555fc7a8034b1f98a1bff5d01e3411014 Mon Sep 17 00:00:00 2001 From: atdt Date: Thu, 4 Apr 2019 08:17:45 -0700 Subject: [PATCH] Remove MSan exemption for _bzhi_u32, since LLVM now handles it correctly. This cleans up a TODO from cl/225463783 and cl/225655713. PiperOrigin-RevId: 241933185 --- snappy.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/snappy.cc b/snappy.cc index 2d9436d..b78cd12 100644 --- a/snappy.cc +++ b/snappy.cc @@ -718,9 +718,7 @@ static inline void Report(const char *algorithm, size_t compressed_size, static inline uint32 ExtractLowBytes(uint32 v, int n) { assert(n >= 0); assert(n <= 4); - // TODO(b/121042345): Remove !defined(MEMORY_SANITIZER) once MSan - // handles _bzhi_u32() correctly. -#if SNAPPY_HAVE_BMI2 && !defined(MEMORY_SANITIZER) +#if SNAPPY_HAVE_BMI2 return _bzhi_u32(v, 8 * n); #else // This needs to be wider than uint32 otherwise `mask << 32` will be