fabi/Snappy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tighten types on a few for loops.

Browse Source 
* Replace post-increment with pre-increment in for loops.
* Replace unsigned int counters with precise types, like uint8_t.
* Switch to C++11 iterating loops when possible.

PiperOrigin-RevId: 309724233
This commit is contained in:
Victor Costan
2020-05-04 12:31:03 +00:00
parent abde3abb1f
commit 113cd97ab3
2 changed files with 55 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
snappy.cc
View File

@@ -557,8 +557,8 @@ char* CompressFragment(const char* input,
const char* candidate;
if (ip_limit - ip >= 16) {
auto delta = ip - base_ip;
for (int j = 0; j < 4; j++) {
for (int k = 0; k < 4; k++) {
for (int j = 0; j < 4; ++j) {
for (int k = 0; k < 4; ++k) {
int i = 4 * j + k;
// These for-loops are meant to be unrolled. So we can freely
// special case the first iteration to use the value already
@@ -1675,10 +1675,9 @@ class SnappySinkAllocator {
// to the blocks.
void Flush(size_t size) {
size_t size_written = 0;
size_t block_size;
for (int i = 0; i < blocks_.size(); ++i) {
block_size = std::min<size_t>(blocks_[i].size, size - size_written);
dest_->AppendAndTakeOwnership(blocks_[i].data, block_size,
for (Datablock& block : blocks_) {
size_t block_size = std::min<size_t>(block.size, size - size_written);
dest_->AppendAndTakeOwnership(block.data, block_size,
&SnappySinkAllocator::Deleter, NULL);
size_written += block_size;
}